New sculpting tools #67518

New Issue

Brecht Van Lommel · 2019-07-23T15:07:22+02:00

Brecht Van Lommel commented

2019-07-23 15:07:22 +02:00

The sculpt branch has new tools for masking, filtering, transforming, etc. This task is about merging those tools to master, and issues to solve before that is possible.

Mesh Data Structures

The main issue right now is that they only work for regular meshes, not multires and dyntopo.

For dyntopo using BMesh, some abstraction can be added in the code mainly to access neighboring vertices, and storing temporary per-vertex data. This data can be stored in arrays in SculptSession, and BM_elem_index_get(v) can be used for indexing into the arrays. This data does not need to preserved when changing topology, so we can just remove then to avoid accessing invalid data.

For multires things are more complicated. What we propose to do here instead is to remove the multires memory optimization which avoids creating a full Mesh and keeps data in grids in sculpt mode. The real-world advantages of this are questionable in the current architecture anyway. Instead there would just be a Mesh and BMesh for the sculpting and drawing code to deal with, and data would be synced to/from grids when exiting/entering sculpt mode. This will hopefully lead to much simplified code, but we have to verify that performance and memory usage remains acceptable.

The sculpt branch has new tools for masking, filtering, transforming, etc. This task is about merging those tools to master, and issues to solve before that is possible. **Mesh Data Structures** The main issue right now is that they only work for regular meshes, not multires and dyntopo. For dyntopo using BMesh, some abstraction can be added in the code mainly to access neighboring vertices, and storing temporary per-vertex data. This data can be stored in arrays in `SculptSession`, and `BM_elem_index_get(v)` can be used for indexing into the arrays. This data does not need to preserved when changing topology, so we can just remove then to avoid accessing invalid data. For multires things are more complicated. What we propose to do here instead is to remove the multires memory optimization which avoids creating a full Mesh and keeps data in grids in sculpt mode. The real-world advantages of this are questionable in the current architecture anyway. Instead there would just be a Mesh and BMesh for the sculpting and drawing code to deal with, and data would be synced to/from grids when exiting/entering sculpt mode. This will hopefully lead to much simplified code, but we have to verify that performance and memory usage remains acceptable.

Brecht Van Lommel commented

2019-07-23 15:07:22 +02:00

Added subscriber: @brecht

Brecht Van Lommel commented

2019-07-23 15:08:10 +02:00

Added subscriber: @PabloDobarro

Jacques Lucke commented

2019-07-23 15:39:51 +02:00

Added subscriber: @JacquesLucke

Erick Tukuniata commented

2019-07-24 17:41:47 +02:00

Added subscriber: @ErickNyanduKabongo

Erick Tukuniata commented

2019-07-24 17:41:47 +02:00

This comment was removed by @ErickNyanduKabongo

*This comment was removed by @ErickNyanduKabongo*

Brecht Van Lommel commented

2019-07-24 17:43:50 +02:00

Rewriting multires is not related to this task, let's stay on topic here.

Pablo Dobarro commented

2019-07-26 16:33:02 +02:00

I made the first version of the API and the mask by normal operator seems to be working fine with dyntopo. I'm going to port the mask expand operator and the smooth mesh filter. If those two work, I think it's safe to say that every tool in the sculpt branch is going to work.

Pablo Dobarro commented

2019-07-26 19:43:55 +02:00

Everything seems to be working just fine. I will prepare the final patch to be reviewed as soon as possible. 2019-07-26 19-25-20.mp4.

Everything seems to be working just fine. I will prepare the final patch to be reviewed as soon as possible. [2019-07-26 19-25-20.mp4](https://archive.blender.org/developer/F7630145/2019-07-26_19-25-20.mp4).

Erick Tukuniata commented

2019-07-26 20:10:35 +02:00

Looking good :)