Extend Horizontal (RGB Curves Node) does not work outside the Clipping boundaries #67981

New Issue

Yevgeny Makarov · 2019-07-31T08:56:13+02:00

Yevgeny Makarov commented

2019-07-31 08:56:13 +02:00

Blender Version
Broken: 2.80, 2.79

Short description of error

The Extend Horizontal option of the Compositor's RGB Curves Node
does not work (acts as Extrapolated) outside the boundaries set by the Clipping option.

In the Shader Editor, Extend Horizontal works if the endpoint is in the range [0,1],
but if the endpoint is outside [0,1] it acts as the Extrapolated.

compositor:

shader editor:

curve-visualizer-compositor.blend

curve-visualizer-shader.blend

**Blender Version** Broken: 2.80, 2.79 **Short description of error** The **Extend Horizontal** option of the Compositor's **RGB Curves Node** does not work (acts as Extrapolated) outside the boundaries set by the Clipping option. In the Shader Editor, Extend Horizontal works if the endpoint is in the range [0,1], but if the endpoint is outside [0,1] it acts as the Extrapolated. compositor: ![extend-horizontal-compositor.png](https://archive.blender.org/developer/F7638869/extend-horizontal-compositor.png) shader editor: ![extend-horizontal-shader.png](https://archive.blender.org/developer/F7638870/extend-horizontal-shader.png) ![extend-horizontal-shader-out.png](https://archive.blender.org/developer/F7638931/extend-horizontal-shader-out.png) [curve-visualizer-compositor.blend](https://archive.blender.org/developer/F7638902/curve-visualizer-compositor.blend) [curve-visualizer-shader.blend](https://archive.blender.org/developer/F7638903/curve-visualizer-shader.blend)

Yevgeny Makarov commented

2019-07-31 08:56:13 +02:00

Added subscriber: @jenkm

Philipp Oeser commented

2019-07-31 11:34:35 +02:00

Added subscribers: @Jeroen-Bakker, @lichtwerk

Philipp Oeser commented

2019-07-31 11:34:35 +02:00

Can confirm for the compositor.
@Jeroen-Bakker: mind having a look here?

Having trouble reproducing the shader example, seems to work fine here (2.8 af4dcc6073)?
curve-visualizer-shader-no-repro.blend
@jenkm: mind attaching a file (already set up to show the failing in the shader case -- might have done something wrong in my file...)

Can confirm for the compositor. @Jeroen-Bakker: mind having a look here? Having trouble reproducing the shader example, seems to work fine here (2.8 af4dcc6073)? [curve-visualizer-shader-no-repro.blend](https://archive.blender.org/developer/F7639281/curve-visualizer-shader-no-repro.blend) @jenkm: mind attaching a file (already set up to show the failing in the shader case -- might have done something wrong in my file...)

Jeroen Bakker was assigned by Philipp Oeser

2019-07-31 11:34:50 +02:00

Yevgeny Makarov commented

2019-07-31 12:21:47 +02:00

curve-visualizer-shader-2.blend

set the endpoint to 1.25

it looks correctly in the Look Dev:

but Render wrong:

System Information
Operating system: Darwin-18.6.0-x86_64-i386-64bit 64 Bits
Graphics card: AMD Radeon Pro 455 OpenGL Engine ATI Technologies Inc. 4.1 ATI-2.9.26

Blender Version
Broken: version: 2.81 (sub 0), branch: master, commit date: 2019-07-30 20:50, hash: 5359b7a033

[curve-visualizer-shader-2.blend](https://archive.blender.org/developer/F7639336/curve-visualizer-shader-2.blend) set the endpoint to 1.25 ![extend-horizontal-shader-node.png](https://archive.blender.org/developer/F7639339/extend-horizontal-shader-node.png) it looks correctly in the Look Dev: ![extend-horizontal-shader-lookdev.png](https://archive.blender.org/developer/F7639337/extend-horizontal-shader-lookdev.png) but Render wrong: ![extend-horizontal-shader-render.png](https://archive.blender.org/developer/F7639338/extend-horizontal-shader-render.png) *** **System Information** Operating system: Darwin-18.6.0-x86_64-i386-64bit 64 Bits Graphics card: AMD Radeon Pro 455 OpenGL Engine ATI Technologies Inc. 4.1 ATI-2.9.26 **Blender Version** Broken: version: 2.81 (sub 0), branch: master, commit date: 2019-07-30 20:50, hash: `5359b7a033`

Philipp Oeser commented

2019-07-31 13:03:52 +02:00

Ah, OK, get it, thx for getting back

Jeroen Bakker commented

2019-08-06 15:17:05 +02:00

Seems to be a dual state problem.

The CRGB curves stores the horizontal extension per curve C, R, G and B. when evaluating the curves only the horizontal extension of the R, G and B channels are checked. The setting in the C-curve is ignored completely. In the files provided the C channel only has the horizontal extension turned on the rest of the channels are turned off hence the extension is not available. I would suggest that this is not a small change, but we needs some overall guidance how this control needs to work. And based on the outcome of this we should make sure all users use the component the same manner.

an option would be to always draw all curves in the control, so the user sees better what happens. Another option would be to only have a single horizontal extension stored that is used by all 4 curves (limits current implementation, but perhaps easier to understand). The second option will break current files.

Seems to be a dual state problem. The CRGB curves stores the `horizontal extension` per curve C, R, G and B. when evaluating the curves only the horizontal extension of the R, G and B channels are checked. The setting in the C-curve is ignored completely. In the files provided the C channel only has the horizontal extension turned on the rest of the channels are turned off hence the extension is not available. I would suggest that this is not a small change, but we needs some overall guidance how this control needs to work. And based on the outcome of this we should make sure all users use the component the same manner. an option would be to always draw all curves in the control, so the user sees better what happens. Another option would be to only have a single `horizontal extension` stored that is used by all 4 curves (limits current implementation, but perhaps easier to understand). The second option will break current files.

Jeroen Bakker commented

2019-08-06 15:25:53 +02:00

Added subscriber: @brecht

Jeroen Bakker commented

2019-08-06 15:25:53 +02:00

@brecht how can we move forward with this issue? I checked with Bastien, he proposed to check with you.

Brecht Van Lommel commented

2019-08-13 06:21:27 +02:00

Another option would be to only have a single horizontal extension stored that is used by all 4 curves (limits current implementation, but perhaps easier to understand). The second option will break current files.

To me this seems like the right solution, even if it breaks compatibility.

> Another option would be to only have a single horizontal extension stored that is used by all 4 curves (limits current implementation, but perhaps easier to understand). The second option will break current files. To me this seems like the right solution, even if it breaks compatibility.

Jeroen Bakker commented

2019-11-27 16:13:46 +01:00

Changed status from 'Open' to: 'Resolved'

Jeroen Bakker closed this issue

2019-11-27 16:13:46 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Extend Horizontal (RGB Curves Node) does not work outside the Clipping boundaries #67981