Shrinkwrap modifier with proyect not working in curves #68489

New Issue

Jose Moreno · 2019-08-10T01:15:31+02:00

Jose Moreno commented

2019-08-10 01:15:31 +02:00

System Information
Operating system: Windows-10-10.0.17134 64 Bits
Graphics card: GeForce GTX 1080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 430.64

Blender Version
Broken: version: 2.80 (sub 75), branch: master, commit date: 2019-07-29 14:47, hash: f6cb5f5449
Worked: (optional)

Short description of error
Hello, I´m trying to retopo cylinders using curves but when I use the option "project" the modifier just don't work, the other options works correctly

Exact steps for others to reproduce the error
Create a cylinder and scale it in Z axis until it looks like a pencil or similar, then create a curve (bezier or path) with the same direction of the cylinder and add some depth in the geometry panel of the curve until it fits the shape of the cylinder (a little bit inside), then add a shrinkwrap modifier to the curve and select the cylinder as target, then change the mode to proyect and the shrinkwrap will stop working.

{F7656692}

#68489.blend

**System Information** Operating system: Windows-10-10.0.17134 64 Bits Graphics card: GeForce GTX 1080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 430.64 **Blender Version** Broken: version: 2.80 (sub 75), branch: master, commit date: 2019-07-29 14:47, hash: `f6cb5f5449` Worked: (optional) **Short description of error** Hello, I´m trying to retopo cylinders using curves but when I use the option "project" the modifier just don't work, the other options works correctly **Exact steps for others to reproduce the error** Create a cylinder and scale it in Z axis until it looks like a pencil or similar, then create a curve (bezier or path) with the same direction of the cylinder and add some depth in the geometry panel of the curve until it fits the shape of the cylinder (a little bit inside), then add a shrinkwrap modifier to the curve and select the cylinder as target, then change the mode to proyect and the shrinkwrap will stop working. {[F7656692](https://archive.blender.org/developer/F7656692/Screenshot_2.png)}![Screenshot_3.png](https://archive.blender.org/developer/F7656695/Screenshot_3.png) [#68489.blend](https://archive.blender.org/developer/F8264289/T68489.blend)

Jose Moreno commented

2019-08-10 01:15:31 +02:00

Added subscriber: @Parabox

Germano Cavalcante commented

2019-12-30 13:57:39 +01:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2019-12-30 13:57:39 +01:00

Thanks for the report.
Sorry for the delay in replying.
Can you provide a simple .blend file showing the problem?
This makes the investigation simpler.

Thanks for the report. Sorry for the delay in replying. Can you provide a simple .blend file showing the problem? This makes the investigation simpler.

Philipp Oeser commented

2020-01-07 12:40:57 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2020-01-07 12:40:57 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2020-01-07 12:40:57 +01:00

Can confirm.

#68489.blend

Can confirm. [#68489.blend](https://archive.blender.org/developer/F8264289/T68489.blend)

Philipp Oeser commented

2020-01-07 12:45:41 +01:00

This appears to be working in 2.79.

Philipp Oeser commented

2020-01-07 13:38:49 +01:00

Added subscriber: @mont29

Philipp Oeser commented

2020-01-07 13:38:49 +01:00

This seems to doing the trick:

P1206: T68489_snippet



diff --git a/source/blender/blenkernel/intern/shrinkwrap.c b/source/blender/blenkernel/intern/shrinkwrap.c
index a2699e767e9..7fe3842e3e4 100644
--- a/source/blender/blenkernel/intern/shrinkwrap.c
+++ b/source/blender/blenkernel/intern/shrinkwrap.c
@@ -659,6 +659,7 @@ static void shrinkwrap_calc_normal_projection(ShrinkwrapCalcData *calc)
   /* Prepare data to retrieve the direction in which we should project each vertex */
   if (calc->smd->projAxis == MOD_SHRINKWRAP_PROJECT_OVER_NORMAL) {
     if (calc->vert == NULL) {
+      /* this will happen for curves. */
       return;
     }
   }
diff --git a/source/blender/modifiers/intern/MOD_shrinkwrap.c b/source/blender/modifiers/intern/MOD_shrinkwrap.c
index b8d0b19b7bf..48bdb5361aa 100644
--- a/source/blender/modifiers/intern/MOD_shrinkwrap.c
+++ b/source/blender/modifiers/intern/MOD_shrinkwrap.c
@@ -108,8 +108,11 @@ static void deformVerts(ModifierData *md,
   struct Scene *scene = DEG_get_evaluated_scene(ctx->depsgraph);
   Mesh *mesh_src = NULL;
 
-  if (ctx->object->type == OB_MESH) {
+  /* 4cde92303f made this MESH only */
+  /* Seems to work fine for curves though. */
+  if (ELEM(ctx->object->type, OB_MESH, OB_CURVE)) {
     /* mesh_src is only needed for vgroups. */
+    /* Nope, also needed for MOD_SHRINKWRAP_PROJECT 'calc.vert' in shrinkwrapModifier_deform() */
     mesh_src = MOD_deform_mesh_eval_get(ctx->object, NULL, mesh, NULL, numVerts, false, false);
   }

CC @mont29
CC @mano-wii

This seems to doing the trick: [P1206: T68489_snippet](https://archive.blender.org/developer/P1206.txt) ``` diff --git a/source/blender/blenkernel/intern/shrinkwrap.c b/source/blender/blenkernel/intern/shrinkwrap.c index a2699e767e9..7fe3842e3e4 100644 --- a/source/blender/blenkernel/intern/shrinkwrap.c +++ b/source/blender/blenkernel/intern/shrinkwrap.c @@ -659,6 +659,7 @@ static void shrinkwrap_calc_normal_projection(ShrinkwrapCalcData *calc) /* Prepare data to retrieve the direction in which we should project each vertex */ if (calc->smd->projAxis == MOD_SHRINKWRAP_PROJECT_OVER_NORMAL) { if (calc->vert == NULL) { + /* this will happen for curves. */ return; } } diff --git a/source/blender/modifiers/intern/MOD_shrinkwrap.c b/source/blender/modifiers/intern/MOD_shrinkwrap.c index b8d0b19b7bf..48bdb5361aa 100644 --- a/source/blender/modifiers/intern/MOD_shrinkwrap.c +++ b/source/blender/modifiers/intern/MOD_shrinkwrap.c @@ -108,8 +108,11 @@ static void deformVerts(ModifierData *md, struct Scene *scene = DEG_get_evaluated_scene(ctx->depsgraph); Mesh *mesh_src = NULL; - if (ctx->object->type == OB_MESH) { + /* 4cde92303f made this MESH only */ + /* Seems to work fine for curves though. */ + if (ELEM(ctx->object->type, OB_MESH, OB_CURVE)) { /* mesh_src is only needed for vgroups. */ + /* Nope, also needed for MOD_SHRINKWRAP_PROJECT 'calc.vert' in shrinkwrapModifier_deform() */ mesh_src = MOD_deform_mesh_eval_get(ctx->object, NULL, mesh, NULL, numVerts, false, false); } ``` CC @mont29 CC @mano-wii

Germano Cavalcante commented

2020-01-08 13:10:45 +01:00

The patch looks ok, (if the regression was caused only by 4cde92303f).
Getting mesh_src through MOD_deform_mesh_eval_get instead of ctx->object->data should already solve that other problem.

It would only improve the comments, (both new and existing).

The patch looks ok, (if the regression was caused only by 4cde92303f). Getting `mesh_src` through `MOD_deform_mesh_eval_get` instead of `ctx->object->data` should already solve that other problem. It would only improve the comments, (both new and existing).

blender-admin commented

2020-01-08 13:25:38 +01:00

This issue was referenced by 5977ed3470

This issue was referenced by 5977ed34709ce56823ef755d9c702b8cebba1edd

Philipp Oeser commented

2020-01-15 10:01:13 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Philipp Oeser closed this issue

2020-01-15 10:01:13 +01:00

Philipp Oeser self-assigned this 2020-01-15 10:01:13 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Shrinkwrap modifier with proyect not working in curves #68489