Improve communication of auto-save behavior by adding dialog box to "Load Factory Preferences/Settings" #68649

New Issue

Campbell Barton · 2019-08-14T15:37:13+02:00

Campbell Barton commented

2019-08-14 15:37:13 +02:00

Adding this task based on a discussion about improving usability to auto-save preferences when loading factory settings.

Currently when loading factory settings, the preferences don't auto-save, even though loading the factory settings enables the auto-save option.

The rationale here is that we want to allow users to temporarily load factory settings without it overwriting their own preferences.

In this case explicitly saving needs to be done to overwrite their preferences.

This task is not to re-open the design discussion, for some context on the topic see other discussions.

For reference, discussion on this topic:

D4863 - Preferences UI patch for Save/Revert/Reset
D5236 - Remove option for disabling the override when factory settings are loaded
#66675 - Tooltip urgently needed for Preferences editor button to avoid user data loss with factory-defaults.
4a5e046c92 UI: remove button to enable auto-save after load factory preferences

Based on discussion with @JulienKaspar, @dr.sybren & @WilliamReynish - we agree the current logic isn't well communicated to the user,
since loading factory settings puts Blender in a state where auto-save is checked but ignored.

This could be mitigated using a dialog which lets the user know what happens when loading factory settings.

Suggested text:

Loading factory preferences won't automatically save your preferences on exit.
To overwrite your current preferences you must manually save the preferences.

*Adding this task based on a discussion about improving usability to auto-save preferences when loading factory settings.* Currently when loading factory settings, the preferences don't auto-save, even though loading the factory settings enables the auto-save option. The rationale here is that we want to allow users to temporarily load factory settings without it overwriting their own preferences. In this case explicitly saving needs to be done to overwrite their preferences. This task is not to re-open the design discussion, for some context on the topic see other discussions. For reference, discussion on this topic: - [D4863](https://archive.blender.org/developer/D4863) - Preferences UI patch for Save/Revert/Reset - [D5236](https://archive.blender.org/developer/D5236) - Remove option for disabling the override when factory settings are loaded - #66675 - Tooltip urgently needed for Preferences editor button to avoid user data loss with factory-defaults. - 4a5e046c92 UI: remove button to enable auto-save after load factory preferences ---- Based on discussion with @JulienKaspar, @dr.sybren & @WilliamReynish - we agree the current logic isn't well communicated to the user, since loading factory settings puts Blender in a state where auto-save is checked but ignored. This could be mitigated using a dialog which lets the user know what happens when loading factory settings. Suggested text: > Loading factory preferences won't automatically save your preferences on exit. > To overwrite your current preferences you must manually save the preferences.

Campbell Barton commented

2019-08-14 15:37:13 +02:00

Added subscribers: @JulienKaspar, @WilliamReynish, @dr.sybren, @ideasman42

Yevgeny Makarov commented

2019-08-15 01:03:57 +02:00

Added subscriber: @jenkm

Yevgeny Makarov commented

2019-08-15 01:03:57 +02:00

Remove "skip_save_on_exit", this is very confusing when the Auto Save option is enabled, but the preferences are not saved automatically. Once the factory settings have been loaded, just explicitly turn off the Auto Save option.
When loading factory settings, display the "Auto-Save" or "Disable Auto-Save (don't save preferences on exit)" checkbox in the confirmation dialog, so the user can directly see what is happening and what settings he has.

 {F7665062, width=530}

Display the "Auto-Save" checkbox in the Preferences so that the user can clearly see that autosave is enabled.

 {F7665063, width=430}
 {F7665064, width=430}

1. Remove "skip_save_on_exit", this is very confusing when the Auto Save option is enabled, but the preferences are not saved automatically. Once the factory settings have been loaded, just explicitly turn off the Auto Save option. 2. When loading factory settings, display the "Auto-Save" or "Disable Auto-Save (don't save preferences on exit)" checkbox in the confirmation dialog, so the user can directly see what is happening and what settings he has. ``` {F7665062, width=530} ``` 3. Display the "Auto-Save" checkbox in the Preferences so that the user can clearly see that autosave is enabled. ``` {F7665063, width=430} {F7665064, width=430}

Julien Kaspar commented

2019-08-15 01:27:35 +02:00

@jenkm @ideasman42 I think this one could help as well. Since any save option is just kinda missing when auto-save is enabled. It's all hidden in the popup otherwise.

In #68649#753295, @jenkm wrote:
3. Display the "Auto-Save" checkbox in the Preferences so that the user can clearly see that autosave is enabled.

Other than that I think the dialogue is great.

@jenkm @ideasman42 I think this one could help as well. Since any save option is just kinda missing when auto-save is enabled. It's all hidden in the popup otherwise. > In #68649#753295, @jenkm wrote: > 3. Display the "Auto-Save" checkbox in the Preferences so that the user can clearly see that autosave is enabled. > > ![load-factory-auto.png](https://archive.blender.org/developer/F7665063/load-factory-auto.png) > ![load-factory-save.png](https://archive.blender.org/developer/F7665064/load-factory-save.png) Other than that I think the dialogue is great.

Sybren A. Stüvel commented

2019-08-15 10:14:04 +02:00

@jenkm Your proposal looks nice, but it's not complete. What would be shown when Auto-Save is turned off by the user? Do you show the checkbox and the save button at the same time? What if the user wants to reset to factory settings, then turn off auto-save, then save the new preferences, what would that look like?

Yevgeny Makarov commented

2019-08-15 10:42:20 +02:00

It's the same as it is now, but shows the checkbox instead of the empty space.

By default, Auto Save is enabled:

Auto Save is turned off by the user:

It's the same as it is now, but shows the checkbox instead of the empty space. By default, Auto Save is enabled: ![load-factory-auto.png](https://archive.blender.org/developer/F7665063/load-factory-auto.png) Auto Save is turned off by the user: ![load-factory-save.png](https://archive.blender.org/developer/F7665064/load-factory-save.png)

Yevgeny Makarov commented

2019-08-15 10:47:07 +02:00

change

        if prefs.use_preferences_save and (not bpy.app.use_userpref_skip_save_on_exit):
            pass
        else:

to

        if prefs.use_preferences_save:
            row.prop(prefs, "use_preferences_save", text="Auto-Save Preferences")
        else:

line 45, space_userpref.py

change ``` if prefs.use_preferences_save and (not bpy.app.use_userpref_skip_save_on_exit): pass else: ``` to ``` if prefs.use_preferences_save: row.prop(prefs, "use_preferences_save", text="Auto-Save Preferences") else: ``` line 45, space_userpref.py

Yevgeny Makarov commented

2019-08-15 11:16:05 +02:00

And you need to rename the "Auto Save Temporary Files", "Recover > Auto Save…" to "Auto Backup", so as not to confuse.

Oh, and another thing, "Load Factory Settings" vs "Load Factory Preferences".
The difference is only visible when you see them next to each other.

When you see "Load Factory Settings" in the menu, you don't remember that in the Preferences,
the option is called "Load Factory Preferences" and you think it's the same function.

And you need to rename the *"Auto Save Temporary Files"*, *"Recover > Auto Save…"* to **"Auto Backup"**, so as not to confuse. *** Oh, and another thing, "Load Factory Settings" vs "Load Factory Preferences". The difference is only visible when you see them next to each other. When you see "Load Factory Settings" in the menu, you don't remember that in the Preferences, the option is called "Load Factory Preferences" and you think it's the same function.

Sybren A. Stüvel commented

2019-08-15 11:48:18 +02:00

In #68649#753567, @jenkm wrote:
Auto Save is turned off by the user:

This means they won't be able to turn it on again.

> In #68649#753567, @jenkm wrote: > Auto Save is turned off by the user: > > ![load-factory-save.png](https://archive.blender.org/developer/F7665064/load-factory-save.png) This means they won't be able to turn it on again.

Yevgeny Makarov commented

2019-08-15 14:18:59 +02:00

This means they won't be able to turn it on again.

Yes, just like it is now.

Alternatively, it could just be a "Auto Save enabled" label, not a checkbox.
This is only to allow the user to clearly see that the Auto Save feature is enabled.

> This means they won't be able to turn it on again. Yes, just like it is now. Alternatively, it could just be a "Auto Save enabled" label, not a checkbox. This is only to allow the user to clearly see that the Auto Save feature is enabled.

Sybren A. Stüvel commented

2019-08-16 10:49:49 +02:00

In #68649#753698, @jenkm wrote:

This means they won't be able to turn it on again.

Yes, just like it is now.

No, that's not how it is now. It's a checkbox that's always available:

> In #68649#753698, @jenkm wrote: >> This means they won't be able to turn it on again. > > Yes, just like it is now. No, that's not how it is now. It's a checkbox that's always available: ![image.png](https://archive.blender.org/developer/F7667053/image.png)

Yevgeny Makarov commented

2019-08-16 11:17:20 +02:00

@dr.sybren It's all here, if you mean the menu, I'm not suggesting remove anything, just add a checkbox (or label), see my comment above #68649#753568.

Sybren A. Stüvel commented

2019-08-16 15:53:38 +02:00

I think having a checkbox that disappears when you un-check it is a bad idea. We've had that before, and it was horribly confusing.

Yevgeny Makarov commented

2019-08-17 11:53:21 +02:00

Diff: P1070

Mockup of the dialog box:

**Diff:** [P1070](https://archive.blender.org/developer/P1070.txt) ![auto-save-on-1.png](https://archive.blender.org/developer/F7668749/auto-save-on-1.png) ![auto-save-on-2.png](https://archive.blender.org/developer/F7668750/auto-save-on-2.png) ![auto-save-on-3.png](https://archive.blender.org/developer/F7668751/auto-save-on-3.png) ![auto-save-on-4.png](https://archive.blender.org/developer/F7668752/auto-save-on-4.png) *** Mockup of the dialog box: ![auto-save-load-factory-dialog.png](https://archive.blender.org/developer/F7668855/auto-save-load-factory-dialog.png)

William Reynish commented

2019-08-19 10:26:31 +02:00

I'd rather we not use exclamation marks like that - and since most apps always auto-save preferences, there's no need to draw that much attention to the fact that Blender works the same.

Julien Kaspar commented

2019-08-19 10:42:32 +02:00

I do like the idea to expose the "Autosave = On" as a checkmark when it's enabled.

and since most apps always auto-save preferences, there's no need to draw that much attention to the fact that Blender works the same.

I agree but but Blender didn't work like that so far. It's a new concept for Blender users so it makes sense to highlight it a bit more. Not necessarily shout it out in the interface but at least showing it prominently when it's enabled instead of always hiding it.

In #68649#753567, @jenkm wrote:
It's the same as it is now, but shows the checkbox instead of the empty space.

By default, Auto Save is enabled:

Auto Save is turned off by the user:

I do like the idea to expose the "Autosave = On" as a checkmark when it's enabled. > and since most apps always auto-save preferences, there's no need to draw that much attention to the fact that Blender works the same. I agree but but Blender didn't work like that so far. It's a new concept for Blender users so it makes sense to highlight it a bit more. Not necessarily shout it out in the interface but at least showing it prominently when it's enabled instead of always hiding it. > In #68649#753567, @jenkm wrote: > It's the same as it is now, but shows the checkbox instead of the empty space. > > By default, Auto Save is enabled: > > ![load-factory-auto.png](https://archive.blender.org/developer/F7665063/load-factory-auto.png) > > Auto Save is turned off by the user: > > ![load-factory-save.png](https://archive.blender.org/developer/F7665064/load-factory-save.png)

Yevgeny Makarov commented

2019-08-19 11:01:27 +02:00

most apps always auto-save preferences, there's no need to draw that much attention

These applications are not able to disable autosave, so the user always knows that autosave will take place.

In Blender autosave is an option and as it is important it should be visible.

Or this option (to disable autosave) should not exist as in other applications. In order not to confuse users.

> most apps always auto-save preferences, there's no need to draw that much attention These applications are not able to disable autosave, so the user always knows that autosave will take place. In Blender autosave is an option and as it is important it should be visible. Or this option (to disable autosave) should not exist as in other applications. In order not to confuse users.

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Improve communication of auto-save behavior by adding dialog box to "Load Factory Preferences/Settings" #68649