Import Images as Planes #69148

New Issue

Himanshi Kalra · 2019-08-25T15:58:54+02:00

Himanshi Kalra commented

2019-08-25 15:58:54 +02:00

HI I am a beginner I saw this task and I have made this addon-patch for the task https://developer.blender.org/T66299
newImg2plane.py

HI I am a beginner I saw this task and I have made this addon-patch for the task https://developer.blender.org/T66299 [newImg2plane.py](https://archive.blender.org/developer/F7703102/newImg2plane.py)

Philipp Oeser was assigned by Himanshi Kalra

2019-08-25 15:58:54 +02:00

Himanshi Kalra commented

2019-08-25 15:58:54 +02:00

Added subscriber: @Calra

Brendon Murphy commented

2019-08-26 07:58:25 +02:00

Added subscriber: @BrendonMurphy

Brendon Murphy commented

2019-08-26 07:58:25 +02:00

hi, what are the benefits of your changes and what do they do?

Philipp Oeser commented

2019-08-26 10:51:48 +02:00

@BrendonMurphy : Think this is about replacing the node setup with a principled shader [so it is better suited for exporting (OBJ, FBX, GLTF -- which rely on the Principled Shader to export textures along...)]
This might not be possible for the "shadeless" setup -- would at least need some further checking, but the for the others, using a principled shader should work out, I guess...

Hi @Calra !
Thx for your contribution!
Would you mind submitting this as a real patch (this would make it much easier for us in the review process)?
Have a look here https:*wiki.blender.org/wiki/Process/Contributing_Code and here https:*wiki.blender.org/wiki/Tools/Patches
You can just create a differential and attach it to #66299 (Addon "Import images as planes". change node system for better exprting to glTF), lets use this task for this since this is open already.

@BrendonMurphy : Think this is about replacing the node setup with a principled shader [so it is better suited for exporting (OBJ, FBX, GLTF -- which rely on the Principled Shader to export textures along...)] This might not be possible for the "shadeless" setup -- would at least need some further checking, but the for the others, using a principled shader should work out, I guess... Hi @Calra ! Thx for your contribution! Would you mind submitting this as a real patch (this would make it much easier for us in the review process)? Have a look here https:*wiki.blender.org/wiki/Process/Contributing_Code and here https:*wiki.blender.org/wiki/Tools/Patches You can just create a differential and attach it to #66299 (Addon "Import images as planes". change node system for better exprting to glTF), lets use this task for this since this is open already.

Himanshi Kalra commented

2019-08-26 11:23:14 +02:00

Hi thanks for replying I just read the Never do section, I didn't take permission from the authors' of this addon before editing. Should I do that before submitting the patch ?

Hi thanks for replying I just read the **Never do** section, I didn't take permission from the authors' of this addon before editing. Should I do that before submitting the patch ?

Bastien Montagne commented

2019-08-26 16:37:01 +02:00

Added subscriber: @mont29

Bastien Montagne commented

2019-08-26 16:37:01 +02:00

Changed status from 'Open' to: 'Archived'

Bastien Montagne closed this issue

2019-08-26 16:37:01 +02:00

Bastien Montagne commented

2019-08-26 16:37:01 +02:00

For sake of clarity, @Calra contacted me on blender.chat this morning, and gave the answer that anybody is free to modify that add-ons code within the licenses's conditions, as with any other piece of GPL software. What we forbid is committing changes to someone else's add-on without getting them reviewed first. Submitting patches is the way to go, and most welcomed.

@Calra will archive that task, we indeed need a proper differential one for review, as described by @lichtwerk above. Thanks.

For sake of clarity, @Calra contacted me on blender.chat this morning, and gave the answer that anybody is free to modify that add-ons code within the licenses's conditions, as with any other piece of GPL software. What we forbid is committing changes to someone else's add-on without getting them reviewed first. Submitting patches is the way to go, and most welcomed. @Calra will archive that task, we indeed need a proper differential one for review, as described by @lichtwerk above. Thanks.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Import Images as Planes #69148