Resetting default value does not work in popovers or menus #69200

Open
opened 2019-08-27 08:53:11 +02:00 by Chingiz Jumagulov · 13 comments

System Information
Operating system: Windows 10, 64 bits,
Graphics card: Nvidia GTX 1080 8 gb, Nvidia GTX1070 8 gb

Blender Version
Broken:
blender-2.81.0-git.ce2368cf69f5-windows64

Worked: (optional)

Short description of error
Resetting options in the context menu (right click) of things like brush stroke strength, Autosmooth, plane offset and other parameters does not work at all, but does work through active Tool side panes and top bar. Probably it should work everywhere? If I'm working full screen I would want to be able to reset it in the context menu with my stylus as I sculpt.

image.png

Exact steps for others to reproduce the error
1 Create any mesh
2 Enable Sculpt mode
3 Select any brush
4 Right click to invoke context menu
5 Try resetting any of the parameter to default values

**System Information** Operating system: Windows 10, 64 bits, Graphics card: Nvidia GTX 1080 8 gb, Nvidia GTX1070 8 gb **Blender Version** Broken: blender-2.81.0-git.ce2368cf69f5-windows64 Worked: (optional) **Short description of error** Resetting options in the context menu (right click) of things like brush stroke strength, Autosmooth, plane offset and other parameters does not work at all, but does work through active Tool side panes and top bar. Probably it should work everywhere? If I'm working full screen I would want to be able to reset it in the context menu with my stylus as I sculpt. ![image.png](https://archive.blender.org/developer/F7705744/image.png) **Exact steps for others to reproduce the error** 1 Create any mesh 2 Enable Sculpt mode 3 Select any brush 4 Right click to invoke context menu 5 Try resetting any of the parameter to default values

Added subscriber: @MeshVoid

Added subscriber: @MeshVoid

#67201 was marked as duplicate of this issue

#67201 was marked as duplicate of this issue

Added subscriber: @AbidMaqbool

Added subscriber: @AbidMaqbool

right! & in other places (properties/top-bar/numeric-pane) Reset to Default Value sets to 0 rather then default
However, In my case most options are disabled
image.png

right! & in other places (properties/top-bar/numeric-pane) `Reset to Default Value` sets to **0** rather then **default** However, In my case most options are **disabled** ![image.png](https://archive.blender.org/developer/F7705780/image.png)
Member

Added subscribers: @JulianEisel, @ideasman42, @lichtwerk

Added subscribers: @JulianEisel, @ideasman42, @lichtwerk
Member

Can confirm this is not working from the context menu.
This is similar to #58341 (in that ui_context_rna_button_active within poll functions invoked for the popover UI elements can't find the actual UI control in the popover)

Regarding default values being not defined well [resetting to zero instead of the "default" value we actually see first]:
I think we had a task somewhere going into detail about our defaults being spread across RNA-defaults, (Tool-)specific init functions (possibly others...DNA?)
Before going in and adding RNA defaults here, I'd like feedback from @JulianEisel, @ideasman42 what the recommended way to go here is?

Can confirm this is not working from the context menu. This is similar to #58341 (in that `ui_context_rna_button_active` within poll functions invoked for the popover UI elements can't find the actual UI control in the popover) Regarding default values being not defined well [resetting to zero instead of the "default" value we actually see first]: I think we had a task somewhere going into detail about our defaults being spread across RNA-defaults, (Tool-)specific `init` functions (possibly others...DNA?) Before going in and adding RNA defaults here, I'd like feedback from @JulianEisel, @ideasman42 what the recommended way to go here is?
Member

Reset to Default Value is utterly broken, see #47618. But it seems unrelated to the issue reported here, as it seems to work from regular panel regions.

*Reset to Default Value* is utterly broken, see #47618. But it seems unrelated to the issue reported here, as it seems to work from regular panel regions.
Member

In #69200#763553, @JulianEisel wrote:
Reset to Default Value is utterly broken, see #47618.

thx, that was the task I meant.

But it seems unrelated to the issue reported here, as it seems to work from regular panel regions.

Still we have stuff that just has no defaults defined, try resetting any brush radius [will default to 0px ... not 50px]
Question was: do we want to go in and define RNA defines based on what the brush is initialzed with?

> In #69200#763553, @JulianEisel wrote: > *Reset to Default Value* is utterly broken, see #47618. thx, that was the task I meant. > But it seems unrelated to the issue reported here, as it seems to work from regular panel regions. Still we have stuff that just has no defaults defined, try resetting any brush `radius` [will default to `0px` ... not `50px`] Question was: do we want to go in and define RNA defines based on what the brush is initialzed with?
Member

There are hundreds of RNA properties without defaults so I'd say it's not worth bothering (even though it's an easy change for each individual one). Then there is D4500 which would completely change the way we handle defaults and IMHO that's the way to go. So no, I wouldn't suggest doing it.

There are hundreds of RNA properties without defaults so I'd say it's not worth bothering (even though it's an easy change for each individual one). Then there is [D4500](https://archive.blender.org/developer/D4500) which would completely change the way we handle defaults and IMHO that's the way to go. So no, I wouldn't suggest doing it.
Member

OKi, lets settle the discussion about "bad" defaults (since this seems to be a well known issue with potential solutions even).

Keeping this open for the issue about ui_context_rna_button_active though...

OKi, lets settle the discussion about "bad" defaults (since this seems to be a well known issue with potential solutions even). Keeping this open for the issue about `ui_context_rna_button_active` though...
Campbell Barton changed title from Resetting default value does not work in context menu in sculpt mode to Resetting default value does not work in popovers or menus 2020-02-20 06:47:01 +01:00

Added subscriber: @Blendify

Added subscriber: @Blendify

Added subscriber: @ce3po

Added subscriber: @ce3po
Member

This is unrelated to the specifics of painting

This is unrelated to the specifics of painting
Philipp Oeser removed the
Interest
User Interface
label 2023-02-10 09:25:21 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
8 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#69200
No description provided.