Shadow catcher receive shadows even if there is no light in the scene #69410

Closed
opened 2019-09-02 15:04:09 +02:00 by Christoph Werner · 10 comments

System Information
Operating system: Windows
Graphics card: GeForce GTX 1080 Ti

system-info.txt

Blender Version
Broken: version: 2.80 (sub 75), branch: master, commit date: 2019-07-29 14:47, hash: f6cb5f5449, type: build date: 2019-07-29, 09:44 AM
Worked: -

Short description of error
See my attached .blend file for an example and the screenshot for additional infos.

If you set the light object power to "0", then the shadow catcher object receives shadows. But there is no light in the scene.
I've set the world light to "0" too. This should not happen.

Exact steps for others to reproduce the error

  • Open my blend file.
  • Set one of the top views to "Rendered". Use the Cycles renderer.
  • Set the light power to "0" now.
  • The shadow catcher on the ground receives shadows then, but there is no light in the scene anymore. This isn't what I expect. Actually there shouldn't be any shadows around the box.

Do I misunderstand something when using the shadows catcher or is this an error?

shadow_catcher_problem01.jpg

shadowcatcher_problem01.blend

**System Information** Operating system: Windows Graphics card: GeForce GTX 1080 Ti [system-info.txt](https://archive.blender.org/developer/F7714186/system-info.txt) **Blender Version** Broken: version: 2.80 (sub 75), branch: master, commit date: 2019-07-29 14:47, hash: f6cb5f54494e, type: build date: 2019-07-29, 09:44 AM Worked: - **Short description of error** See my attached .blend file for an example and the screenshot for additional infos. If you set the light object power to "0", then the shadow catcher object receives shadows. But there is no light in the scene. I've set the world light to "0" too. This should not happen. **Exact steps for others to reproduce the error** - Open my blend file. - Set one of the top views to "Rendered". Use the Cycles renderer. - Set the light power to "0" now. - The shadow catcher on the ground receives shadows then, but there is no light in the scene anymore. This isn't what I expect. Actually there shouldn't be any shadows around the box. Do I misunderstand something when using the shadows catcher or is this an error? ![shadow_catcher_problem01.jpg](https://archive.blender.org/developer/F7714260/shadow_catcher_problem01.jpg) [shadowcatcher_problem01.blend](https://archive.blender.org/developer/F7714188/shadowcatcher_problem01.blend)

Added subscriber: @ChristophWerner

Added subscriber: @ChristophWerner

Added subscriber: @MarcinTwarowski

Added subscriber: @MarcinTwarowski

This comment was removed by @MarcinTwarowski

*This comment was removed by @MarcinTwarowski*
Member

Added subscribers: @Sergey, @lichtwerk

Added subscribers: @Sergey, @lichtwerk
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

Although a bit on shaky ground here, but I would kind of confirm this issue.

Relevant commits:
d14e39622a
bd069a89aa

For absolutely no light (path_total == 0.0f), bd069a89aa changed behavior from returning 1.0f to returning L->shadow_transparency (see what is now path_radiance_sum_shadowcatcher).
Since above commit was only intended to fix problems with transparent shadow casters, but also changed the behavior for opaque shadow casters in the case of no light, I would assume this can somehow be fixed and was not intended, @Sergey?
(to me it would make more snese to actually have no shadow in the case of no light -- so agree with the report, but will leave up to @Sergey to decide.... confirming for now though...)

Sidenote: there are all sorts of (other) improvements to make, so if this turns out to be a known limitation for now, maybe this can be considered elswhere:
https://devtalk.blender.org/t/lets-finally-fix-the-shadowcatcher/691
#71253 (Cycles shadow catcher improvements)

Although a bit on shaky ground here, but I would kind of confirm this issue. Relevant commits: d14e39622a bd069a89aa For absolutely no light (`path_total == 0.0f`), bd069a89aa changed behavior from returning 1.0f to returning `L->shadow_transparency` (see what is now `path_radiance_sum_shadowcatcher`). Since above commit was only intended to fix problems with transparent shadow casters, but also changed the behavior for opaque shadow casters in the case of no light, I would assume this can somehow be fixed and was not intended, @Sergey? (to me it would make more snese to actually have no shadow in the case of no light -- so agree with the report, but will leave up to @Sergey to decide.... confirming for now though...) Sidenote: there are all sorts of (other) improvements to make, so if this turns out to be a known limitation for now, maybe this can be considered elswhere: https://devtalk.blender.org/t/lets-finally-fix-the-shadowcatcher/691 #71253 (Cycles shadow catcher improvements)

Exactly. I repeat it for better understanding:

If there is no world light set (environment light strength is set to 0 )
and there is no light object set or all light objects are set to power of 0 then no shadows should be seen on any shadow catchers.

For me this is often a problem, when I work with render passes.

Thank you for the attention
Chris

Exactly. I repeat it for better understanding: If there is no world light set (environment light strength is set to 0 ) and there is no light object set or all light objects are set to power of 0 then no shadows should be seen on any shadow catchers. For me this is often a problem, when I work with render passes. Thank you for the attention Chris

Added subscriber: @brecht

Added subscriber: @brecht

Changed status from 'Confirmed' to: 'Archived'

Changed status from 'Confirmed' to: 'Archived'

The rewritten shadow catcher in Blender 3.0 does not have this problem anymore.

The rewritten shadow catcher in Blender 3.0 does not have this problem anymore.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#69410
No description provided.