GPencil: Convert Curve to Grease Pencil clears Transform. #69459

New Issue

Johnny Matthews · 2019-09-03T22:47:31+02:00

Johnny Matthews commented

2019-09-03 22:47:31 +02:00

System Information
Operating system: Windows-10-10.0.17134 64 Bits
Graphics card: AMD Radeon HD 5450 ATI Technologies Inc. 4.5.13399 Core Profile Context 15.201.1151.1008

Blender Version
Broken: version: 2.81 (sub 5), branch: master, commit date: 2019-09-03 12:35, hash: 51d8facbc3
Worked: (optional)

Short description of error
Convert Curve to Grease Pencil clears Transform.

Exact steps for others to reproduce the error

Steps

Add Text Object (Text in example)
Move, Rotate and Scale Text Object, also changed text for clarity (solid "Moved, Rotated and Scaled" in image)
Convert to Curve from Mesh/Text
Convert Grease Pencil From Curve =>new GP object has cleared Transform (outlined text in image)

GP.blend

**System Information** Operating system: Windows-10-10.0.17134 64 Bits Graphics card: AMD Radeon HD 5450 ATI Technologies Inc. 4.5.13399 Core Profile Context 15.201.1151.1008 **Blender Version** Broken: version: 2.81 (sub 5), branch: master, commit date: 2019-09-03 12:35, hash: `51d8facbc3` Worked: (optional) **Short description of error** Convert Curve to Grease Pencil clears Transform. **Exact steps for others to reproduce the error** Steps - Add Text Object (Text in example) - Move, Rotate and Scale Text Object, also changed text for clarity (solid "Moved, Rotated and Scaled" in image) - Convert to Curve from Mesh/Text - Convert Grease Pencil From Curve =>new GP object has cleared Transform (outlined text in image) ![screen.png](https://archive.blender.org/developer/F7715641/screen.png) [GP.blend](https://archive.blender.org/developer/F7715646/GP.blend)

Johnny Matthews commented

2019-09-03 22:47:31 +02:00

Added subscriber: @guitargeek

Germano Cavalcante commented

2019-10-10 20:30:37 +02:00

Added subscribers: @antoniov, @mano-wii

Antonio Vazquez was assigned by Germano Cavalcante

2019-10-10 20:30:37 +02:00

Germano Cavalcante commented

2019-10-10 20:30:37 +02:00

@antoniov, is this a known limitation?
Any reason for just the cursor location being used?

@antoniov, is this a known limitation? Any reason for just the cursor location being used?

Antonio Vazquez commented

2019-10-10 22:00:47 +02:00

I think the new GPencil object is not using the original transformation, so we need take a look.

Antonio Vazquez changed title from ~~Convert Curve to Grease Pencil clears Transform.~~ to GPencil: Convert Curve to Grease Pencil clears Transform.

2019-10-10 22:08:57 +02:00

Antonio Vazquez commented

2019-10-10 22:17:58 +02:00

@mano-wii I have a fix, but not sure if this can be done with less lines:

diff --git a/source/blender/editors/object/object_add.c b/source/blender/editors/object/object_add.c
index bbd8c425386..4676a286169 100644
--- a/source/blender/editors/object/object_add.c
+++ b/source/blender/editors/object/object_add.c
@@ -2397,6 +2397,9 @@ static int convert_exec(bContext *C, wmOperator *op)
             const float *cur = scene->cursor.location;
             ushort local_view_bits = (v3d && v3d->localvd) ? v3d->local_view_uuid : 0;
             gpencil_ob = ED_gpencil_add_object(C, scene, cur, local_view_bits);
+            copy_v3_v3(gpencil_ob->loc, ob->loc);
+            copy_v3_v3(gpencil_ob->rot, ob->rot);
+            copy_v3_v3(gpencil_ob->scale, ob->scale);
           }
           BKE_gpencil_convert_curve(bmain, scene, gpencil_ob, ob, false, false, true);
         }

I tested with copy_m4_m4(gpencil_ob->obmat, ob->obmat); but it does not work.

@mano-wii I have a fix, but not sure if this can be done with less lines: ``` diff --git a/source/blender/editors/object/object_add.c b/source/blender/editors/object/object_add.c index bbd8c425386..4676a286169 100644 --- a/source/blender/editors/object/object_add.c +++ b/source/blender/editors/object/object_add.c @@ -2397,6 +2397,9 @@ static int convert_exec(bContext *C, wmOperator *op) const float *cur = scene->cursor.location; ushort local_view_bits = (v3d && v3d->localvd) ? v3d->local_view_uuid : 0; gpencil_ob = ED_gpencil_add_object(C, scene, cur, local_view_bits); + copy_v3_v3(gpencil_ob->loc, ob->loc); + copy_v3_v3(gpencil_ob->rot, ob->rot); + copy_v3_v3(gpencil_ob->scale, ob->scale); } BKE_gpencil_convert_curve(bmain, scene, gpencil_ob, ob, false, false, true); } ``` I tested with `copy_m4_m4(gpencil_ob->obmat, ob->obmat);` but it does not work.

Antonio Vazquez commented

2019-10-10 22:22:41 +02:00

Proposed Fix: D6045

Proposed Fix: [D6045](https://archive.blender.org/developer/D6045)

Antonio Vazquez commented

2019-10-11 13:25:38 +02:00

Changed status from 'Open' to: 'Resolved'

Antonio Vazquez closed this issue

2019-10-11 13:25:38 +02:00

Antonio Vazquez commented

2019-10-11 13:25:38 +02:00

Fixed in two commits: