GPencil: New Eyedropper tools (Main Task) #69704

New Issue

Antonio Vazquez · 2019-09-10T10:25:27+02:00

Antonio Vazquez commented

2019-09-10 10:25:27 +02:00

New tool to select a color and create a material and also to set as active a material using the sample color.

We have these main targets:

Create new materials sampling any color in viewport.
Select Materials using sample color (material).

Also, we need a way to disable any effect or modifier that changes the "real" color or use a solution that uses the internal real color. According to Brecht, thi could be done using the selection code and an unique material ID.

New tool to select a color and create a material and also to set as active a material using the sample color. We have these main targets: - Create new materials sampling any color in viewport. - Select Materials using sample color (material). Also, we need a way to disable any effect or modifier that changes the "real" color or use a solution that uses the internal real color. According to Brecht, thi could be done using the selection code and an unique material ID.

Antonio Vazquez self-assigned this 2019-09-10 10:25:27 +02:00

Antonio Vazquez commented

2019-09-10 10:25:27 +02:00

Added subscribers: @antoniov, @mendio, @pepe-school-land

Antonio Vazquez changed title from ~~GPencil: New Eyedropper toll~~ to GPencil: New Eyedropper tool

2019-09-10 10:25:35 +02:00

Antonio Vazquez commented

2019-09-10 10:25:51 +02:00

Related patch D5688

Related patch [D5688](https://archive.blender.org/developer/D5688)

Antonio Vazquez commented

2019-09-10 10:26:39 +02:00

Added subscriber: @brecht

Antonio Vazquez commented

2019-09-10 10:26:39 +02:00

@brecht as I think this need more work, could you tag the task for 2.82? I don't know what are the tags for that.

Antonio Vazquez commented

2019-09-10 11:23:20 +02:00

Not sure, but maybe is better to split this in two tools:

Eyedropper to create materials using any color in the viewport.
New select tool to Select material and set as active.

About point 2), this is useful for GPencil, but could it be useful for other areas of Blender? If we think is useful as a general tool, then this would require a separated task/design to define things like, for example, what happened if you select a material that is not in your object.

Not sure, but maybe is better to split this in two tools: 1) Eyedropper to create materials using any color in the viewport. 2) New select tool to Select material and set as active. About point 2), this is useful for GPencil, but could it be useful for other areas of Blender? If we think is useful as a general tool, then this would require a separated task/design to define things like, for example, what happened if you select a material that is not in your object.

Antonio Vazquez commented

2019-09-10 11:30:10 +02:00

Added subscriber: @WilliamReynish

Antonio Vazquez commented

2019-09-10 11:30:10 +02:00

@WilliamReynish Maybe you have some opinions about these tools.

Brecht Van Lommel commented

2019-09-10 11:47:18 +02:00

At least in terms of implementation it's quite different to select an existing material, or picking whatever color is under the cursor after shader effects, and then creating a new material from that. I don't have a strong opinion on what the best UI for that is though, multiple tools or one tool with some modifier keys.

Antonio Vazquez commented

2019-09-10 11:57:22 +02:00

Yes, this is why I think two tools could be better. My concern is trying to do all in the same tool and after some time we have a spaghetti code trying to solve problems that using two separated operators would not exist. Also, this design makes easy to grow in the future with new features without conflicts.

Matias Mendiola commented

2019-09-10 15:08:55 +02:00

Sure, we can split the eyedropper tool and use a subtool. One to create a new material (based on pixel color) and the other to select an existing stroke material.

Sure, we can split the eyedropper tool and use a subtool. One to create a new material (based on pixel color) and the other to select an existing stroke material. ![eyedropper.PNG](https://archive.blender.org/developer/F7730989/eyedropper.PNG)

Antonio Vazquez changed title from ~~GPencil: New Eyedropper tool~~ to GPencil: New Eyedropper tool (Main Task)

2019-09-10 16:58:52 +02:00

Antonio Vazquez changed title from ~~GPencil: New Eyedropper tool (Main Task)~~ to GPencil: New Eyedropper tools (Main Task)

2019-09-10 16:59:45 +02:00

Antonio Vazquez commented

2020-08-18 16:34:58 +02:00

Changed status from 'Confirmed' to: 'Archived'

Antonio Vazquez closed this issue

2020-08-18 16:34:58 +02:00

Antonio Vazquez commented

2020-08-18 16:34:58 +02:00

We can close this now because other tools replace the functionality. We can create a new task in the future if we need again.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

GPencil: New Eyedropper tools (Main Task) #69704