Texture paint bug 2.81- Eyedropper always samples merged down in 3D view #69752

New Issue

Vas · 2019-09-11T16:08:53+02:00

Vas commented

2019-09-11 16:08:53 +02:00

System Information
Operating system: Windows-10-10.0.14393 64 Bits
Graphics card: GeForce GTX 1050 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 425.46

Blender Version
Broken: version: 2.81 (sub 10), branch: master, commit date: 2019-09-10 22:12, hash: 4ce3fbd52a
Worked: 2.80

Short description of error
Apparently in alpha versions of 2.81, color picking a color while texture painting will always sample the merged color in 3D view, even if "sample merged" is turned off

texture paint problem.mp4

**System Information** Operating system: Windows-10-10.0.14393 64 Bits Graphics card: GeForce GTX 1050 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 425.46 **Blender Version** Broken: version: 2.81 (sub 10), branch: master, commit date: 2019-09-10 22:12, hash: `4ce3fbd52a` Worked: 2.80 **Short description of error** Apparently in alpha versions of 2.81, color picking a color while texture painting will always sample the merged color in 3D view, even if "sample merged" is turned off [texture paint problem.mp4](https://archive.blender.org/developer/F7735277/texture_paint_problem.mp4)

Vas commented

2019-09-11 16:08:53 +02:00

Added subscriber: @Alumx

Philipp Oeser commented

2019-09-12 12:00:32 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2019-09-12 12:00:32 +02:00

Can confirm.

Philipp Oeser commented

2019-09-12 12:09:25 +02:00

Added subscriber: @Jeroen-Bakker

Philipp Oeser commented

2019-09-12 12:09:25 +02:00

CC @Jeroen-Bakker : not sure if recent changes to viewport drawing would require a change in workflow here (would require to always use flat lighting?)?
Otherwise I would consider this a High priority thing... feel free to change back...

CC @Jeroen-Bakker : not sure if recent changes to viewport drawing would require a change in workflow here (would require to always use `flat` lighting?)? Otherwise I would consider this a High priority thing... feel free to change back...

Philipp Oeser commented

2019-09-12 13:05:14 +02:00

This is caused by af4dcc6073, checking further...

This is caused by af4dcc6073, checking further...

Philipp Oeser self-assigned this 2019-09-12 13:44:21 +02:00

Philipp Oeser commented

2019-09-12 13:44:21 +02:00

paint_sample_color > imapaint_pick_face uses the the selection buffer (DRW_select_buffer_sample_point)

Think there is a missing case in drawing the selection buffer regarding the select_mode, we are also asserting here
BLI_assert failed: /blender/source/blender/draw/engines/select/select_engine.c:174, select_cache_init(), at 'e_data.context.select_mode != 0'

Prior to above commit, when you didnt have Face Selection Masking turned ON it would still draw with stl->g_data->shgrp_face_flat, now with sh_data->select_id_uniform
there is already an exception in select_cache_init that turns on SCE_SELECT_FACE for weightpaint, we just need this for texture paint as well...

Fix incoming...

`paint_sample_color` > `imapaint_pick_face` uses the the selection buffer (`DRW_select_buffer_sample_point`) Think there is a missing case in drawing the selection buffer regarding the select_mode, we are also asserting here BLI_assert failed: /blender/source/blender/draw/engines/select/select_engine.c:174, select_cache_init(), at 'e_data.context.select_mode != 0' Prior to above commit, when you didnt have Face Selection Masking turned ON it would still draw with `stl->g_data->shgrp_face_flat`, now with `sh_data->select_id_uniform` there is already an exception in `select_cache_init` that turns on `SCE_SELECT_FACE` for weightpaint, we just need this for texture paint as well... Fix incoming...

blender-admin commented

2019-09-12 14:14:40 +02:00

This issue was referenced by 5b2cebf49b

This issue was referenced by 5b2cebf49bc6e17fd75ab43e33387fc1b257d710

Philipp Oeser commented

2019-09-12 18:24:17 +02:00

Changed status from 'Open' to: 'Resolved'

Philipp Oeser closed this issue

2019-09-12 18:24:17 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Texture paint bug 2.81- Eyedropper always samples merged down in 3D view #69752