Python-defined nodes implementing a draw_label function causes a segmentation fault when drawn. #69808

New Issue

Omar Emara · 2019-09-12T17:20:33+02:00

Omar Emara commented

2019-09-12 17:20:33 +02:00

System Information
Operating system: Arch Linux
Graphics card: Radeon RX 590

Blender Version
Broken: f80018b5f7
Worked: Builds from last week.

Short description of error

Python-defined nodes that implements the draw_label function causes a segmentation fault when drawn. This affects node-based addons such as Animation Nodes, see issue 1183 .

Exact steps for others to reproduce the error
Open a shader editor and add a material Material, then execute the following script:

import bpy

class Test(bpy.types.Node):
    bl_name = 'test' 
    bl_label = 'test'
    
    def draw_label(self):
        return "test"
    
bpy.utils.register_class(Test)

bpy.data.materials['Material'].node_tree.nodes.new('Test')

**System Information** Operating system: Arch Linux Graphics card: Radeon RX 590 **Blender Version** Broken: f80018b5f749 Worked: Builds from last week. **Short description of error** Python-defined nodes that implements the `draw_label` function causes a segmentation fault when drawn. This affects node-based addons such as Animation Nodes, see issue [1183 ](https://github.com/JacquesLucke/animation_nodes/issues/1183). **Exact steps for others to reproduce the error** Open a shader editor and add a material `Material`, then execute the following script: ``` import bpy class Test(bpy.types.Node): bl_name = 'test' bl_label = 'test' def draw_label(self): return "test" bpy.utils.register_class(Test) bpy.data.materials['Material'].node_tree.nodes.new('Test') ```

Omar Emara commented

2019-09-12 17:20:33 +02:00

Added subscriber: @OmarEmaraDev

blender-admin commented

2019-09-12 17:20:33 +02:00

#69980 was marked as duplicate of this issue

Jacques Lucke commented

2019-09-12 17:58:24 +02:00

Added subscriber: @JacquesLucke

Jacques Lucke commented

2019-09-12 17:58:24 +02:00

I can reproduce it.

BLI_strnlen(const char * s, const size_t maxlen) (/home/jacques/blender-git/blender/source/blender/blenlib/intern/string.c:780)
BLI_strncpy(char * restrict dst, const char * restrict src, const size_t maxncpy) (/home/jacques/blender-git/blender/source/blender/blenlib/intern/string.c:108)
rna_Node_draw_label(bNodeTree * ntree, bNode * node, char * label, int maxlen) (/home/jacques/blender-git/blender/source/blender/makesrna/intern/rna_nodetree.c:1486)
nodeLabel(bNodeTree * ntree, bNode * node, char * label, int maxlen) (/home/jacques/blender-git/blender/source/blender/blenkernel/intern/node.c:3484)
node_draw_basis(const bContext * C, ARegion * ar, SpaceNode * snode, bNodeTree * ntree, bNode * node, bNodeInstanceKey key) (/home/jacques/blender-git/blender/source/blender/editors/space_node/node_draw.c:1221)
node_draw_default(const bContext * C, ARegion * ar, SpaceNode * snode, bNodeTree * ntree, bNode * node, bNodeInstanceKey key) (/home/jacques/blender-git/blender/source/blender/editors/space_node/node_draw.c:1512)
node_draw(const bContext * C, ARegion * ar, SpaceNode * snode, bNodeTree * ntree, bNode * node, bNodeInstanceKey key) (/home/jacques/blender-git/blender/source/blender/editors/space_node/node_draw.c:1544)
node_draw_nodetree(const bContext * C, ARegion * ar, SpaceNode * snode, bNodeTree * ntree, bNodeInstanceKey parent_key) (/home/jacques/blender-git/blender/source/blender/editors/space_node/node_draw.c:1609)
draw_nodetree(const bContext * C, ARegion * ar, bNodeTree * ntree, bNodeInstanceKey parent_key) (/home/jacques/blender-git/blender/source/blender/editors/space_node/node_draw.c:1647)
drawnodespace(const bContext * C, ARegion * ar) (/home/jacques/blender-git/blender/source/blender/editors/space_node/node_draw.c:1777)
node_main_region_draw(const bContext * C, ARegion * ar) (/home/jacques/blender-git/blender/source/blender/editors/space_node/space_node.c:630)
ED_region_do_draw(bContext * C, ARegion * ar) (/home/jacques/blender-git/blender/source/blender/editors/screen/area.c:535)
wm_draw_window_offscreen(bContext * C, wmWindow * win, _Bool stereo) (/home/jacques/blender-git/blender/source/blender/windowmanager/intern/wm_draw.c:632)
wm_draw_window(bContext * C, wmWindow * win) (/home/jacques/blender-git/blender/source/blender/windowmanager/intern/wm_draw.c:768)
wm_draw_update(bContext * C) (/home/jacques/blender-git/blender/source/blender/windowmanager/intern/wm_draw.c:950)
WM_main(bContext * C) (/home/jacques/blender-git/blender/source/blender/windowmanager/intern/wm.c:423)
main(int argc, const char ** argv) (/home/jacques/blender-git/blender/source/creator/creator.c:491)

I can reproduce it. ``` BLI_strnlen(const char * s, const size_t maxlen) (/home/jacques/blender-git/blender/source/blender/blenlib/intern/string.c:780) BLI_strncpy(char * restrict dst, const char * restrict src, const size_t maxncpy) (/home/jacques/blender-git/blender/source/blender/blenlib/intern/string.c:108) rna_Node_draw_label(bNodeTree * ntree, bNode * node, char * label, int maxlen) (/home/jacques/blender-git/blender/source/blender/makesrna/intern/rna_nodetree.c:1486) nodeLabel(bNodeTree * ntree, bNode * node, char * label, int maxlen) (/home/jacques/blender-git/blender/source/blender/blenkernel/intern/node.c:3484) node_draw_basis(const bContext * C, ARegion * ar, SpaceNode * snode, bNodeTree * ntree, bNode * node, bNodeInstanceKey key) (/home/jacques/blender-git/blender/source/blender/editors/space_node/node_draw.c:1221) node_draw_default(const bContext * C, ARegion * ar, SpaceNode * snode, bNodeTree * ntree, bNode * node, bNodeInstanceKey key) (/home/jacques/blender-git/blender/source/blender/editors/space_node/node_draw.c:1512) node_draw(const bContext * C, ARegion * ar, SpaceNode * snode, bNodeTree * ntree, bNode * node, bNodeInstanceKey key) (/home/jacques/blender-git/blender/source/blender/editors/space_node/node_draw.c:1544) node_draw_nodetree(const bContext * C, ARegion * ar, SpaceNode * snode, bNodeTree * ntree, bNodeInstanceKey parent_key) (/home/jacques/blender-git/blender/source/blender/editors/space_node/node_draw.c:1609) draw_nodetree(const bContext * C, ARegion * ar, bNodeTree * ntree, bNodeInstanceKey parent_key) (/home/jacques/blender-git/blender/source/blender/editors/space_node/node_draw.c:1647) drawnodespace(const bContext * C, ARegion * ar) (/home/jacques/blender-git/blender/source/blender/editors/space_node/node_draw.c:1777) node_main_region_draw(const bContext * C, ARegion * ar) (/home/jacques/blender-git/blender/source/blender/editors/space_node/space_node.c:630) ED_region_do_draw(bContext * C, ARegion * ar) (/home/jacques/blender-git/blender/source/blender/editors/screen/area.c:535) wm_draw_window_offscreen(bContext * C, wmWindow * win, _Bool stereo) (/home/jacques/blender-git/blender/source/blender/windowmanager/intern/wm_draw.c:632) wm_draw_window(bContext * C, wmWindow * win) (/home/jacques/blender-git/blender/source/blender/windowmanager/intern/wm_draw.c:768) wm_draw_update(bContext * C) (/home/jacques/blender-git/blender/source/blender/windowmanager/intern/wm_draw.c:950) WM_main(bContext * C) (/home/jacques/blender-git/blender/source/blender/windowmanager/intern/wm.c:423) main(int argc, const char ** argv) (/home/jacques/blender-git/blender/source/creator/creator.c:491) ```

Pedro A. commented

2019-09-12 18:18:23 +02:00

Added subscriber: @povmaniac