Annotations and Grease Pencil panels cannot work at the same time #71497

Closed
opened 2019-11-11 18:46:38 +01:00 by Reiner Prokein · 15 comments

System Information
Operating system: Windows-10-10.0.18362 64 Bits
Graphics card: GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 436.15

Blender Version
Broken: version: 2.82 (sub 1), branch: master, commit date: 2019-11-07 20:36, hash: 23e1fb365b
Worked: (optional)

Short description of error
[Please fill out a short description of the error here]

The annotations panel in the View tab of the sidebar vanishes when you create a grease pencil object. This does not happen with other object types.

Painting a annotation stroke will reveal the panel again.

Exact steps for others to reproduce the error
[Please describe the exact steps needed to reproduce the issue]
[Based on the default startup or an attached .blend file (as simple as possible)]

In object mode draw a annotation stroke. Open the sidebar. Go to the view tab and open the Annotations panel.
Create a cube or another primitive. The annotations panel is still there.
Now create a grease pencil object. The annotations panel will vanish. It will come back when you draw more annotations.

annotation1.jpg

annotation2.jpg

annotation3.jpg

**System Information** Operating system: Windows-10-10.0.18362 64 Bits Graphics card: GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 436.15 **Blender Version** Broken: version: 2.82 (sub 1), branch: master, commit date: 2019-11-07 20:36, hash: `23e1fb365b` Worked: (optional) **Short description of error** [Please fill out a short description of the error here] The annotations panel in the View tab of the sidebar vanishes when you create a grease pencil object. This does not happen with other object types. Painting a annotation stroke will reveal the panel again. **Exact steps for others to reproduce the error** [Please describe the exact steps needed to reproduce the issue] [Based on the default startup or an attached .blend file (as simple as possible)] In object mode draw a annotation stroke. Open the sidebar. Go to the view tab and open the Annotations panel. Create a cube or another primitive. The annotations panel is still there. Now create a grease pencil object. The annotations panel will vanish. It will come back when you draw more annotations. ![annotation1.jpg](https://archive.blender.org/developer/F8035310/annotation1.jpg) ![annotation2.jpg](https://archive.blender.org/developer/F8035312/annotation2.jpg) ![annotation3.jpg](https://archive.blender.org/developer/F8035315/annotation3.jpg)
Author

Added subscriber: @tiles

Added subscriber: @tiles

#72762 was marked as duplicate of this issue

#72762 was marked as duplicate of this issue

Added subscriber: @dfelinto

Added subscriber: @dfelinto

That is funny, it should be an easy fix, I will look at it.

That is funny, it should be an easy fix, I will look at it.

Added subscriber: @antoniov

Added subscriber: @antoniov

Oh boy, leaving this to our brave greasepencil team.

Really, the whole ED_gpencil_data_get_pointers_direct() where we get a different data based on active object is not the way to go.
I believe we want to separate the gp object from the anotation data (as far as UI/context go) very radically.

We can still be smart about that and re-use the UI panels/code. But not the way we are doing it. Because fundamentally there is no real reason to prevent showing the annotations panel and edit its data only because an greasepencil object is active.

Oh boy, leaving this to our brave greasepencil team. Really, the whole `ED_gpencil_data_get_pointers_direct()` where we get a different data based on active object is not the way to go. I believe we want to separate the gp object from the anotation data (as far as UI/context go) very radically. We can still be smart about that and re-use the UI panels/code. But not the way we are doing it. Because fundamentally there is no real reason to prevent showing the annotations panel and edit its data only because an greasepencil object is active.

I agree with @dfelinto. The problem now is how the grease pencil datablock is handled. This requires to decouple totally all operators between annotation an grease pencil and use ob->datafor grease pencil an scene->gpdfor annotationes.

I will review the code and make a plan to do this change. It's not complex change but maybe need a lot of small changes.

I agree with @dfelinto. The problem now is how the grease pencil datablock is handled. This requires to decouple totally all operators between annotation an grease pencil and use `ob->data`for grease pencil an `scene->gpd`for annotationes. I will review the code and make a plan to do this change. It's not complex change but maybe need a lot of small changes.
Antonio Vazquez self-assigned this 2019-11-12 08:42:25 +01:00

Added subscriber: @Vyach

Added subscriber: @Vyach

Just encountered the same bug.

Just encountered the same bug.

Just encountered the same bug. 2.80, 2.81, 2.82 the same issue

Just encountered the same bug. 2.80, 2.81, 2.82 the same issue

@Vyach It's logic, any version with annotations has the same issue. I'm working now in a big refactor of Sculpt/Weight Paint and new Vertex Paint and after that, I will work in this bug.

@Vyach It's logic, any version with annotations has the same issue. I'm working now in a big refactor of Sculpt/Weight Paint and new Vertex Paint and after that, I will work in this bug.

@antoniov Thank you! I'll wait.

@antoniov Thank you! I'll wait.

@dfelinto I have done a fix here D6467. Could you take a look?

@dfelinto I have done a fix here [D6467](https://archive.blender.org/developer/D6467). Could you take a look?
Antonio Vazquez changed title from Sidebar - temporary vanishing Annotation panel with adding a grease pencil object to Annotations and Grease Pencil panels cannot work at the same time 2019-12-22 11:12:29 +01:00
Antonio Vazquez was unassigned by Dalai Felinto 2019-12-23 13:44:07 +01:00

Added subscriber: @Academic-Expert

Added subscriber: @Academic-Expert

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Antonio Vazquez self-assigned this 2020-01-07 11:42:14 +01:00
Thomas Dinges added this to the 2.82 milestone 2023-02-08 16:41:38 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#71497
No description provided.