Memory Leak in Collada Importer #71718

New Issue

Andy · 2019-11-21T01:41:34+01:00

Andy commented

2019-11-21 01:41:34 +01:00

System Information
Operating system: Windows 10

Blender Version
Broken:
2.81 (sub 16), branch: master, commit date: 2019-11-18 12:53, hash: 115a5bf65a, type: Release

Short:
The memory consumption increases constantly when Collada files are imported. Even when loading another Blender file, the used memory is not reduced.

Detailed:

Download the Blender and Collada file to the same directory
Check the memory usage of Blender (~90 MB in my case)
Open the Blender file and execute the simple script (Reproduction.py)
Check the memory usage of Blender (~ 350 MB in my case)
File -> New -> General
Check the memory usage of Blender (~ 350 MB in my case)

I discovered this issue when implementing a batch processing script where I was running out of memory to my surprise.

Example.dae
BugReproduction.blend

**System Information** Operating system: Windows 10 **Blender Version** Broken: 2.81 (sub 16), branch: master, commit date: 2019-11-18 12:53, hash: 115a5bf65a6b, type: Release Short: The memory consumption increases constantly when Collada files are imported. Even when loading another Blender file, the used memory is not reduced. Detailed: - Download the Blender and Collada file to the same directory - Check the memory usage of Blender (~90 MB in my case) - Open the Blender file and execute the simple script (Reproduction.py) - Check the memory usage of Blender (~ 350 MB in my case) - File -> New -> General - Check the memory usage of Blender (~ 350 MB in my case) I discovered this issue when implementing a batch processing script where I was running out of memory to my surprise. [Example.dae](https://archive.blender.org/developer/F8149684/Example.dae) [BugReproduction.blend](https://archive.blender.org/developer/F8149685/BugReproduction.blend)

Andy commented

2019-11-21 01:41:34 +01:00

Added subscriber: @DeepBlender

Germano Cavalcante commented

2019-11-21 13:59:41 +01:00

Added subscribers: @GaiaClary, @mano-wii

Gaia Clary was assigned by Germano Cavalcante

2019-11-21 13:59:41 +01:00

Germano Cavalcante commented

2019-11-21 13:59:41 +01:00

I confirm the memory leak.

Error: Not freed memory blocks: 3200, total unfreed memory 439.819336 MB

Mostly allocated in:

void AnimationImporter::animation_to_fcurves(COLLADAFW::AnimationCurve *curve)

@GaiaClary, would you mind taking a look at this?

I confirm the memory leak. ``` Error: Not freed memory blocks: 3200, total unfreed memory 439.819336 MB ``` Mostly allocated in: ``` void AnimationImporter::animation_to_fcurves(COLLADAFW::AnimationCurve *curve) ``` @GaiaClary, would you mind taking a look at this?

Gaia Clary commented

2019-11-21 23:28:06 +01:00

hmm, that is odd. I see where it obvioulsy goes wrong. I wonder though. It looks like an old bug. just out of curiosity: Have you checked if the memory leak also happens when you try with an animation that only contains trans/rot/loc and not matrix curves? I suspect that with that there is no memory leak...

I will take care :)

hmm, that is odd. I see where it obvioulsy goes wrong. I wonder though. It looks like an old bug. just out of curiosity: Have you checked if the memory leak also happens when you try with an animation that only contains trans/rot/loc and not matrix curves? I suspect that with that there is no memory leak... I will take care :)

Andy commented

2019-11-22 02:50:19 +01:00

I never had a look at the actual Collada files, but only tried to reproduce the issue. Would it help if I checked that?

Gaia Clary commented

2019-11-25 10:36:39 +01:00

There is no need to check it before the import is fixed. I was just curious to know in advance.

The thing is that the importer uses 16 fcurves to store matrix values whenever an animation is imported that has a stride of 16 in the animation Source (indicating matrix data) I believe those fcurves need to be removed later because they are just intermediate stores. However those curves are later marked as "used by blender" so that the importer does not remove them when cleaning up. And that most probably is the cause of the memory leak.

There is no need to check it before the import is fixed. I was just curious to know in advance. The thing is that the importer uses 16 fcurves to store matrix values whenever an animation is imported that has a stride of 16 in the animation Source (indicating matrix data) I believe those fcurves need to be removed later because they are just intermediate stores. However those curves are later marked as "used by blender" so that the importer does not remove them when cleaning up. And that most probably is the cause of the memory leak.

Gaia Clary removed their assignment 2019-11-25 23:41:06 +01:00

Campbell Barton was assigned by Gaia Clary

2019-11-25 23:41:06 +01:00

Gaia Clary commented

2019-11-25 23:41:06 +01:00

Added subscriber: @ideasman42

Gaia Clary commented

2019-11-25 23:41:06 +01:00

@DeepBlender : The Collada memory leak is fixed. However when i run your test script again, then there is still another leak:

Error: Not freed memory blocks: 2, total unfreed memory 0.000198 MB
new gesture len: 88 000001A76B4379F8
gesture rect new len: 16 000001A76B47CC88

The reported blocks are probably created in:

wmGesture.c : wmGesture *WM_gesture_new(bContext *C, const wmEvent *event, int type)

@ideasman42 : Can you give me a hint how i should proceed (if at all) ?

@DeepBlender : The Collada memory leak is fixed. However when i run your test script again, then there is still another leak: ``` Error: Not freed memory blocks: 2, total unfreed memory 0.000198 MB new gesture len: 88 000001A76B4379F8 gesture rect new len: 16 000001A76B47CC88 ``` The reported blocks are probably created in: ``` wmGesture.c : wmGesture *WM_gesture_new(bContext *C, const wmEvent *event, int type) ``` @ideasman42 : Can you give me a hint how i should proceed (if at all) ?

Gaia Clary commented

2019-11-26 11:24:10 +01:00

Changed status from 'Open' to: 'Resolved'

Gaia Clary closed this issue

2019-11-26 11:24:10 +01:00

Gaia Clary commented

2019-11-26 11:24:10 +01:00

@ideasman42 thanks for the fix!

So we can close this ticket now as fully resolved.

@ideasman42 thanks for the fix! So we can close this ticket now as fully resolved.

Andy commented

2019-11-26 11:51:47 +01:00

Thanks a lot to @GaiaClary and @ideasman42 !!!

Sign in to join this conversation.

3 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#71718

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Memory Leak in Collada Importer #71718