VSE (2.81): Copy-pasted meta strips lose all key frames #71723

New Issue

Clint Hobson · 2019-11-21T08:43:57+01:00

Clint Hobson commented

2019-11-21 08:43:57 +01:00

System Information
Operating system: Linux-4.19.0-1-amd64-x86_64-with-debian-9.11 64 Bits
Graphics card: GeForce GTX 1050/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 390.116

Blender Version
Broken: version: 2.81 (sub 16), branch: master, commit date: 2019-11-06 20:48, hash: 85637311c2
I tested this in 2.80 and 2.79 with the same results, which makes me wonder if this is known yet? Couldn't find in a search for "meta strip keyframes"

Short description of error
Meta strips appear to be self contained movie clips that can be re-used anywhere and perform exactly the same. But this isn't true for meta strips that have key frames. When you copy and paste a meta strip that contains key frame animation, the copy doesn’t have any of the keyframes, and remains static.

Exact steps for others to reproduce the error

Drag an image into the timeline. And check the "Offset" box in it's properties to stop it stretching to fill the screen.
Add a "Transform" effect strip to it
Add some key frames on the X and Y position of the Transform strip to move it around the screen.
Select both the image strip and the transform strip and press CTRL+G to make a Meta strip.
Select the meta strip, CTRL+C to copy, move the playhead somewhere else, CTRL+V to paste it
Notice that the pasted strip does not animate.

I've attached a minimal example that demonstrates the issue.
Meta clip animations.zip

**System Information** Operating system: Linux-4.19.0-1-amd64-x86_64-with-debian-9.11 64 Bits Graphics card: GeForce GTX 1050/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 390.116 **Blender Version** Broken: version: 2.81 (sub 16), branch: master, commit date: 2019-11-06 20:48, hash: `85637311c2` I tested this in 2.80 and 2.79 with the same results, which makes me wonder if this is known yet? Couldn't find in a search for "meta strip keyframes" **Short description of error** Meta strips appear to be self contained movie clips that can be re-used anywhere and perform exactly the same. But this isn't true for meta strips that have key frames. When you copy and paste a meta strip that contains key frame animation, the copy doesn’t have any of the keyframes, and remains static. **Exact steps for others to reproduce the error** - Drag an image into the timeline. And check the "Offset" box in it's properties to stop it stretching to fill the screen. - Add a "Transform" effect strip to it - Add some key frames on the X and Y position of the Transform strip to move it around the screen. - Select both the image strip and the transform strip and press CTRL+G to make a Meta strip. - Select the meta strip, CTRL+C to copy, move the playhead somewhere else, CTRL+V to paste it - Notice that the pasted strip does not animate. I've attached a minimal example that demonstrates the issue. [Meta clip animations.zip](https://archive.blender.org/developer/F8150695/Meta_clip_animations.zip)

Clint Hobson commented

2019-11-21 08:43:57 +01:00

Added subscriber: @Domarius-1

Clint Hobson changed title from ~~VSE (2.81): Meta strips lose all key frames~~ to VSE (2.81): Copy-pasted meta strips lose all key frames

2019-11-21 08:46:01 +01:00

Clint Hobson commented

2019-11-21 08:55:08 +01:00

Actually I've since found that duplicating the meta strip with SHIFT+D works as expected.

I just wonder then if copy paste should "deep copy" the key frames to the new pasted meta strip? As the current result seems unexpected. Normally we wouldn't expect to lose things in a copy paste. It threw me off.

Don't get me wrong, I'm thrilled I can do it after all, just thought I should leave this here in case it's not meant to behave that way.

Actually I've since found that duplicating the meta strip with SHIFT+D works as expected. I just wonder then if copy paste should "deep copy" the key frames to the new pasted meta strip? As the current result seems unexpected. Normally we wouldn't expect to lose things in a copy paste. It threw me off. Don't get me wrong, I'm thrilled I can do it after all, just thought I should leave this here in case it's not meant to behave that way.

Philipp Oeser commented

2019-11-21 10:33:52 +01:00

Added subscribers: @iss, @mont29, @Sergey, @lichtwerk

Philipp Oeser commented

2019-11-21 10:33:52 +01:00

Would like to take a step back here [excuse the short detour]
Doing this, because I think we could be a little more consistent across blender as a whole.

For duplicating objects, we have Preferences > Editing > Objects > Duplicate Data > Action (amongst others).
So when you duplicate (with Shift+D), you can specify if you want the action to be copied or not.
For copy-pasting objects this is not considered, blender always copies the action.
[this is the first inconsistency, and I would vote for taking the Preferences into account when copy-pasting. This would make it transparent to the user (instead of being hard-coded)]

Now for the sequencer:
When duplicating a strip [Shift+D], it seems we always get new fcurves
For copy-pasting, you never get new fcurves.
(this is another inconsistency, and I would vote to at least create new fcurves -- use SEQ_DUPE_ANIM in sequencer_copy_exec, but really I would also vote for taking above preferences into account, wouldnt this make sense?)

Minimal (at least dupe the anim -- preferences not taken into account)
P1166: #71723 minimal



diff --git a/source/blender/editors/space_sequencer/sequencer_edit.c b/source/blender/editors/space_sequencer/sequencer_edit.c
index 57a0d63c35e..6f0cb005eb7 100644
--- a/source/blender/editors/space_sequencer/sequencer_edit.c
+++ b/source/blender/editors/space_sequencer/sequencer_edit.c
@@ -3367,8 +3367,9 @@ static int sequencer_copy_exec(bContext *C, wmOperator *op)
     return OPERATOR_CANCELLED;
   }
 
+  int dupe_flag = SEQ_DUPE_UNIQUE_NAME | SEQ_DUPE_ANIM;
   BKE_sequence_base_dupli_recursive(
-      scene, scene, &nseqbase, ed->seqbasep, SEQ_DUPE_UNIQUE_NAME, LIB_ID_CREATE_NO_USER_REFCOUNT);
+      scene, scene, &nseqbase, ed->seqbasep, dupe_flag, LIB_ID_CREATE_NO_USER_REFCOUNT);
 
   /* To make sure the copied strips have unique names between each other add
    * them temporarily to the end of the original seqbase. (bug 25932)

That all being said, not sure if this could really be considered a bug, it is inconsistent/confusing at least.

@Sergey, @mont29, @iss: what do you think?
sidenote: was also voting for taking these preferences into account in D6120: Separate operators (mesh/curve/armature/gpencil): take user preferences into account for duplicating actions...

Would like to take a step back here [excuse the short detour] Doing this, because I think we could be a little more consistent across blender as a whole. For duplicating **objects**, we have `Preferences` > `Editing` > `Objects` > `Duplicate Data` > `Action` (amongst others). So when you **duplicate** (with Shift+D), you can specify if you want the action to be copied or not. For **copy-pasting** objects this is not considered, blender always copies the action. [this is the first inconsistency, and I would vote for taking the Preferences into account when copy-pasting. This would make it transparent to the user (instead of being hard-coded)] Now for the sequencer: When **duplicating** a strip [Shift+D], it seems we always get new fcurves For **copy-pasting**, you never get new fcurves. (this is another inconsistency, and I would vote to at least create new fcurves -- use `SEQ_DUPE_ANIM` in `sequencer_copy_exec`, but really I would also vote for taking above preferences into account, wouldnt this make sense?) Minimal (at least dupe the anim -- preferences not taken into account) [P1166: #71723 minimal](https://archive.blender.org/developer/P1166.txt) ``` diff --git a/source/blender/editors/space_sequencer/sequencer_edit.c b/source/blender/editors/space_sequencer/sequencer_edit.c index 57a0d63c35e..6f0cb005eb7 100644 --- a/source/blender/editors/space_sequencer/sequencer_edit.c +++ b/source/blender/editors/space_sequencer/sequencer_edit.c @@ -3367,8 +3367,9 @@ static int sequencer_copy_exec(bContext *C, wmOperator *op) return OPERATOR_CANCELLED; } + int dupe_flag = SEQ_DUPE_UNIQUE_NAME | SEQ_DUPE_ANIM; BKE_sequence_base_dupli_recursive( - scene, scene, &nseqbase, ed->seqbasep, SEQ_DUPE_UNIQUE_NAME, LIB_ID_CREATE_NO_USER_REFCOUNT); + scene, scene, &nseqbase, ed->seqbasep, dupe_flag, LIB_ID_CREATE_NO_USER_REFCOUNT); /* To make sure the copied strips have unique names between each other add * them temporarily to the end of the original seqbase. (bug 25932) ``` That all being said, not sure if this could really be considered a bug, it is inconsistent/confusing at least. @Sergey, @mont29, @iss: what do you think? sidenote: was also voting for taking these preferences into account in [D6120: Separate operators (mesh/curve/armature/gpencil): take user preferences into account for duplicating actions](https://archive.blender.org/developer/D6120)...

Richard Antalik commented

2019-11-21 11:53:16 +01:00

Copying + paste should include all necessary data, so definitely a bug IMO.

I see no problem in consolidating behavior here. But user needs to know, that mentioned user preference(s) apply to sequencer as well.

Copying + paste should include all necessary data, so definitely a bug IMO. I see no problem in consolidating behavior here. But user needs to know, that mentioned user preference(s) apply to sequencer as well.

david mcsween commented

2019-11-25 07:01:29 +01:00

Added subscriber: @davidmcsween

david mcsween commented

2019-11-25 07:01:29 +01:00

Adding this history as its an old issue
name can't find related issue from pre-maniphest but IIRC Campbell suggested that copy pasting strips as unique but with f-curves was problematic (although that may have been between scenes, not just the current timeline).

Adding this history as its an old issue [name ](https://developer.blender.org/T36263) can't find related issue from pre-maniphest but IIRC Campbell suggested that copy pasting strips as unique but with f-curves was problematic (although that may have been between scenes, not just the current timeline).

Philipp Oeser commented

2019-11-25 09:57:51 +01:00

Thx @davidmcsween finding the duplicate.
Also wasnt aware of the issue with unique naming.

Will merge these reports then...

Thx @davidmcsween finding the duplicate. Also wasnt aware of the issue with unique naming. Will merge these reports then...

Philipp Oeser commented

2019-11-25 09:57:59 +01:00

Closed as duplicate of #36263

Philipp Oeser closed this issue

2019-11-25 09:57:59 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

VSE (2.81): Copy-pasted meta strips lose all key frames #71723