[accessibility] Change default cursor color to increase the contrast with background #71793

Closed
opened 2019-11-22 23:14:25 +01:00 by Valentin · 22 comments
Member

System Information
Operating system: Windows
Graphics card:GTX 970

Blender Version
Broken: >2.8
Worked: (optional)

Short description of error

Currently blender use red cursor on background black and dark grey (on both light and dark theme) which is difficult to see
some may think this is just matter of preference but it's not, for people with vision impairment e.g : colorblind people.

Exact steps for others to reproduce the error

**System Information** Operating system: Windows Graphics card:GTX 970 **Blender Version** Broken: >2.8 Worked: (optional) **Short description of error** Currently blender use red cursor on background black and dark grey (on both light and dark theme) which is difficult to see some may think this is just matter of preference but it's not, for people with vision impairment e.g : colorblind people. **Exact steps for others to reproduce the error**
Author
Member

Added subscriber: @Poulpator

Added subscriber: @Poulpator

Added subscriber: @WilliamReynish

Added subscriber: @WilliamReynish

By default the cursor in Blender is just the default system arrow cursor.

By default the cursor in Blender is just the default system arrow cursor.
Member

Added subscriber: @Harley

Added subscriber: @Harley
Member

@WilliamReynish - I think he means the Blender 3D cursor, not the mouse cursor. Could use some love to work better on very dark and very dark backgrounds. And maybe thought through for color blindness too.

@WilliamReynish - I think he means the Blender 3D cursor, not the mouse cursor. Could use some love to work better on very dark and very dark backgrounds. And maybe thought through for color blindness too.
Author
Member

Sorry I wasn't specific enought. I mean the text cursor

this one{F8157279}

Sorry I wasn't specific enought. I mean the text cursor this one{[F8157279](https://archive.blender.org/developer/F8157279/text_cursor.png)}
Member

Added subscriber: @HooglyBoogly

Added subscriber: @HooglyBoogly
Member

I'm not sure why the text editor cursor is red anyway. The cursor everywhere else in Blender is colored by the theme to be a blue that goes well with everything else in the interface.

I would think there would be a global text cursor color defined in the theme and it wouldn't be local to different spaces.

I'm not sure why the text editor cursor is red anyway. The cursor everywhere else in Blender is colored by the theme to be a blue that goes well with everything else in the interface. I would think there would be a global text cursor color defined in the theme and it wouldn't be local to different spaces.
Member

But then why not change it in the theme settings?

CursorColor.png

But then why not change it in the theme settings? ![CursorColor.png](https://archive.blender.org/developer/F8157355/CursorColor.png)

Added subscriber: @ThinkingPolygons

Added subscriber: @ThinkingPolygons

In #71793#815693, @Harley wrote:
But then why not change it in the theme settings?

CursorColor.png

I didn't know about that cursor color property. But this is weird. What about the other text cursors in the rest of the application, is there a hidden property too? They seem to be hardcoded. Why can't they all share the same color property?

> In #71793#815693, @Harley wrote: > But then why not change it in the theme settings? > > ![CursorColor.png](https://archive.blender.org/developer/F8157355/CursorColor.png) I didn't know about that cursor color property. But this is weird. What about the other text cursors in the rest of the application, is there a hidden property too? They seem to be hardcoded. Why can't they all share the same color property?
Member

@ThinkingPolygons - What about the other text cursors in the rest of the application, is there a hidden property too? They seem to be hardcoded. Why can't they all share the same color property?

Oh you mean while entering text or a number into a regular UI element, for example in Properties or Preferences? Yes that is hardcoded (0.2, 0.6, 0.9). That could be fixed if I can find a nice central place to put such a theme preference. In the "Styles" section perhaps?

Why can't they all share the same color property?

We give the ability to have different background colors in the Console Editor and the Text Editor so it makes sense that you might need a different color for the text insertion caret for those two.

> @ThinkingPolygons - What about the other text cursors in the rest of the application, is there a hidden property too? They seem to be hardcoded. Why can't they all share the same color property? Oh you mean while entering text or a number into a regular UI element, for example in Properties or Preferences? Yes that is hardcoded (0.2, 0.6, 0.9). That could be fixed if I can find a nice central place to put such a theme preference. In the "Styles" section perhaps? > Why can't they all share the same color property? We give the ability to have different background colors in the Console Editor and the Text Editor so it makes sense that you might need a different color for the text insertion caret for those two.
Author
Member

In #71793#815693, @Harley wrote:
But then why not change it in the theme settings?

CursorColor.png

This is what I did, but I still think that when accessibility come with literally no downside, it should be the default, also well differentiate foreground and background is a bit "web design 101"

> In #71793#815693, @Harley wrote: > But then why not change it in the theme settings? > > ![CursorColor.png](https://archive.blender.org/developer/F8157355/CursorColor.png) This is what I did, but I still think that when accessibility come with literally no downside, it should be the default, also well differentiate foreground and background is a bit "web design 101"

In #71793#816028, @Harley wrote:
Oh you mean while entering text or a number into a regular UI element, for example in Properties or Preferences?

Yeah, those ones.

In the "Styles" section perhaps?

Why not? ?

But yeah, currently those are literally almost impossible to see, doesn't matter which theme. A theme setting would be a savior lol.

> In #71793#816028, @Harley wrote: > Oh you mean while entering text or a number into a regular UI element, for example in Properties or Preferences? Yeah, those ones. > In the "Styles" section perhaps? Why not? ? But yeah, currently those are literally almost impossible to see, doesn't matter which theme. A theme setting would be a savior lol.
Member

@Poulpator This is what I did, but I still think that when accessibility come with literally no downside, it should be the default, also well differentiate foreground and background is a bit "web design 101"

So this topic is just about the default colors set in the themes that ship with Blender and that can be changed at any time to suit individuals?

And you are asking for some change but have not proposed anything specific. Are you asking us to just make a better guess? Anything but red?

>@Poulpator This is what I did, but I still think that when accessibility come with literally no downside, it should be the default, also well differentiate foreground and background is a bit "web design 101" So this topic is just about the **default** colors set in the themes that ship with Blender and that can be changed at any time to suit individuals? And you are asking for *some change* but have not proposed anything specific. Are you asking us to just make a better guess? Anything but red?
Member

@ThinkingPolygons - ...those are literally almost impossible to see, doesn't matter which theme.

Yes, I've got something almost ready. It'll also fix the oversight that the width of the thing does not change with user scale or dpi. So it gets harder to see if you are using a high-dpi display like Retina.

> @ThinkingPolygons - ...those are literally almost impossible to see, doesn't matter which theme. Yes, I've got something almost ready. It'll also fix the oversight that the width of the thing does not change with user scale or dpi. So it gets harder to see if you are using a high-dpi display like Retina.

@Harley Amazing. ?

@Harley Amazing. ?
Member

This should add ability to change that text insertion cursor color outside of Text Editor and Python console:

https://developer.blender.org/D6295

This should add ability to change that text insertion cursor color outside of Text Editor and Python console: https://developer.blender.org/D6295
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Harley Acheson was assigned by Philipp Oeser 2019-12-05 15:40:04 +01:00
Member

@Harley : mind if I assign to you?
(just cleaning up tracker status here...)

@Harley : mind if I assign to you? (just cleaning up tracker status here...)
Member

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Member

Closing and setting to resolved.

With this commit... https://developer.blender.org/rBb374b24f1b2dea4360f318fe3c86bede00bdaae4

Can now set text cursor color for Ui widgets. Could already set theme color for text cursor in text editor and python console so can do that everywhere now.

Closing and setting to resolved. With this commit... https://developer.blender.org/rBb374b24f1b2dea4360f318fe3c86bede00bdaae4 Can now set text cursor color for Ui widgets. Could already set theme color for text cursor in text editor and python console so can do that everywhere now.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
6 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#71793
No description provided.