Make Proxy: Object.proxy_collection is been set to linked target object even when target is not a collection #72083

New Issue

Macroni · 2019-12-01T07:34:21+01:00

Macroni commented

2019-12-01 07:34:21 +01:00

System Information
Operating system: Linux
Graphics card:

Blender Version
Broken: 2.81
Worked: 2.79

In 2.79 linking in a object (‘Cube’) then making a proxy of it will create a new object
Cube_proxy with Cube_proxy.proxy pointing to Cube and Cube_proxy.proxy_group == null.

in 2.81 'Cube_proxy.proxy' points to 'Cube' and 'Cube_proxy.proxy_collection' to Cube.

Reading the docs this look like a bug

**System Information** Operating system: Linux Graphics card: **Blender Version** Broken: 2.81 Worked: 2.79 In 2.79 linking in a object (‘Cube’) then making a proxy of it will create a new object Cube_proxy with Cube_proxy.proxy pointing to Cube and Cube_proxy.proxy_group == null. in 2.81 'Cube_proxy.proxy' points to 'Cube' and 'Cube_proxy.proxy_collection' to Cube. Reading the docs this look like a bug

Macroni commented

2019-12-01 07:34:21 +01:00

Added subscriber: @Macroni

Germano Cavalcante commented

2019-12-03 15:34:48 +01:00

Added subscribers: @mont29, @mano-wii

Germano Cavalcante commented

2019-12-03 15:34:48 +01:00

@mont29, do you know what may be happening there?

Macroni commented

2019-12-03 18:56:23 +01:00

Cant tell if its intentional but looking at 2.79 code and 2.81.

there is a missing line 'gob = NULL;'

in function static int make_proxy_exec(bContext *C, wmOperator *op)

in file /blender/source/blender/editors/object/object_relations.c at line 388

Cant tell if its intentional but looking at 2.79 code and 2.81. there is a missing line 'gob = NULL;' in function static int make_proxy_exec(bContext *C, wmOperator *op) in file /blender/source/blender/editors/object/object_relations.c at line 388

dupoxy commented

2019-12-03 19:33:42 +01:00

Added subscriber: @dupoxy

Germano Cavalcante commented

2020-01-15 14:05:22 +01:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Germano Cavalcante commented

2020-01-15 14:05:22 +01:00

Removed subscriber: @mont29

Germano Cavalcante commented

2020-01-15 14:05:22 +01:00

This issue is difficult to investigate because this report does not follow the submission template and guidelines.
Please, make a complete, valid bug report, with required info, precise description of the issue, precise steps to reproduce it, small and simple .blend and/or other files to do so if needed, etc.
Also read these tips about bug reports.

This issue is difficult to investigate because this report does not follow the [submission template and guidelines](https://developer.blender.org/maniphest/task/edit/form/1/). Please, make a complete, valid bug report, with required info, precise description of the issue, precise steps to reproduce it, small and simple .blend and/or other files to do so if needed, etc. Also read [these tips about bug reports](https://wiki.blender.org/wiki/Process/Bug_Reports).

blender-admin commented

2020-01-22 15:47:02 +01:00

This issue was referenced by 005af1e274

This issue was referenced by 005af1e274599939c71dce4e9fa7e0e64e6b531f

Philipp Oeser commented

2020-01-22 15:55:35 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2020-01-22 15:55:35 +01:00

Changed status from 'Needs User Info' to: 'Confirmed'

Philipp Oeser commented

2020-01-22 15:55:35 +01:00

Would also think it was (accidentally) removed in {be9e469ead}?
https://developer.blender.org/rBbe9e469ead227aee8d4c29b98a125cf599c5c8bb#change-pFg0VUTAHY2q

Not too familiar with proxies, but I wonder if this is responsible for a couple of Proxy reports relating to glitchy transforms in that case?

Would also think it was (accidentally) removed in {be9e469ead}? https://developer.blender.org/rBbe9e469ead227aee8d4c29b98a125cf599c5c8bb#change-pFg0VUTAHY2q Not too familiar with proxies, but I wonder if this is responsible for a couple of Proxy reports relating to glitchy transforms in that case?

Philipp Oeser changed title from ~~Bpy Object.proxy_collection is been set to linked target object even when target is not a collection~~ to Make Proxy: Object.proxy_collection is been set to linked target object even when target is not a collection

2020-01-22 16:04:09 +01:00

Macroni commented

2020-01-23 10:42:06 +01:00

For source/blender/editors/object/object_relations.c
In https://developer.blender.org/rBbe9e469ead227aee8d4c29b98a125cf599c5c8bb#change-pFg0VUTAHY2q
Looks to me like the line "gob = NULL;" at 355 was needed.
but i am not familiar with 2.81 collections architecture.

also the proxy object transform looks bugged to me
On blender-2.82-3e11c4e63b2f-linux-glibc217-x86_64 , it looks like the object transform is been applied twice for the proxy object.

i have uploaded two files test1.blend and test2.blend
test1.blend has a single cube object 'Cube'.
i linked it into test2.blend ( File -> Link )
and then created a proxy using Object -> Relations -> Make Proxy

in blender 2.79 the linked object 'Cube' and proxy object 'Cube_proxy' both have same transform
but in 2.82 the transform for Cube_proxy looks like it been applied twice
test2.blend

test1.blend

For source/blender/editors/object/object_relations.c In https://developer.blender.org/rBbe9e469ead227aee8d4c29b98a125cf599c5c8bb#change-pFg0VUTAHY2q Looks to me like the line "gob = NULL;" at 355 was needed. but i am not familiar with 2.81 collections architecture. also the proxy object transform looks bugged to me On blender-2.82-3e11c4e63b2f-linux-glibc217-x86_64 , it looks like the object transform is been applied twice for the proxy object. i have uploaded two files test1.blend and test2.blend test1.blend has a single cube object 'Cube'. i linked it into test2.blend ( File -> Link ) and then created a proxy using Object -> Relations -> Make Proxy in blender 2.79 the linked object 'Cube' and proxy object 'Cube_proxy' both have same transform but in 2.82 the transform for Cube_proxy looks like it been applied twice [test2.blend](https://archive.blender.org/developer/F8296684/test2.blend) [test1.blend](https://archive.blender.org/developer/F8296682/test1.blend)

Philipp Oeser commented

2020-01-23 11:10:35 +01:00

Thx @Macroni for posting the double transform testcase.
I totally agree with you here, made this a patch in D6651...
#72197 seems to also be fixed by this
Great find!

Thx @Macroni for posting the double transform testcase. I totally agree with you here, made this a patch in [D6651](https://archive.blender.org/developer/D6651)... #72197 seems to also be fixed by this Great find!

Philipp Oeser commented

2020-01-24 09:56:57 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Philipp Oeser closed this issue

2020-01-24 09:56:57 +01:00

Philipp Oeser self-assigned this 2020-01-24 09:56:57 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Make Proxy: Object.proxy_collection is been set to linked target object even when target is not a collection #72083