Crash when issuing an undo operation immediately after linking a collection when an outliner's display mode is set to "Blender File" #72887

New Issue

Rey Leonard M. Amorato · 2020-01-03T19:07:04+01:00

2020-01-03 19:07:04 +01:00

System Information
Operating system: Linux-5.3.0-26-generic-x86_64-with-Ubuntu-19.10-eoan 64 Bits
Graphics card: AMD Radeon RX 5700 XT (NAVI10, DRM 3.33.0, 5.3.0-26-generic, LLVM 9.0.0) X.Org 4.5 (Core Profile) Mesa 19.2.1

Blender Version
Broken: version: 2.82 (sub 6), branch: master, commit date: 2020-01-03 10:02, hash: 9b74e648c5
Worked: Never

Short description of error
Blender crashes when issuing an undo operation immediately after linking a collection when an Outliner's display mode set to Blender File
It doesn't matter how many Outliners are open, as long as one is set to Blender File.
This only happens when linking, not appending. No other data blocks causes the crash except collections.

Log files:
blender.crash.txt
terminal-output.txt

Exact steps for others to reproduce the error
Apparently the issue occurs only if the linked collection also has linked stuff? In the test case, the collection to be linked has linked materials.
Blender does not crash when linking standalone collections.

Download these files:
TEST.blend
1.blend
2.blend

Open TEST.blend
Link a collection from 2.blend (2.blend has an object linked from 1.blend; now the Outliner has 2 linked files)

Undo the operation (Ctrl+Z)

**System Information** Operating system: Linux-5.3.0-26-generic-x86_64-with-Ubuntu-19.10-eoan 64 Bits Graphics card: AMD Radeon RX 5700 XT (NAVI10, DRM 3.33.0, 5.3.0-26-generic, LLVM 9.0.0) X.Org 4.5 (Core Profile) Mesa 19.2.1 **Blender Version** Broken: version: 2.82 (sub 6), branch: master, commit date: 2020-01-03 10:02, hash: `9b74e648c5` Worked: Never **Short description of error** Blender crashes when issuing an undo operation immediately after linking a collection when an Outliner's display mode set to *Blender File* It doesn't matter how many Outliners are open, as long as one is set to *Blender File*. This only happens when linking, not appending. No other data blocks causes the crash except collections. Log files: [blender.crash.txt](https://archive.blender.org/developer/F8258585/blender.crash.txt) [terminal-output.txt](https://archive.blender.org/developer/F8258586/terminal-output.txt) **Exact steps for others to reproduce the error** Apparently the issue occurs only if the linked collection also has linked stuff? In the test case, the collection to be linked has linked materials. Blender does not crash when linking standalone collections. Download these files: [TEST.blend](https://archive.blender.org/developer/F8258608/TEST.blend) [1.blend](https://archive.blender.org/developer/F8258609/1.blend) [2.blend](https://archive.blender.org/developer/F8258610/2.blend) - Open TEST.blend - Link a collection from 2.blend (2.blend has an object linked from 1.blend; now the Outliner has 2 linked files) # Undo the operation (Ctrl+Z)

Rey Leonard M. Amorato commented

2020-01-03 19:07:04 +01:00

Added subscriber: @RL

ronsn commented

2020-01-03 19:49:30 +01:00

Added subscriber: @ronsn

ronsn commented

2020-01-03 19:49:30 +01:00

I can not reproduce this issue.

–––––––––––––––––––––––––

System Information
Operating system: Linux-5.0.0-37-generic-x86_64-with-debian-buster-sid 64 Bits (Ubuntu 18.04)
Graphics card: GeForce GTX 1660 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 435.21

Blender Version
version: 2.82 (sub 6), branch: master, commit date: 2020-01-03 10:02, hash: 9b74e648c5

I can not reproduce this issue. ––––––––––––––––––––––––– **System Information** Operating system: Linux-5.0.0-37-generic-x86_64-with-debian-buster-sid 64 Bits (Ubuntu 18.04) Graphics card: GeForce GTX 1660 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 435.21 **Blender Version** version: 2.82 (sub 6), branch: master, commit date: 2020-01-03 10:02, hash: `9b74e648c5`

Robert Guetzkow commented

2020-01-03 20:20:57 +01:00

Added subscriber: @rjg

Robert Guetzkow commented

2020-01-03 20:20:57 +01:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Robert Guetzkow commented

2020-01-03 20:20:57 +01:00

I cannot reproduce this on Windows with the latest master either. Is there anything special about the collection you're linking?

Rey Leonard M. Amorato commented

2020-01-03 20:34:38 +01:00

Changed status from 'Needs User Info' to: 'Needs Triage'

Rey Leonard M. Amorato commented

2020-01-03 20:38:52 +01:00

Added more info; the collection to be linked also has linked materials.

Added more info; the collection to be linked also has linked materials. ![Screenshot from 2020-01-04 03-37-27.png](https://archive.blender.org/developer/F8258596/Screenshot_from_2020-01-04_03-37-27.png)

ronsn commented

2020-01-03 20:55:11 +01:00

Okay, I can confirm that issue, that Blender crashes if you link something from a file where also something is linked in!

ronsn commented

2020-01-03 20:55:59 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

ronsn commented

2020-01-03 22:52:44 +01:00

This issue also occurs in version: 2.80 (sub 75), branch: master, commit date: 2019-07-29 14:47, hash: f6cb5f5449

@rjg: This task might have a High priority, isn't it?

This issue also occurs in version: 2.80 (sub 75), branch: master, commit date: 2019-07-29 14:47, hash: `f6cb5f5449` @rjg: This task might have a `High` priority, isn't it?

Robert Guetzkow commented

2020-01-03 23:36:44 +01:00

I can confirm this as well. Since this bug is crashing Blender, I'm setting the priority to high.

The tree elements of the outliner contain invalid pointers.

BLI_addtail(ListBase * listbase, void * vlink) Line 119	C
outliner_add_element(SpaceOutliner * soops, ListBase * lb, void * idv, TreeElement * parent, short type, short index) Line 796	C
outliner_add_library_contents(Main * mainvar, SpaceOutliner * soops, ListBase * lb, Library * lib) Line 1282	C
outliner_build_tree(Main * mainvar, Scene * scene, ViewLayer * view_layer, SpaceOutliner * soops, ARegion * ar) Line 2329	C
draw_outliner(const bContext * C) Line 3635	C
outliner_main_region_draw(const bContext * C, ARegion * ar) Line 96	C
ED_region_do_draw(bContext * C, ARegion * ar) Line 539	C
wm_draw_window_offscreen(bContext * C, wmWindow * win, bool stereo) Line 628	C
wm_draw_window(bContext * C, wmWindow * win) Line 766	C
wm_draw_update(bContext * C) Line 946	C
WM_main(bContext * C) Line 424	C
main(int argc, const unsigned char * * UNUSED_argv_c) Line 520	C

I can confirm this as well. Since this bug is crashing Blender, I'm setting the priority to high. The tree elements of the outliner contain invalid pointers. ``` BLI_addtail(ListBase * listbase, void * vlink) Line 119 C outliner_add_element(SpaceOutliner * soops, ListBase * lb, void * idv, TreeElement * parent, short type, short index) Line 796 C outliner_add_library_contents(Main * mainvar, SpaceOutliner * soops, ListBase * lb, Library * lib) Line 1282 C outliner_build_tree(Main * mainvar, Scene * scene, ViewLayer * view_layer, SpaceOutliner * soops, ARegion * ar) Line 2329 C draw_outliner(const bContext * C) Line 3635 C outliner_main_region_draw(const bContext * C, ARegion * ar) Line 96 C ED_region_do_draw(bContext * C, ARegion * ar) Line 539 C wm_draw_window_offscreen(bContext * C, wmWindow * win, bool stereo) Line 628 C wm_draw_window(bContext * C, wmWindow * win) Line 766 C wm_draw_update(bContext * C) Line 946 C WM_main(bContext * C) Line 424 C main(int argc, const unsigned char * * UNUSED_argv_c) Line 520 C ```

dupoxy commented

2020-01-09 20:20:39 +01:00

Added subscriber: @dupoxy

Bastien Montagne commented

2020-01-16 12:01:32 +01:00

Added subscriber: @mont29

Bastien Montagne self-assigned this 2020-01-16 12:01:32 +01:00

Bastien Montagne commented

2020-01-16 12:01:33 +01:00

This actually exhibits two issues:

Outliner crash (looks like it does not like the situation generated by undo in that case).
Undo code keeps reference to unused libraries, and even unused indirectly linked datablocks.

Will try to fix the crash in outliner first, then we'll see about cleaning up again that black dark magic of library handling in undos…

This actually exhibits two issues: - Outliner crash (looks like it does not like the situation generated by undo in that case). - Undo code keeps reference to unused libraries, and even unused indirectly linked datablocks. Will try to fix the crash in outliner first, then we'll see about cleaning up again that black dark magic of library handling in undos…

blender-admin commented

2020-01-16 16:04:23 +01:00

This issue was referenced by d74f9c4b7b

This issue was referenced by d74f9c4b7b4f2b9b72462f908bdd7e251a42f478

Bastien Montagne commented

2020-01-16 16:08:01 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Bastien Montagne closed this issue

2020-01-16 16:08:01 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crash when issuing an undo operation immediately after linking a collection when an outliner's display mode is set to "Blender File" #72887

Undo the operation (Ctrl+Z)