When changing the width of frame, it also changes frame location. #72904

New Issue

Kalle-Samuli Riihikoski · 2020-01-04T22:24:52+01:00

2020-01-04 22:24:52 +01:00

If you create frame and set it into (0,0) location. Then grab right side of the frame node and make frames width bigger. Now using python read the frame
location again and it is not (0,0) anymore.

If you create frame and set it into (0,0) location. Then grab right side of the frame node and make frames width bigger. Now using python read the frame location again and it is not (0,0) anymore. ![loca1.jpg](https://archive.blender.org/developer/F8260778/loca1.jpg)

Kalle-Samuli Riihikoski commented

2020-01-04 22:24:52 +01:00

Added subscriber: @Kalle-SamuliRiihikoski

Kalle-Samuli Riihikoski commented

2020-01-05 13:06:54 +01:00

https://blenderartists.org/t/how-frame-location-is-calculated/1199582/3

Kalle-Samuli Riihikoski changed title from ~~Frame location with python has issues.~~ to When changing the width of frame, it also changes frame location.

2020-01-05 13:19:44 +01:00

Kalle-Samuli Riihikoski commented

2020-01-06 02:04:15 +01:00

I found out that if I delete this part from node_edit.c line 983

  if (node->type == NODE_FRAME) {
          /* keep the offset symmetric around center point */
          if (nsw->directions & NODE_RESIZE_LEFT) {
            node->locx = nsw->oldlocx + 0.5f * dx;
            node->offsetx = nsw->oldoffsetx + 0.5f * dx;
          }
          if (nsw->directions & NODE_RESIZE_RIGHT) {
            node->locx = nsw->oldlocx + 0.5f * dx;
            node->offsetx = nsw->oldoffsetx - 0.5f * dx;
          }
          if (nsw->directions & NODE_RESIZE_TOP) {
            node->locy = nsw->oldlocy + 0.5f * dy;
            node->offsety = nsw->oldoffsety + 0.5f * dy;
          }
          if (nsw->directions & NODE_RESIZE_BOTTOM) {
            node->locy = nsw->oldlocy + 0.5f * dy;
            node->offsety = nsw->oldoffsety - 0.5f * dy;
          }
        }

deleting this part of code gives better result when you read frame location . It still dosen't give correct values thou. It would be nice know why this code part is there because in my tests frame node works without this code part just okey.

I found out that if I delete this part from node_edit.c line 983 ``` if (node->type == NODE_FRAME) { /* keep the offset symmetric around center point */ if (nsw->directions & NODE_RESIZE_LEFT) { node->locx = nsw->oldlocx + 0.5f * dx; node->offsetx = nsw->oldoffsetx + 0.5f * dx; } if (nsw->directions & NODE_RESIZE_RIGHT) { node->locx = nsw->oldlocx + 0.5f * dx; node->offsetx = nsw->oldoffsetx - 0.5f * dx; } if (nsw->directions & NODE_RESIZE_TOP) { node->locy = nsw->oldlocy + 0.5f * dy; node->offsety = nsw->oldoffsety + 0.5f * dy; } if (nsw->directions & NODE_RESIZE_BOTTOM) { node->locy = nsw->oldlocy + 0.5f * dy; node->offsety = nsw->oldoffsety - 0.5f * dy; } } ``` deleting this part of code gives better result when you read frame location . It still dosen't give correct values thou. It would be nice know why this code part is there because in my tests frame node works without this code part just okey.

Philipp Oeser commented

2020-01-06 12:17:51 +01:00

Added subscribers: @JacquesLucke, @brecht, @lichtwerk

Philipp Oeser commented

2020-01-06 12:17:51 +01:00

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'

Philipp Oeser commented

2020-01-06 12:17:51 +01:00

Yeah, this is a bit strange (since - from the python visible side - you can run into 2 frames having the exact same width, height & location, nevertheless they dont appear at the same spot).

This is caused by the node also having an offset [used in C, transform/drawing code etc], but this is not exposed to python, so no access there...

The offset was implemented in 53b01d9002.
In theory, I think frame nodes could even live without this (and only rely on location, width & height), but this would require a bit of refactor.

So maybe a solution is to just expose this offset to python?

However, this doesnt really look like a bug, it is more of an improvement to a [incomplete/annoying] implementation.
For user requests and feedback, please use other channels: https://wiki.blender.org/wiki/Communication/Contact#User_Feedback_and_Requests
For more information on why this might not be considered a bug, visit: https://wiki.blender.org/wiki/Reference/Not_a_bug

Hesitating to close though, this might be added as TODO to #66307 (Nodes & Physics Module), will let @JacquesLucke or @brecht decide...

Yeah, this is a bit strange (since - from the python visible side - you can run into 2 frames having the exact same width, height & location, nevertheless they dont appear at the same spot). This is caused by the node also having an offset [used in C, transform/drawing code etc], but this is not exposed to python, so no access there... The offset was implemented in 53b01d9002. In theory, I think frame nodes could even live without this (and only rely on location, width & height), but this would require a bit of refactor. So maybe a solution is to just expose this offset to python? However, this doesnt really look like a bug, it is more of an improvement to a [incomplete/annoying] implementation. For user requests and feedback, please use other channels: https://wiki.blender.org/wiki/Communication/Contact#User_Feedback_and_Requests For more information on why this might not be considered a bug, visit: https://wiki.blender.org/wiki/Reference/Not_a_bug Hesitating to close though, this might be added as TODO to #66307 (Nodes & Physics Module), will let @JacquesLucke or @brecht decide...

Kalle-Samuli Riihikoski commented

2020-01-06 12:33:43 +01:00

This would be import for me because I coding NodeCustomBuilder addon where nodetree is transferred into json file. I have had some difficult times to save frames exact location (including nodes that are inside of the frame) locations. I would be willing to work with issues if get some guidance what would be the best fix for this annoying issue.

In theory, I think frame nodes could even live without this (and only rely on location, width & height), but this would require a bit of refactor.

This for me sounds the most logical way but I really don't everything what going on under the hood.

This would be import for me because I coding NodeCustomBuilder addon where nodetree is transferred into json file. I have had some difficult times to save frames exact location (including nodes that are inside of the frame) locations. I would be willing to work with issues if get some guidance what would be the best fix for this annoying issue. >In theory, I think frame nodes could even live without this (and only rely on location, width & height), but this would require a bit of refactor. This for me sounds the most logical way but I really don't everything what going on under the hood.

Campbell Barton commented

2020-01-14 10:26:22 +01:00

Added subscriber: @ideasman42

Campbell Barton commented

2020-01-14 10:26:22 +01:00

Setting as TODO since this works as intended.

Campbell Barton commented

2020-01-14 10:26:32 +01:00

Changed status from 'Needs Developer To Reproduce' to: 'Confirmed'

Ray Mairlot commented

2022-08-26 19:41:44 +02:00

Added subscriber: @RayMairlot

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

When changing the width of frame, it also changes frame location. #72904