[Edit Mesh] overlay of linked meshes in Edit Mode. [2.82 regression] #73095

New Issue

Oleksandr Kahal · 2020-01-13T18:16:43+01:00

Oleksandr Kahal commented

2020-01-13 18:16:43 +01:00

System Information
Operating system: Windows-10-10.0.17763-SP0 64 Bits
Graphics card: GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 430.86

Blender Version
Broken: version: 2.82 (sub 6), branch: master, commit date: 2020-01-12 16:23, hash: 0ef881cc57
Worked: (optional)

Short description of error
References in Edit Mode don't show selected\deselected vertices\edges on each over (like in previouse versions (2.8, 2.81a))
Is this bug or maybe feature? If it is feature, do you be so pleasure to help found it on interface or hotkey? It hard to work without it. I had to downgrade to 2.81a, and work without cool 2.82's features.

Exact steps for others to reproduce the error

select object
make some duplicate linked (alt+D or from menu)
enter on "Edit Mode
look on references - you don't see any selected vertices\edges\faces (like in 2.8 or 2.81)
try to change something- loop cut on example
exit to "Object Mode" - you'll see all new edges (if get an wireframe on shaded)
try to enter "Edit Mode" again - all edges in "wireframe on shaded mode" dissapeared!

instaces_bug_or_feature.blend
References_bug_or_feature.mp4

**System Information** Operating system: Windows-10-10.0.17763-SP0 64 Bits Graphics card: GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 430.86 **Blender Version** Broken: version: 2.82 (sub 6), branch: master, commit date: 2020-01-12 16:23, hash: `0ef881cc57` Worked: (optional) **Short description of error** References in Edit Mode don't show selected\deselected vertices\edges on each over (like in previouse versions (2.8, 2.81a)) Is this bug or maybe feature? If it is feature, do you be so pleasure to help found it on interface or hotkey? It hard to work without it. I had to downgrade to 2.81a, and work without cool 2.82's features. **Exact steps for others to reproduce the error** - select object - make some duplicate linked (alt+D or from menu) - enter on "Edit Mode - look on references - you don't see any selected vertices\edges\faces (like in 2.8 or 2.81) - try to change something- loop cut on example - exit to "Object Mode" - you'll see all new edges (if get an wireframe on shaded) - try to enter "Edit Mode" again - all edges in "wireframe on shaded mode" dissapeared! [instaces_bug_or_feature.blend](https://archive.blender.org/developer/F8275964/instaces_bug_or_feature.blend) [References_bug_or_feature.mp4](https://archive.blender.org/developer/F8275965/References_bug_or_feature.mp4)

Oleksandr Kahal commented

2020-01-13 18:16:43 +01:00

Added subscriber: @ignietferro-1

blender-admin commented

2020-01-13 18:16:43 +01:00

#59203 was marked as duplicate of this issue

Oleksandr Kahal changed title from ~~[References] References in Edit Mode~~ to [References] References in Edit Mode. 2.82

2020-01-13 18:17:09 +01:00

ronsn commented

2020-01-13 19:40:21 +01:00

Added subscriber: @ronsn

ronsn commented

2020-01-13 19:40:21 +01:00

This behavior was introduced by this Git commit 07a959067d5a3c05fcbd65105525d6e139be5c5f (07a959067d).

This behavior was introduced by this Git commit `07a959067d5a3c05fcbd65105525d6e139be5c5f` (07a959067d).

Oleksandr Kahal commented

2020-01-13 20:23:11 +01:00

So it means it would be? And references now couldn't be exactly as in previous versions? Or it is going to resolve in the future? Maybe I didn't understand something... I'm not coder, I'm 3D artist.

ronsn commented

2020-01-13 20:40:52 +01:00

@ignietferro-1: As far as I can see it was not intended to let it behave like this, but it is also likely that this behavior is a result of a necessary change to prevent Blender to crash in some situations like this one: https://developer.blender.org/T72848

However: My comment with that weird string wasn't addressed to you personally but for other developers to investigate this issue faster (if and when someone has time to investigate). :)

@ignietferro-1: As far as I can see it was not intended to let it behave like this, but it is also likely that this behavior is a result of a necessary change to prevent Blender to crash in some situations like this one: https://developer.blender.org/T72848 However: My comment with that weird string wasn't addressed to you personally but for other developers to investigate this issue faster (if and when someone has time to investigate). :)

Oleksandr Kahal commented

2020-01-14 12:31:26 +01:00

@ronsn Big thanks for explanation! I'll be waiting for resolvation of that issue.

Germano Cavalcante commented

2020-01-14 17:50:14 +01:00

Added subscribers: @ideasman42, @mano-wii

Germano Cavalcante commented

2020-01-14 17:50:14 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Germano Cavalcante commented

2020-01-14 17:50:14 +01:00

I can confirm that 07a959067d introduced the problem.
@ideasman42, mind taking a look?

I can confirm that `07a959067d` introduced the problem. @ideasman42, mind taking a look?

Germano Cavalcante changed title from ~~[References] References in Edit Mode. 2.82~~ to [Edit Mesh] overlay of linked meshes in Edit Mode. [2.82 regression]

2020-01-14 17:52:29 +01:00

Marten Homma commented

2020-01-14 23:04:14 +01:00

Added subscriber: @martenmh

Marten Homma commented

2020-01-14 23:04:14 +01:00

I think i've tracked it down to this line in overlay_engine.c:

 188   const bool in_edit_mode = (ob->mode & OB_MODE_EDIT) && BKE_object_is_in_editmode(ob);

As stated by @ronsn and @mano-wii it was introduced in 07a959067d,
so simply changing it back to

188   const bool in_edit_mode = BKE_object_is_in_editmode(ob);

will resolve the issue.
However, testing https:*developer.blender.org/T72848 causes a segfault.

I think i've tracked it down to this line in `overlay_engine.c`: ``` 188 const bool in_edit_mode = (ob->mode & OB_MODE_EDIT) && BKE_object_is_in_editmode(ob); ``` As stated by @ronsn and @mano-wii it was introduced in `07a959067d`, so simply changing it back to ``` 188 const bool in_edit_mode = BKE_object_is_in_editmode(ob); ``` will resolve the issue. However, testing [https:*developer.blender.org/T72848 ](https:*developer.blender.org/T72848) causes a segfault.

Brecht Van Lommel commented

2020-01-15 16:55:59 +01:00

Added subscriber: @brecht

Brecht Van Lommel commented

2020-01-15 16:55:59 +01:00

Tagging with 2.82 since this was marked as high priority and is a regression.

Germano Cavalcante commented

2020-01-17 19:53:49 +01:00

Added subscribers: @HenriqueGonzaga, @JacquesLucke

Jeroen Bakker commented

2020-01-29 16:28:55 +01:00

Added subscriber: @Jeroen-Bakker

Jeroen Bakker self-assigned this 2020-01-29 16:28:55 +01:00

Jeroen Bakker commented

2020-01-29 16:28:55 +01:00

Issue wasn't assigned. Will check on it upcoming week.

blender-admin commented

2020-02-03 08:16:38 +01:00

This issue was referenced by d09646a40b

This issue was referenced by d09646a40b1928308025d8ceb2c2d505651fc9a4

Jeroen Bakker commented

2020-02-03 08:39:25 +01:00

Seems like that b281 and b280 drew all the object as they were in edit mode, but the selection engine didn't react to the duplicates as these objects were not in edit mode. Personally I find the functionality a bit weird but this was also the case for b279 so will add a patch.

Note that I wasn't able to let it crash as mentioned by @martenmh. This could be that other changes (like #72490 (Collections: Exclude From View toggle causes segment violation.)) fixed the crash.
Could other people help out testing the patch provided by @martenmh.

Seems like that b281 and b280 drew all the object as they were in edit mode, but the selection engine didn't react to the duplicates as these objects were not in edit mode. Personally I find the functionality a bit weird but this was also the case for b279 so will add a patch. Note that I wasn't able to let it crash as mentioned by @martenmh. This could be that other changes (like #72490 (Collections: Exclude From View toggle causes segment violation.)) fixed the crash. Could other people help out testing the patch provided by @martenmh.

Jeroen Bakker commented

2020-02-03 13:44:17 +01:00

I am not able to reproduce the issue that @ideasman42 mentions in the patch. In a discussion on blender.chat we identified that this functionality has differences between blender versions and has limitations when used in different ways (modifiers + multi object editing selection to name some)

Render with modifiers

2.79: Does not render the edit overlay when one object has a modifier (visible or not)
2.80+2.81: Does render the edit overlay event when modifiers are added, resulting in incorrect geometry
2.82: Does not render the edit overlay at all
2.82 + this patch: renders like 2.80 or 2.81, but it has been reported that it crashes when adding/removing modifiers

Render without modifiers

2.79 will render the edit overlay on all duplicates
2.80+2.81 will render the editor overlay on all duplicates
2.82 will not render the edit overlay
2.82 + this patch: renders like 2.80 or 2.81.

Other issues

Multi object editing of linked duplicated meshes: Selection does not work, except for the active object

In the manual a overview is given https://docs.blender.org/manual/en/latest/scene_layout/object/editing/duplication.html#linked-duplicates but does not go into the details. What makes it valid to apply the patch with the addition to check for active modifiers. This option has there been for a long time but hasn't have good documentation, therefore can failed when used differently.

My biggest concern is that it has been reported that the change crashes when used in a certain way.

I am not able to reproduce the issue that @ideasman42 mentions in the patch. In a discussion on blender.chat we identified that this functionality has differences between blender versions and has limitations when used in different ways (modifiers + multi object editing selection to name some) **Render with modifiers** * 2.79: Does not render the edit overlay when one object has a modifier (visible or not) ![Screenshot from 2020-02-03 13-24-30.png](https://archive.blender.org/developer/F8318907/Screenshot_from_2020-02-03_13-24-30.png) * 2.80+2.81: Does render the edit overlay event when modifiers are added, resulting in incorrect geometry ![Screenshot from 2020-02-03 13-25-46.png](https://archive.blender.org/developer/F8318910/Screenshot_from_2020-02-03_13-25-46.png) * 2.82: Does not render the edit overlay at all ![Screenshot from 2020-02-03 13-27-38.png](https://archive.blender.org/developer/F8318912/Screenshot_from_2020-02-03_13-27-38.png) * 2.82 + this patch: renders like 2.80 or 2.81, but it has been reported that it crashes when adding/removing modifiers ![Screenshot from 2020-02-03 13-25-46.png](https://archive.blender.org/developer/F8318910/Screenshot_from_2020-02-03_13-25-46.png) **Render without modifiers** * 2.79 will render the edit overlay on all duplicates ![Screenshot from 2020-02-03 13-30-30.png](https://archive.blender.org/developer/F8318929/Screenshot_from_2020-02-03_13-30-30.png) * 2.80+2.81 will render the editor overlay on all duplicates ![Screenshot from 2020-02-03 13-31-07.png](https://archive.blender.org/developer/F8318930/Screenshot_from_2020-02-03_13-31-07.png) * 2.82 will not render the edit overlay ![Screenshot from 2020-02-03 13-31-18.png](https://archive.blender.org/developer/F8318932/Screenshot_from_2020-02-03_13-31-18.png) * 2.82 + this patch: renders like 2.80 or 2.81. ![Screenshot from 2020-02-03 13-31-07.png](https://archive.blender.org/developer/F8318930/Screenshot_from_2020-02-03_13-31-07.png) **Other issues** * Multi object editing of linked duplicated meshes: Selection does not work, except for the active object In the manual a overview is given https://docs.blender.org/manual/en/latest/scene_layout/object/editing/duplication.html#linked-duplicates but does not go into the details. What makes it valid to apply the patch with the addition to check for active modifiers. This option has there been for a long time but hasn't have good documentation, therefore can failed when used differently. My biggest concern is that it has been reported that the change crashes when used in a certain way.

Brecht Van Lommel commented

2020-02-03 13:55:19 +01:00

Also see #65778 (linked duplicate objects - issues with selection in edit mode) and #72733 (Issue with shared meshes overwriting modifiers).

Jeroen Bakker commented

2020-02-04 07:50:00 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Jeroen Bakker closed this issue

2020-02-04 07:50:00 +01:00

Thomas Dinges added this to the 2.82 milestone 2023-02-08 16:41:38 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

[Edit Mesh] overlay of linked meshes in Edit Mode. [2.82 regression] #73095