Delaunay Triangulation not robust enough #73171

Closed
opened 2020-01-16 21:10:23 +01:00 by Howard Trickey · 5 comments
Member

System Information
Operating system: linux, MacOs
Graphics card: n/a

Blender Version
Broken: 2.81
Worked: (optional)

As reported in this devtalk thread: https://devtalk.blender.org/t/delaunay-2d-cdt-robustness/10968
some uses of the new library routine BLI_delaunay_cdt_calc cause crashes.

Exact steps for others to reproduce the error
The thread has 5 scripts to run, each of which causes a crash.
Two of the bigger ones I have turned into a file that the delaunay unit test program knows how to read:
CIRCcdtinput.txt

CIRC2cdtinput.txt

The rest are more easily turned directly into unit tests.

**System Information** Operating system: linux, MacOs Graphics card: n/a **Blender Version** Broken: 2.81 Worked: (optional) As reported in this devtalk thread: https://devtalk.blender.org/t/delaunay-2d-cdt-robustness/10968 some uses of the new library routine BLI_delaunay_cdt_calc cause crashes. **Exact steps for others to reproduce the error** The thread has 5 scripts to run, each of which causes a crash. Two of the bigger ones I have turned into a file that the delaunay unit test program knows how to read: [CIRCcdtinput.txt](https://archive.blender.org/developer/F8282017/CIRCcdtinput.txt) [CIRC2cdtinput.txt](https://archive.blender.org/developer/F8282018/CIRC2cdtinput.txt) The rest are more easily turned directly into unit tests.
Author
Member

Added subscriber: @howardt

Added subscriber: @howardt
Howard Trickey self-assigned this 2020-01-16 21:13:36 +01:00
Author
Member

I have been working on this for a while, and had already submitted one change that fixed the first crash, but the other reports showed that a more fundamental rethinking of the code was likely necessary. I am near a solution, but am putting this bug here so that there will be a record of why the rewrite was needed,

I have been working on this for a while, and had already submitted one change that fixed the first crash, but the other reports showed that a more fundamental rethinking of the code was likely necessary. I am near a solution, but am putting this bug here so that there will be a record of why the rewrite was needed,
Author
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Author
Member

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Author
Member

This was fixed with commit 2867c35d4e

This was fixed with commit 2867c35d4e
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#73171
No description provided.