Texture Paint colour sampling is broken on some image formats #73682

Closed
opened 2020-02-08 22:02:23 +01:00 by Vas · 7 comments

System Information
Operating system: Windows-10-10.0.17763-SP0 64 Bits
Graphics card: GeForce GTX 1050 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 441.66

Blender Version
Broken: version: 2.82 (sub 6), branch: master, commit date: 2020-02-06 20:44, hash: 763f117c48
Worked: (optional)

Short description of error

Basically, if your image texture is saved in one of these broken formats, you lose the capability of colour sampling correct colour, instead it'll always sample merged (affecting in that way the desired colour, since model could be in shadow/affected by environment colours)

Broken formats: DPX 16bit, HDR 32bit, EXR 32bit
(ignore PNG 32Bit in the image below, its actually mislabaled EXR 32bit)
image.png

Exact steps for others to reproduce the error

  • Open the file
  • It has two cubes that have respective formats with broken eyedropper sampling
  • try to texture paint on either of those
  • notice that when you sample color "S" it wont pick the correct color, instead it'll pick merged color as seen on viewport

(optional)

  • create a new cube
  • assign it a new texture
  • save texture as a PNG (8bit, 16bit)
  • go into texture paint
  • sample and notice that there is no problem!

Edit v1: fixed some mistakes in the description (removed PNG 32bit)
FORMAT PROBLEM.blend

**System Information** Operating system: Windows-10-10.0.17763-SP0 64 Bits Graphics card: GeForce GTX 1050 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 441.66 **Blender Version** Broken: version: 2.82 (sub 6), branch: master, commit date: 2020-02-06 20:44, hash: `763f117c48` Worked: (optional) **Short description of error** Basically, if your image texture is saved in one of these broken formats, you lose the capability of colour sampling correct colour, instead it'll always sample merged (affecting in that way the desired colour, since model could be in shadow/affected by environment colours) Broken formats: DPX 16bit, HDR 32bit, EXR 32bit *(ignore PNG 32Bit in the image below, its actually mislabaled EXR 32bit)* ![image.png](https://archive.blender.org/developer/F8329970/image.png) **Exact steps for others to reproduce the error** - Open the file - It has two cubes that have respective formats with broken eyedropper sampling - try to texture paint on either of those - notice that when you sample color "S" it wont pick the correct color, instead it'll pick merged color as seen on viewport (optional) - create a new cube - assign it a new texture - save texture as a PNG (8bit, 16bit) - go into texture paint - sample and notice that there is no problem! *Edit v1: fixed some mistakes in the description (removed PNG 32bit)* [FORMAT PROBLEM.blend](https://archive.blender.org/developer/F8330031/FORMAT_PROBLEM.blend)
Author

Added subscriber: @Alumx

Added subscriber: @Alumx
Member

Added subscribers: @fclem, @Jeroen-Bakker, @EAW

Added subscribers: @fclem, @Jeroen-Bakker, @EAW
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

I can confirm. It seems that for some textures saved as higher bit depth formats, the color picker in texture paint mode treats the "Sampled Merged" check box as if it was always checked. For all 8-bit and some 16-bit textures, the color picker respects the check box. Perhaps the difference is whether the formats are saved as Linear or sRGB?

samples_merged.png

Other similar issues with vertex paint have been noted as needing improvements, and closed as invalid. See #72530, #63586, However, those appear to deal with the color picker picking the output display color in general, not differing between texture and display color per image format.

@Jeroen-Bakker @fclem I am not sure if this particular issue is already on the color management improvement radar. I did see https://developer.blender.org/T69562#864859, but not this specific issue.

@Alumx what did you mean when you wrote PNG 32bit? Blender refers to the per channel bit depth in the UI, so only 8-bit and 16-bit are available. See https://docs.blender.org/manual/en/latest/files/media/image_formats.html#image-formats


System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce GTX 470/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 388.13

Blender Version
Broken: version: 2.83 (sub 2), branch: master, commit date: 2020-02-07 22:49, hash: a010d97204

I can confirm. It seems that for some textures saved as higher bit depth formats, the color picker in texture paint mode treats the "Sampled Merged" check box as if it was always checked. For all 8-bit and some 16-bit textures, the color picker respects the check box. Perhaps the difference is whether the formats are saved as Linear or sRGB? ![samples_merged.png](https://archive.blender.org/developer/F8330688/samples_merged.png) Other similar issues with vertex paint have been noted as needing improvements, and closed as invalid. See #72530, #63586, However, those appear to deal with the color picker picking the output display color in general, not differing between texture and display color per image format. @Jeroen-Bakker @fclem I am not sure if this particular issue is already on the color management improvement radar. I did see https://developer.blender.org/T69562#864859, but not this specific issue. @Alumx what did you mean when you wrote `PNG 32bit`? Blender refers to the per channel bit depth in the UI, so only 8-bit and 16-bit are available. See https://docs.blender.org/manual/en/latest/files/media/image_formats.html#image-formats --- **System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: GeForce GTX 470/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 388.13 **Blender Version** Broken: version: 2.83 (sub 2), branch: master, commit date: 2020-02-07 22:49, hash: `a010d97204`
Author

Ah! You're right @EAW it was my mistake, apparently I saved it as EXR 32bit/channel , idk why I wrote PNG 32bit (might've gotten confused while checking extensions of all the textures) image.png

Ah! You're right @EAW it was my mistake, apparently I saved it as EXR 32bit/channel , idk why I wrote PNG 32bit (might've gotten confused while checking extensions of all the textures) ![image.png](https://archive.blender.org/developer/F8331059/image.png)

This issue was referenced by 3a1af7444c

This issue was referenced by 3a1af7444c36df7a3bd0ffcd8566c52136b14629

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Campbell Barton self-assigned this 2020-02-11 07:15:07 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#73682
No description provided.