depsgraph.object_instances does not respect collection visibility #74368

New Issue

Mikhail Rachinskiy · 2020-03-02T14:23:10+01:00

2020-03-02 14:23:10 +01:00

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce GTX 860M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 436.48

Blender Version
Broken: version: 2.83 (sub 5), branch: master, commit date: 2020-02-26 22:33, hash: 1a1f2912e6
Worked: 2.80 release

Short description of error
Collection visibility (Hide in Viewport) does not affect object appearance in depsgraph.object_instances.
While hiding objects individually or excluding collection from view layer or Disable in Viewports does hide them from depsgraph.object_instances.

In 2.80 release collection visibility did affect depsgraph.object_instances.

Exact steps for others to reproduce the error

Open attached blend file: dep_visibility.blend
Run the script > console output lists all three objects.
Use collection Hide in Viewport visibility options and run script > console output has the same objects regardless of collection visibility state.
Use Hide in Viewport on an individual object > console output remose this individual object

**System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: GeForce GTX 860M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 436.48 **Blender Version** Broken: version: 2.83 (sub 5), branch: master, commit date: 2020-02-26 22:33, hash: `1a1f2912e6` Worked: 2.80 release **Short description of error** Collection visibility (Hide in Viewport) does not affect object appearance in `depsgraph.object_instances`. While hiding objects individually or excluding collection from view layer or Disable in Viewports does hide them from `depsgraph.object_instances`. In 2.80 release collection visibility did affect `depsgraph.object_instances`. **Exact steps for others to reproduce the error** - Open attached blend file: [dep_visibility.blend](https://archive.blender.org/developer/F8383469/dep_visibility.blend) - Run the script > console output lists all three objects. - Use collection `Hide in Viewport` visibility options and run script > console output has the same objects regardless of collection visibility state. - Use `Hide in Viewport` on an individual object > console output remose this individual object

Mikhail Rachinskiy commented

2020-03-02 14:23:10 +01:00

Added subscriber: @MikhailRachinskiy

Brecht Van Lommel commented

2020-03-02 14:52:24 +01:00

Added subscriber: @brecht

Brecht Van Lommel commented

2020-03-02 14:52:24 +01:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Brecht Van Lommel commented

2020-03-02 14:52:24 +01:00

Hide in Viewport is not intended to remove it from this list, the object is hidden for display but still part of dependency graph evaluation, like modifiers or collision
Disable in Viewport works for me, it doesn't print any objects here.

* Hide in Viewport is not intended to remove it from this list, the object is hidden for display but still part of dependency graph evaluation, like modifiers or collision * Disable in Viewport works for me, it doesn't print any objects here.

Mikhail Rachinskiy commented

2020-03-02 14:58:44 +01:00

But then why individually hidden objects are missing from depsgraph? Shouldn't there be a universally expected behaviour?

Currently behaviour is confusing: objects hidden individually are out of depsgraph, objects hidden by collection are appearing in depsgraph.

But then why individually hidden objects are missing from depsgraph? Shouldn't there be a universally expected behaviour? Currently behaviour is confusing: objects hidden individually are out of depsgraph, objects hidden by collection are appearing in depsgraph.

Brecht Van Lommel commented

2020-03-02 15:02:54 +01:00

Changed status from 'Needs User Info' to: 'Needs Triage'

Mikhail Rachinskiy commented

2020-03-02 15:04:00 +01:00

Sorry I must have confused something while testing the issue, Collection Disable in Viewport option is in fact hides objects from depsgraph. The issue is only with Hide in Viewport option.
I edited task description to reflect this.

Sorry I must have confused something while testing the issue, Collection Disable in Viewport option is in fact hides objects from depsgraph. The issue is only with Hide in Viewport option. I edited task description to reflect this.

Philipp Oeser commented

2020-03-03 10:25:19 +01:00

Added subscribers: @dfelinto, @lichtwerk

Philipp Oeser commented

2020-03-03 10:25:19 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2020-03-03 10:25:19 +01:00

In #74368#883580, @brecht wrote:

Hide in Viewport is not intended to remove it from this list, the object is hidden for display but still part of dependency graph evaluation, like modifiers or collision

I would also argue that Hide in Viewport should not remove the object from the depsgraph.object_instances list.
The bug here seems to be the fact that if you hide an object individually [not the collection], the object gets indeed removed from the list (which is wrong I think)

CC @dfelinto

> In #74368#883580, @brecht wrote: > * Hide in Viewport is not intended to remove it from this list, the object is hidden for display but still part of dependency graph evaluation, like modifiers or collision I would also argue that `Hide in Viewport` should not remove the object from the `depsgraph.object_instances` list. The bug here seems to be the fact that if you hide an object **individually** [not the collection], the object gets indeed removed from the list (which is wrong I think) CC @dfelinto

Mikhail Rachinskiy commented

2020-03-03 10:56:58 +01:00

I would argue that hidden objects should not be present in depsgraph.object_instances.

API documentation for depsgraph.object_instances says the following:

All object instances to display or render

Hidden objects (with Hide in Viewport) are not displayed, therefore they should not be in the list.
Just how it was in 2.80.

I would argue that hidden objects should not be present in `depsgraph.object_instances`. API documentation for [depsgraph.object_instances ](https://docs.blender.org/api/blender2.8/bpy.types.Depsgraph.html#bpy.types.Depsgraph.object_instances) says the following: > All object instances to display or render Hidden objects (with Hide in Viewport) are not displayed, therefore they should not be in the list. Just how it was in 2.80.

Dalai Felinto commented

2020-03-04 15:40:23 +01:00

Changed status from 'Confirmed' to: 'Needs User Info'

Dalai Felinto commented

2020-03-04 15:40:23 +01:00

The difference between collections and objects is that you can view a collection that is disabled for viewports in a viewport, when using "Local Collections" option. The same is not true for objects.

@MikhailRachinskiy what are you trying to do exactly with the Python API?

The difference between collections and objects is that you can view a collection that is disabled for viewports in a viewport, when using "Local Collections" option. The same is not true for objects. @MikhailRachinskiy what are you trying to do exactly with the Python API?

Mikhail Rachinskiy commented

2020-03-05 03:46:41 +01:00

I am trying to get a list of all visible objects and their instances.

I can use ob.visible_get() to know if object is visible to the user, but instances do not have this method, I cannot check their visibility.
With current system instances that are hidden to the user would still appear in this list.

I am trying to get a list of all visible objects and their instances. I can use `ob.visible_get()` to know if object is visible to the user, but instances do not have this method, I cannot check their visibility. With current system instances that are hidden to the user would still appear in this list.

Brecht Van Lommel commented

2020-03-05 18:54:17 +01:00

Changed status from 'Needs User Info' to: 'Confirmed'

Brecht Van Lommel commented

2020-03-05 18:54:17 +01:00

I agree it would be better if the collections and objects behaved consistent here, also just to make it easier to write add-ons.

I wouldn't consider it a bug, but a known issue that would be good to address.

I agree it would be better if the collections and objects behaved consistent here, also just to make it easier to write add-ons. I wouldn't consider it a bug, but a known issue that would be good to address.

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

depsgraph.object_instances does not respect collection visibility #74368