Select Circle doesn't apply changes to radius while running back to active tool #74374

New Issue

Vyacheslav Kobozev · 2020-03-02T19:41:59+01:00

2020-03-02 19:41:59 +01:00

System Information
Operating system: Windows-7-6.1.7601-SP1 64 Bits
Graphics card: GeForce GTX 660 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 442.19

Blender Version
Broken: version: 2.83 (sub 5), branch: master, commit date: 2020-03-01 21:35, hash: eaf0528749
Worked: (optional)

Short description of error
If i change radius with LMB+MScroll, it resets to initial after LMB release
2020-03-02_21-20-49.mp4
If it is by design, I cant find hotkeys to change circle radius permanently. I am trying to replace C-selection with this tool in my pipeline because it allow to rotate around object. For me mass selection looks like this: take big brush, select big mass, change brush to smaller one, correct selection, zoom in and manually select/deselect certain faces/points. So I dont see the point to have temporary radius for 1 stroke.

I asked few skillfull guys. They still use C-selection, because it keep it`s radius.

**System Information** Operating system: Windows-7-6.1.7601-SP1 64 Bits Graphics card: GeForce GTX 660 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 442.19 **Blender Version** Broken: version: 2.83 (sub 5), branch: master, commit date: 2020-03-01 21:35, hash: `eaf0528749` Worked: (optional) **Short description of error** If i change radius with LMB+MScroll, it resets to initial after LMB release [2020-03-02_21-20-49.mp4](https://archive.blender.org/developer/F8383884/2020-03-02_21-20-49.mp4) If it is by design, I can`t find hotkeys to change circle radius permanently. I am trying to replace C-selection with this tool in my pipeline because it allow to rotate around object. For me mass selection looks like this: take big brush, select big mass, change brush to smaller one, correct selection, zoom in and manually select/deselect certain faces/points. So I don`t see the point to have temporary radius for 1 stroke. I asked few skillfull guys. They still use C-selection, because it keep it`s radius.

Vyacheslav Kobozev commented

2020-03-02 19:41:59 +01:00

Added subscriber: @Vyach

Philipp Oeser commented

2020-03-03 13:26:56 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2020-03-03 13:26:56 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2020-03-03 13:26:56 +01:00

Can confirm.
Changing the radius with {key LMB} down will set the radius (but apparently for the "old-style" operator {key C} -- not for the tool).
Invoking Circle Select again will have that radius indeed, but this is not propagated to the tool properly or is mixed up somehow.... will check code here...

Can confirm. Changing the radius with {key LMB} down will set the radius (but apparently for the "old-style" operator {key C} -- not for the tool). Invoking `Circle Select` again will have that radius indeed, but this is not propagated to the tool properly or is mixed up somehow.... will check code here...

Philipp Oeser commented

2020-03-03 14:12:48 +01:00

Added subscribers: @JulianEisel, @ideasman42

Philipp Oeser commented

2020-03-03 14:12:48 +01:00

So after some digging, I am still unsure why this doesnt ripple through to the tool properties:

in WM_gesture_circle_modal, this is done for the operator: RNA_int_set(op->ptr, "radius", rect->xmax)
what we are seeing in the Interface for the Circle Select tool is props = tool.operator_properties("view3d.select_circle"), layout.prop(props, "radius")

Maybe UI / tool experts know more?
CC @JulianEisel
CC @ideasman42

So after some digging, I am still unsure why this doesnt ripple through to the tool properties: - in `WM_gesture_circle_modal`, this is done for the operator: `RNA_int_set(op->ptr, "radius", rect->xmax)` - what we are seeing in the Interface for the Circle Select tool is `props = tool.operator_properties("view3d.select_circle"), layout.prop(props, "radius")` Maybe UI / tool experts know more? CC @JulianEisel CC @ideasman42

Campbell Barton commented

2020-03-04 02:16:19 +01:00

Currently the design assumes either the operator is used directly (C-Key), or the tool is used (and the user doesn't mouse-wheel while LMB dragging).

To solve this properly with the current design, we need a way for the circle selection gesture to write values back to the tool settings.

A simple workaround could be to store the selection radius as a tool-setting instead of separating the settings, however that has the down size that two operators which both happen to use the circle gesture will also share a radius.

A short term workaround could be to disable resizing entirely when used as a tool P1279.

Currently the design assumes either the operator is used directly (C-Key), or the tool is used *(and the user doesn't mouse-wheel while LMB dragging).* To solve this properly with the current design, we need a way for the circle selection gesture to write values back to the tool settings. A simple workaround could be to store the selection radius as a tool-setting instead of separating the settings, however that has the down size that two operators which both happen to use the circle gesture will also share a radius. A short term workaround could be to disable resizing entirely when used as a tool [P1279](https://archive.blender.org/developer/P1279.txt).

Campbell Barton changed title from ~~Select Circle resets radius, if I change it with scroll. Bug or bad design?~~ to Select Circle doesn't apply changes to radius while running back to active tool

2020-03-04 02:26:33 +01:00

William Reynish commented

2020-03-04 10:16:24 +01:00

Added subscriber: @WilliamReynish

William Reynish commented

2020-03-04 10:16:24 +01:00

@ideasman42 having them always be the same doesn't seem like a downside to me. I think that's what users would expect in fact.

Vyacheslav Kobozev commented

2020-03-04 10:29:45 +01:00

For old tool there is one bad thing: you can`t rotate camera and select
But some good thing: simpliest hotkeys and gestures. {key MMB-Scroll} for size, {key MMB} for exclude, {key C} to call and {key RMB} to cancel.
If i use tool, all this buttons are occupied for viewport rotation, context menu etc..

So for quick selection I would prefer old way ({key C}, select, {key RMB}). for complex selection, I will use new tool, because I need to rotate character or complex shape, and do not want to use {key C}+{key RMB} each time i want to turn camera.

For old tool there is one bad thing: you can`t rotate camera and select But some good thing: simpliest hotkeys and gestures. {key MMB-Scroll} for size, {key MMB} for exclude, {key C} to call and {key RMB} to cancel. If i use tool, all this buttons are occupied for viewport rotation, context menu etc.. So for quick selection I would prefer old way ({key C}, select, {key RMB}). for complex selection, I will use new tool, because I need to rotate character or complex shape, and do not want to use {key C}+{key RMB} each time i want to turn camera.

Campbell Barton commented

2020-03-04 10:37:17 +01:00

In #74374#884861, @WilliamReynish wrote:
@ideasman42 having them always be the same doesn't seem like a downside to me. I think that's what users would expect in fact.

It would be shared between editors (UV, f-curve... 3D view etc). Which could be annoying.

> In #74374#884861, @WilliamReynish wrote: > @ideasman42 having them always be the same doesn't seem like a downside to me. I think that's what users would expect in fact. It would be shared between editors (UV, f-curve... 3D view etc). Which could be annoying.

William Reynish commented

2020-03-04 12:54:28 +01:00

@ideasman42 could it not be per editor type?

Campbell Barton commented

2020-03-09 03:15:21 +01:00

We could, however this can backfire in the future, and doesn't solve the general case - giving us manual work every time we run into these situations.

Also, the circle is intended to be a generic gesture (similar to box-gesture or line-gesture), we happen to use it for selection at the moment, but hard coding to a certain size will back-fire if you want to use it elsewhere.

This exposes a limit in how tool-settings or last-operator-settings don't always work well together.

I think it's worth looking into having an automatic way to write back operator properties into the tool-settings, so we don't have to do things like manually adding arrays of radius-values-per-space-type every time we run into this kind of problem.

Edit, this patch resolves the issue by writing properties back to the tool when activated by the tool keymap however I'd rather not commit this just now without more testing P1285.

We could, however this can backfire in the future, and doesn't solve the general case - giving us manual work every time we run into these situations. Also, the circle is intended to be a generic gesture (similar to box-gesture or line-gesture), we happen to use it for selection at the moment, but hard coding to a certain size will back-fire if you want to use it elsewhere. This exposes a limit in how tool-settings or last-operator-settings don't always work well together. I think it's worth looking into having an automatic way to write back operator properties into the tool-settings, so we don't have to do things like manually adding arrays of radius-values-per-space-type every time we run into this kind of problem. ----- Edit, this patch resolves the issue by writing properties back to the tool when activated by the tool keymap however I'd rather not commit this just now without more testing [P1285](https://archive.blender.org/developer/P1285.txt).

Tomasz Kaye commented

2020-07-02 12:16:19 +02:00

Added subscriber: @info-27

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Select Circle doesn't apply changes to radius while running back to active tool #74374