Video Sequence Time slider ignores handle offset constraints (leading to crash) #74603

New Issue

Campbell Barton · 2020-03-10T04:23:26+01:00

Campbell Barton commented

2020-03-10 04:23:26 +01:00

When transforming video sequencer handles, there are limits beyond which you cannot move them which is enforced by the transform code.

The Slip operator ignores these constraints - allowing the strip content to be dragged with offsets that are outside the strip start/end.

To redo:

Start a new Video Sequencer Template
Add a new scene
Add that scene as a sequence strip.
Make sure the current frame is in around the middle of the sequence strip.
Drag the "Strip Offset Start" to 500 (notice the strip shows as flipped).
Delete the strip.
Blender Crashes

Attached asan crash output:

asan_error.txt

When transforming video sequencer handles, there are limits beyond which you cannot move them which is enforced by the transform code. The Slip operator ignores these constraints - allowing the strip content to be dragged with offsets that are outside the strip start/end. To redo: - Start a new Video Sequencer Template - Add a new scene - Add that scene as a sequence strip. - Make sure the current frame is in around the middle of the sequence strip. - Drag the "Strip Offset Start" to 500 *(notice the strip shows as flipped)*. - Delete the strip. - Blender Crashes Attached asan crash output: [asan_error.txt](https://archive.blender.org/developer/F8398436/asan_error.txt)

Campbell Barton commented

2020-03-10 04:23:26 +01:00

Added subscriber: @ideasman42

tintwotin commented

2020-03-10 06:36:46 +01:00

Added subscriber: @tintwotin

tintwotin commented

2020-03-10 06:36:46 +01:00

Most of the values in the Time panel needs to be clamped: https://developer.blender.org/T65723

The slide operator seems like an isolated operator build outside the handle selection system. It should be recoded to work inside the transforming system in this industry standart way, where two selected handles inside the strip will slip it:

As opposed to selection the two handles outside of the strip to slide it, which actually works now(except when there are no adjacent handles):

Most of the values in the Time panel needs to be clamped: https://developer.blender.org/T65723 The slide operator seems like an isolated operator build outside the handle selection system. It should be recoded to work inside the transforming system in this industry standart way, where two selected handles inside the strip will **slip** it: ![image.png](https://archive.blender.org/developer/F8398516/image.png) As opposed to selection the two handles outside of the strip to **slide** it, which actually works now(except when there are no adjacent handles): ![slide.gif](https://archive.blender.org/developer/F8398521/slide.gif)

Richard Antalik commented

2020-03-10 09:24:53 +01:00

Added subscriber: @iss