Object deleted when deleting a modifier #74779

Closed
opened 2020-03-15 13:20:33 +01:00 by Christophe Schollhammer · 11 comments

System Information
Operating system:windows10
Graphics card:gtx1070

Blender Version
Broken:blender-2.83-a210b8297f5a-windows64
Worked: 2.82

Short description of error
Object deleted when deleting a modifier or any subobject (material, modifier...)

Exact steps for others to reproduce the error
Based on the default startup or an attached .blend file (as simple as possible).

add a cube
add a multires modifier
select multires modifier, you can see that the object (don't know if it's the right tem, the root object with the orange triangle containing the hierarchy) is selected too (not in 2.82)
delete the modifier
the object is deleted also

**System Information** Operating system:windows10 Graphics card:gtx1070 **Blender Version** Broken:blender-2.83-a210b8297f5a-windows64 Worked: 2.82 **Short description of error** Object deleted when deleting a modifier or any subobject (material, modifier...) **Exact steps for others to reproduce the error** Based on the default startup or an attached .blend file (as simple as possible). add a cube add a multires modifier select multires modifier, you can see that the object (don't know if it's the right tem, the root object with the orange triangle containing the hierarchy) is selected too (not in 2.82) delete the modifier the object is deleted also

Added subscriber: @cscholl

Added subscriber: @cscholl
Member
Added subscribers: @WilliamReynish, @natecraddock, @dfelinto, @lichtwerk
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

I assume this is about the Outliner.

select multires modifier, you can see that the object (don't know if it's the right tem, the root object with the orange triangle containing the hierarchy) is selected too (not in 2.82)

I assume this is done via the Outliner Context Menu?

This has changed in fe7528ee91
From that commit on, you cannot spawn a Context Menu of type Outliner Data Operation on a modifier anymore, instead a Context Menu of type Object is spawned -- always.
In that respect, this is actually doing the right thing, you are deleting the object, not a modifier (deleting a modifier has never been possible afaict -- not even with the Outliner Data Operation context mennu, there is no Delete in that menu...)

Worked: 2.82

Doubt that (see above), deleting a modifier has never been possible afaict -- not even with the Outliner Data Operation context mennu, there is no Delete in that menu...

So, I dont think it was intended to disallow the context menu of type Outliner Data Operation on modifiers in fe7528ee91, @Zachman? shouldnt that still be possible? [even though it has limited use for modifiers tbh.]
CC @dfelinto, @WilliamReynish

If we stick to only having the Object context menu for modifiers in the outliner, then this should not be considered a bug and could be closed I guess...
Will at least confirm for now, other classification is up to others (since it is not obvious from that commit if these side-effects were intended)

I assume this is about the Outliner. > select multires modifier, you can see that the object (don't know if it's the right tem, the root object with the orange triangle containing the hierarchy) is selected too (not in 2.82) I assume this is done via the Outliner Context Menu? This has changed in fe7528ee91 From that commit on, you cannot spawn a Context Menu of type `Outliner Data Operation` on a modifier anymore, instead a Context Menu of type `Object` is spawned -- always. In that respect, this is actually doing the right thing, you are deleting the **object**, not a **modifier** (deleting a modifier has never been possible afaict -- not even with the `Outliner Data Operation` context mennu, there is no `Delete` in that menu...) > Worked: 2.82 Doubt that (see above), deleting a modifier has never been possible afaict -- not even with the `Outliner Data Operation` context mennu, there is no `Delete` in that menu... So, I dont think it was intended to disallow the context menu of type `Outliner Data Operation` on modifiers in fe7528ee91, @Zachman? shouldnt that still be possible? [even though it has limited use for modifiers tbh.] CC @dfelinto, @WilliamReynish If we stick to only having the `Object` context menu for modifiers in the outliner, then this should not be considered a bug and could be closed I guess... Will at least confirm for now, other classification is up to others (since it is not obvious from that commit if these side-effects were intended)

We should address this, in the same way that deleting both objects and collections should be possible using the same shortcut and form the context menu.

I believe @Zachman is looking into this. However, it's not a bug, but simply a todo.

We should address this, in the same way that deleting both objects and collections should be possible using the same shortcut and form the context menu. I believe @Zachman is looking into this. However, it's not a bug, but simply a todo.

Yes in the outliner
I have done a short video to show you the difference of behaviour between the two versions
https://drive.google.com/open?id=13VWGvUdAzjmI0nEgarq-ZL6-uYY2r2ve

Yes in the outliner I have done a short video to show you the difference of behaviour between the two versions https://drive.google.com/open?id=13VWGvUdAzjmI0nEgarq-ZL6-uYY2r2ve

2.83 more accurately shows you what is selected. If you select a modifier, the parent object is also selected. The issue is not that, but the fact that you can't delete modifiers or constraints from the Outliner, which is clearly a todo, not really a bug.

2.83 more accurately shows you what is selected. If you select a modifier, the parent object is also selected. The issue is not that, but the fact that you can't delete modifiers or constraints from the Outliner, which is clearly a todo, not really a bug.

Ok I see what you mean
In fact you can delete a modifier, you have to left clic with ctrl on the object so the object get deselected but not the modifier and then with a right clic access to delete in the context menu but it's far from being straightforward

Ok I see what you mean In fact you can delete a modifier, you have to left clic with ctrl on the object so the object get deselected but not the modifier and then with a right clic access to delete in the context menu but it's far from being straightforward

As @WilliamReynish said, 2.83 is more accurate by actually selecting datablock parents (i.e. selecting a modifier in the outliner will show the parent object as selected). The issue with this is that the context menu has a few different Delete entries and they are dependent on the selection. If only modifiers (or other datablocks) are selected, the delete operator for those datablocks is shown in the context menu. But if any objects are part of the outliner selection, the Object Delete menu entry is shown.

So yes, deleting modifiers worked in 2.82 and does not yet in 2.83. The context menu will need to be fixed to be more contextually aware of which datatype was the target of the right-click.

As @WilliamReynish said, 2.83 is more accurate by actually selecting datablock parents (i.e. selecting a modifier in the outliner will show the parent object as selected). The issue with this is that the context menu has a few different `Delete` entries and they are dependent on the selection. If only modifiers (or other datablocks) are selected, the delete operator for those datablocks is shown in the context menu. But if any objects are part of the outliner selection, the `Object Delete` menu entry is shown. So yes, deleting modifiers worked in 2.82 and does not *yet* in 2.83. The context menu will need to be fixed to be more contextually aware of which datatype was the target of the right-click.
Philipp Oeser removed the
Interest
User Interface
label 2023-02-10 09:24:44 +01:00

Hello @lichtwerk, it looks like the issue is fixed in the latest main branch, this can be closed.

Hello @lichtwerk, it looks like the issue is fixed in the latest main branch, this can be closed.
Member

yep, will close then.

yep, will close then.
Blender Bot added
Status
Archived
and removed
Status
Confirmed
labels 2023-03-01 09:38:02 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#74779
No description provided.