BLI_assert failed when deleting object in debug build (only) #75279
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
7 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#75279
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
System Information
Operating system: Darwin-19.3.0-x86_64-i386-64bit 64 Bits
Graphics card: Intel(R) Iris(TM) Graphics 6100 Intel Inc. 4.1 INTEL-14.4.23
Blender Version
Broken: version: 2.83 (sub 11) Debug build, branch: master, commit date: 01-04-2020, hash:
rBUnknown
Worked: Release build works fine.
Short description of error
Exact steps for others to reproduce the error
See attached blend file.
test (1).blend
Added subscriber: @monique
Added subscriber: @lichtwerk
Changed status from 'Needs Triage' to: 'Confirmed'
Can confirm.
Added subscriber: @iss
Changed status from 'Confirmed' to: 'Needs User Info'
can you clarify hash to test with? Can not reproduce with
25b2b6724d19
Changed status from 'Needs User Info' to: 'Confirmed'
I am getting this on
25b2b6724d
.System Information
Operating system: Linux-5.5.8-200.fc31.x86_64-x86_64-with-fedora-31-Thirty_One 64 Bits
Graphics card: GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.64
Broken: version: 2.83 (sub 11), branch: master, commit date: 2020-04-01 14:21, hash:
25b2b6724d
Added subscriber: @ankitm
lite also works fine.
v2.82a has this issue too.
Added subscriber: @mont29
I think the problem is rather with ID management code (remapping ID pointers to NULL here) not properly tagging IDs for updates... Investigating.
Added subscriber: @Sergey
Hrmm, in fact ID deletion code itself seems to be fine, issue only happens with Object deletion operator (from 3DView), since deleted object is used by a custom property it is not actually deleted, just removed from any collection.
@Sergey I could use your expertise on depsgraph/CoW here (crash is actually a use-after-free memory on CoW object, see ASAN bactrace below).
Question is, could CoW system be somehow 'broken' in case where an object is not in any collection (hence not in any ViewLayer of any scene), but is still present in Main and referenced by some other data-blocks (through custom properties here)?
From that backtrace my (uneducated) guess would be that CoW frees the object copy not in any scene anymore, even though that object remain accessible through other CoWs IDProperties.
All the referenced IDs are to be explicitly pulled into the dependency graph, otherwise you are ruining integrity of the scene.
As an example see usage of
modifiers_foreachIDLink
indeg_builder_nodes.cc
anddeg_builder_relations.cc
. Quick fix would be to do similar thing for ID properties.However, this is actually an open topic of what to do with IDs referenced from ID properties. It might be wasteful to just pull all the referenced IDs, but it could be fragile if we don't do it.
So the way to go would be to add something similar
build_animdata()
(build_idproperties()
?), to be called by all builders (nodes and relations) for all IDProps cases? Including those from bones/poses, nodes, and sequencer...The other solution would be to completely ignore those IDProps ID pointers, and add a parameter to libquery to skip those, so that depsgraph can fully ignore them? But that would likely cause issues in any code dealing with CoW datablocks I guess...
Yep. Sounds about right. Baiscally somethinng like
This is plausible solution as well. Isn't great from integrity point of view, but better from ease/performance/memory points of view.
What are the IDs in ID properties are used for? Is there any common usage?
I have no typical usecase in mind, afaik those are mostly used by thirdparty tools/addons… They should never be used by core code itself, and they cannot be directly defined by users, so they should almost never be required within depsgraph context. But... they can be used by e.g. advanced python drivers or other fancy features, so I don’t think we can rule them out of evaluation completely? Though maybe that is not actually a valid argument, my knowledge of current driver evaluation process is rather rusty.
Added subscriber: @dr.sybren
Then how about we take the consistency approach and pull IDs from custom properties into the graph?
If you can point or provide some function to iterate via IDs used by IDProperties them me or @dr.sybren can easily do depsgraph changes.
This issue was referenced by
37e08e526c
Well, this is easy enough that I can at least propose a patch ;)
Changed status from 'Confirmed' to: 'Resolved'