Fluid: Outflow geometry is not working #75758

New Issue

Yusuke Yasui · 2020-04-15T20:25:12+02:00

Yusuke Yasui commented

2020-04-15 20:25:12 +02:00

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce RTX 2080 with Max-Q Design/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 441.66

Blender Version
Broken: version: 2.83 (sub 13), branch: master, commit date: 2020-04-13 17:13, hash: ad317a5ffd
Worked: 2.82

Short description of error
The outflow geometry does not seem to be working.

I quickly debug the code (commit 2ec6eca518).
Then, I have found, if I comment out the following two lines in fluid.c, it seems to work.

line 2748

    /* Optimization: Static liquid flow objects don't need emission computation after first

   * frame.
   * TODO (sebbas): Also do not use static mode if initial velocities are enabled. */

   if (mfs->type == FLUID_FLOW_TYPE_LIQUID && is_static && !is_first_frame && !use_velocity) {
     // continue; <- comment out
    }

line 2944

      /* Skip static liquid objects that are not on the first frame.

     * TODO (sebbas): Also do not use static mode if initial velocities are enabled. */

      if (is_static && !use_velocity) {
        // continue; <- comment out
      }

Exact steps for others to reproduce the error
Open the attached file and bake fluid. You will see that the outflow geometry is ignored.
outflow_test2.blend

I hope this helps. Please let me know anytime if you have questions.

Thank you!
Yusuke

**System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: GeForce RTX 2080 with Max-Q Design/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 441.66 **Blender Version** Broken: version: 2.83 (sub 13), branch: master, commit date: 2020-04-13 17:13, hash: `ad317a5ffd` Worked: 2.82 **Short description of error** The outflow geometry does not seem to be working. ![bug.png](https://archive.blender.org/developer/F8475513/bug.png) ![expected.png](https://archive.blender.org/developer/F8475515/expected.png) I quickly debug the code (commit 2ec6eca518ef85115cbb7b6465f296d2fd422f5e). Then, I have found, if I comment out the following two lines in fluid.c, it seems to work. line 2748 ``` /* Optimization: Static liquid flow objects don't need emission computation after first ``` * frame. * TODO (sebbas): Also do not use static mode if initial velocities are enabled. */ ``` if (mfs->type == FLUID_FLOW_TYPE_LIQUID && is_static && !is_first_frame && !use_velocity) { // continue; <- comment out } ``` line 2944 ``` /* Skip static liquid objects that are not on the first frame. ``` * TODO (sebbas): Also do not use static mode if initial velocities are enabled. */ ``` if (is_static && !use_velocity) { // continue; <- comment out } ``` **Exact steps for others to reproduce the error** Open the attached file and bake fluid. You will see that the outflow geometry is ignored. [outflow_test2.blend](https://archive.blender.org/developer/F8475511/outflow_test2.blend) I hope this helps. Please let me know anytime if you have questions. Thank you! Yusuke

Yusuke Yasui commented

2020-04-15 20:25:12 +02:00

Added subscriber: @yiusay

Yusuke Yasui commented

2020-04-15 20:58:48 +02:00

Maybe the problem is phiout_in is initialized to PHI_MAX every frame (line 2879) while the value is set only in the first frame when the outflow object is static and does not have velocity.

Ankit Meel commented

2020-04-16 10:08:36 +02:00

Added subscriber: @ankitm

Ankit Meel commented

2020-04-16 10:08:36 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Ankit Meel commented

2020-04-16 10:08:36 +02:00

You may please ready a patch & submit it at https://developer.blender.org/differential/diff/create/

Philipp Oeser commented

2020-04-16 10:25:50 +02:00

Added subscribers: @sebbas, @lichtwerk

Philipp Oeser commented

2020-04-16 10:25:50 +02:00

CC @sebbas

Philipp Oeser commented

2020-04-16 10:30:31 +02:00

Dare setting this to High...

Yusuke Yasui commented

2020-04-16 15:09:47 +02:00

Submitted a quick fix here.
https://developer.blender.org/D7451

Although I am new to blender development, I believe this fix should not be a fundamental solution for this problem since accelerating fluid baking by taking advantage of the static objects seems to be one of the features in 2.83 release. But I am happy if this helps in some way.

Submitted a quick fix here. https://developer.blender.org/D7451 Although I am new to blender development, I believe this fix should not be a fundamental solution for this problem since accelerating fluid baking by taking advantage of the static objects seems to be one of the features in 2.83 release. But I am happy if this helps in some way.

Nathan Letwory commented

2020-04-20 22:27:36 +02:00

Added subscriber: @jesterking

Sebastián Barschkis was assigned by Nathan Letwory

2020-04-20 22:27:36 +02:00

Nathan Letwory commented

2020-04-20 22:27:36 +02:00

@sebbas is this not something that could have been fixed for 2.83 too?

Sebastián Barschkis commented

2020-04-20 23:47:36 +02:00

@jesterking Yes you're right, that's a fix for 2.83 too. When I committed this yesterday I noticed that the fluid commits from last Wednesday weren't in the release branch and so I just quickly committed to master.

WIll cherry-pick them later, there shouldn't be any problems with tags, right?

@jesterking Yes you're right, that's a fix for 2.83 too. When I committed this yesterday I noticed that the fluid commits from last Wednesday weren't in the release branch and so I just quickly committed to master. WIll cherry-pick them later, there shouldn't be any problems with tags, right?

Nathan Letwory commented

2020-04-20 23:59:21 +02:00

@sebbas should be fine. Just remember to merge back into master and handle the conflict. I will retag the issues for you.

Sebastián Barschkis commented

2020-04-22 19:10:21 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Sebastián Barschkis closed this issue

2020-04-22 19:10:21 +02:00

Sebastián Barschkis commented

2020-04-22 19:10:21 +02:00

This should be fixed starting cdc399a055. So closing this report.

Also, since the obstacle in the example file is not a closed mesh, I recommend enabling the "Is Planar" option.

This should be fixed starting cdc399a05537. So closing this report. Also, since the obstacle in the example file is not a closed mesh, I recommend enabling the "Is Planar" option.

Yusuke Yasui commented

2020-04-22 20:26:07 +02:00

@Sebastián Barschkis (sebbas)
It is working now. Thank you!

@Sebastián Barschkis (sebbas) It is working now. Thank you!

Sebastián Barschkis commented

2020-04-23 00:13:56 +02:00

That's good to know, thanks for reporting!

Thomas Dinges added this to the 2.83 LTS milestone 2023-02-08 16:38:05 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fluid: Outflow geometry is not working #75758