USD test fails in debug mode #76355

New Issue

Ray molenkamp · 2020-05-03T00:57:14+02:00

Ray molenkamp commented

2020-05-03 00:57:14 +02:00

System Information
Operating system: Windows
Graphics card: N/A

Blender Version
Broken: Current master
Worked: who knows

106: Test command: K:\BlenderGit\build_windows_Full_x64_vc16_Debug\bin\tests\Debug\usd_test.exe "--test-assets-dir" "K:/BlenderGit/blender/../lib/tests"
106: Environment variables:
106:  LSAN_OPTIONS=exitcode=0
106: Test timeout computed to be: 10000000
106: [==========] Running 5 tests from 2 test cases.
106: [----------] Global test environment set-up.
106: [----------] 1 test from USDHierarchyIteratorTest
106: [ RUN      ] USDHierarchyIteratorTest.ExportHierarchyTest
106: [       OK ] USDHierarchyIteratorTest.ExportHierarchyTest (58 ms)
106: [----------] 1 test from USDHierarchyIteratorTest (58 ms total)
106:
106: [----------] 4 tests from HierarchyContextOrderTest
106: [ RUN      ] HierarchyContextOrderTest.ObjectPointerTest
106: [       OK ] HierarchyContextOrderTest.ObjectPointerTest (0 ms)
106: [ RUN      ] HierarchyContextOrderTest.DuplicatorPointerTest
106: [       OK ] HierarchyContextOrderTest.DuplicatorPointerTest (0 ms)
106: [ RUN      ] HierarchyContextOrderTest.ExportParentTest
106: K:\BlenderGit\blender\tests\gtests\usd\hierarchy_context_order_test.cc(79): error:       Expected: true
106: To be equal to: ctx_a < ctx_b
106:       Which is: false
106: [  FAILED  ] HierarchyContextOrderTest.ExportParentTest (1 ms)
106: [ RUN      ] HierarchyContextOrderTest.TransitiveTest
106: [       OK ] HierarchyContextOrderTest.TransitiveTest (0 ms)
106: [----------] 4 tests from HierarchyContextOrderTest (1 ms total)
106:
106: [----------] Global test environment tear-down
106: [==========] 5 tests from 2 test cases ran. (149 ms total)
106: [  PASSED  ] 4 tests.
106: [  FAILED  ] 1 test, listed below:
106: [  FAILED  ] HierarchyContextOrderTest.ExportParentTest
106:
106:  1 FAILED TEST
106/106 Test #106: usd_test ............................***Failed    1.92 sec

Exact steps for others to reproduce the error

build in debug mode
run the test

**System Information** Operating system: Windows Graphics card: N/A **Blender Version** Broken: Current master Worked: who knows ``` 106: Test command: K:\BlenderGit\build_windows_Full_x64_vc16_Debug\bin\tests\Debug\usd_test.exe "--test-assets-dir" "K:/BlenderGit/blender/../lib/tests" 106: Environment variables: 106: LSAN_OPTIONS=exitcode=0 106: Test timeout computed to be: 10000000 106: [==========] Running 5 tests from 2 test cases. 106: [----------] Global test environment set-up. 106: [----------] 1 test from USDHierarchyIteratorTest 106: [ RUN ] USDHierarchyIteratorTest.ExportHierarchyTest 106: [ OK ] USDHierarchyIteratorTest.ExportHierarchyTest (58 ms) 106: [----------] 1 test from USDHierarchyIteratorTest (58 ms total) 106: 106: [----------] 4 tests from HierarchyContextOrderTest 106: [ RUN ] HierarchyContextOrderTest.ObjectPointerTest 106: [ OK ] HierarchyContextOrderTest.ObjectPointerTest (0 ms) 106: [ RUN ] HierarchyContextOrderTest.DuplicatorPointerTest 106: [ OK ] HierarchyContextOrderTest.DuplicatorPointerTest (0 ms) 106: [ RUN ] HierarchyContextOrderTest.ExportParentTest 106: K:\BlenderGit\blender\tests\gtests\usd\hierarchy_context_order_test.cc(79): error: Expected: true 106: To be equal to: ctx_a < ctx_b 106: Which is: false 106: [ FAILED ] HierarchyContextOrderTest.ExportParentTest (1 ms) 106: [ RUN ] HierarchyContextOrderTest.TransitiveTest 106: [ OK ] HierarchyContextOrderTest.TransitiveTest (0 ms) 106: [----------] 4 tests from HierarchyContextOrderTest (1 ms total) 106: 106: [----------] Global test environment tear-down 106: [==========] 5 tests from 2 test cases ran. (149 ms total) 106: [ PASSED ] 4 tests. 106: [ FAILED ] 1 test, listed below: 106: [ FAILED ] HierarchyContextOrderTest.ExportParentTest 106: 106: 1 FAILED TEST 106/106 Test #106: usd_test ............................***Failed 1.92 sec ``` **Exact steps for others to reproduce the error** - build in debug mode - run the test

Ray molenkamp commented

2020-05-03 00:57:14 +02:00

Added subscriber: @LazyDodo

Ray molenkamp commented

2020-05-03 00:57:41 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Sybren A. Stüvel was assigned by Ray molenkamp

2020-05-03 00:57:41 +02:00

Ray molenkamp commented

2020-05-03 00:57:41 +02:00

Mind taking a peek here?

Sergey Sharybin commented

2020-05-04 15:27:09 +02:00

Added subscriber: @Sergey

Sergey Sharybin commented

2020-05-04 15:27:09 +02:00

@dr.sybren some related notes:

Use EXPECT_LT to check a < b.
Use EXPECT_FALSE to expect an expression to be false.
Use EXPECT_TRUE to expect an expression to be truth.

@dr.sybren some related notes: - Use `EXPECT_LT` to check `a < b`. - Use `EXPECT_FALSE` to expect an expression to be false. - Use `EXPECT_TRUE` to expect an expression to be truth.

Sybren A. Stüvel commented

2020-05-04 16:22:53 +02:00

@Sergey thanks, that's been addressed in b3553c0961.

@LazyDodo here in Linux it all works fine, both in debug and release mode. All the operator<() function under test is doing is some pointer comparisons. Do you know of anything that could cause the debug build in Windows to behave differently in that regard? In other words, would you expect the pointer value of static_cast<Object *>(POINTER_FROM_INT(327)) to become different from 327?

Maybe could you give this a try?

diff --git a/tests/gtests/usd/hierarchy_context_order_test.cc b/tests/gtests/usd/hierarchy_context_order_test.cc
index a6a8aa16766..c3f86eebe44 100644
--- a/tests/gtests/usd/hierarchy_context_order_test.cc
+++ b/tests/gtests/usd/hierarchy_context_order_test.cc
@@ -34,6 +34,12 @@ static Object *fake_pointer(int value)
   return static_cast<Object *>(POINTER_FROM_INT(value));
 }
 
+TEST_F(HierarchyContextOrderTest, FakePointerTest)
+{
+  Object *fake_object_ptr = fake_pointer(327);
+  EXPECT_EQ(327, (intptr_t)fake_object_ptr);
+}
+
 TEST_F(HierarchyContextOrderTest, ObjectPointerTest)
 {
   HierarchyContext ctx_a;

@Sergey thanks, that's been addressed in b3553c0961. @LazyDodo here in Linux it all works fine, both in debug and release mode. All the `operator<()` function under test is doing is some pointer comparisons. Do you know of anything that could cause the debug build in Windows to behave differently in that regard? In other words, would you expect the pointer value of `static_cast<Object *>(POINTER_FROM_INT(327))` to become different from 327? Maybe could you give this a try? ``` diff --git a/tests/gtests/usd/hierarchy_context_order_test.cc b/tests/gtests/usd/hierarchy_context_order_test.cc index a6a8aa16766..c3f86eebe44 100644 --- a/tests/gtests/usd/hierarchy_context_order_test.cc +++ b/tests/gtests/usd/hierarchy_context_order_test.cc @@ -34,6 +34,12 @@ static Object *fake_pointer(int value) return static_cast<Object *>(POINTER_FROM_INT(value)); } +TEST_F(HierarchyContextOrderTest, FakePointerTest) +{ + Object *fake_object_ptr = fake_pointer(327); + EXPECT_EQ(327, (intptr_t)fake_object_ptr); +} + TEST_F(HierarchyContextOrderTest, ObjectPointerTest) { HierarchyContext ctx_a; ```

blender-admin commented

2020-05-04 18:03:19 +02:00

This issue was referenced by 0c8b872188

This issue was referenced by 0c8b872188a3b413e08e84d1661bc1fd482359c1

Sybren A. Stüvel commented

2020-05-04 18:08:19 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Sybren A. Stüvel closed this issue

2020-05-04 18:08:19 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

USD test fails in debug mode #76355