Crash after initialization custom node group tree #76591

New Issue

Sergey · 2020-05-09T19:59:52+02:00

Sergey commented

2020-05-09 19:59:52 +02:00

System Information
Operating system: Windows-7-6.1.7601-SP1 64 Bits
Graphics card: GeForce GTX 660 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 416.34

Blender Version
Broken: version: 2.83 (sub 13), branch: master, commit date: 2020-04-21 17:59, hash: 13e3a1c532

Short description of error
I'm experimenting with creating custom node tree groups in custom node tree and I faced with this crash.

Exact steps for others to reproduce the error

run first script (left in file)
run second script (right)
open custom node tree editor
select Tree
crash
untitled5.blend

**System Information** Operating system: Windows-7-6.1.7601-SP1 64 Bits Graphics card: GeForce GTX 660 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 416.34 **Blender Version** Broken: version: 2.83 (sub 13), branch: master, commit date: 2020-04-21 17:59, hash: `13e3a1c532` **Short description of error** I'm experimenting with creating custom node tree groups in custom node tree and I faced with this crash. **Exact steps for others to reproduce the error** - run first script (left in file) - run second script (right) - open `custom node tree` editor - select `Tree` - crash [untitled5.blend](https://archive.blender.org/developer/F8523462/untitled5.blend)

Sergey commented

2020-05-09 19:59:52 +02:00

Added subscriber: @randum

Ankit Meel commented

2020-05-10 07:48:15 +02:00

Added subscriber: @ankitm

Ankit Meel commented

2020-05-10 07:48:15 +02:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Ankit Meel commented

2020-05-10 07:48:15 +02:00

BLI_assert failed: source/blender/blenloader/intern/writefile.c:1008, write_node_socket_default_value(), at '0'
get this while running script 2, so it seems you're doing somehtng wrong, which later gives a problem ?
file on diffusion

`BLI_assert failed: source/blender/blenloader/intern/writefile.c:1008, write_node_socket_default_value(), at '0'` get this while running script 2, so it seems you're doing somehtng wrong, which later gives a problem ? [file on diffusion](https://developer.blender.org/diffusion/B/browse/master/source/blender/blenloader/intern/writefile.c$970)

Sergey commented

2020-05-10 08:07:25 +02:00

I'm definitely doing something wrong. There is no any guide about how to create custom node group in custom tree. So I'm experimenting and I'm trying find the way.

What information do you need?

I'm definitely doing something wrong. There is no any guide about how to create custom node group in custom tree. So I'm experimenting and I'm trying find the way. What information do you need?

Ankit Meel commented

2020-05-10 08:57:40 +02:00

Changed status from 'Needs User Info' to: 'Needs Triage'

Germano Cavalcante commented

2020-05-11 22:12:52 +02:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2020-05-11 22:12:52 +02:00

Although there is likely to be an error in the script, it should not crash but rather display an error message.
I think it is a bug, but I will wait for a second opinion.

Although there is likely to be an error in the script, it should not crash but rather display an error message. I think it is a bug, but I will wait for a second opinion.

Himanshi Kalra commented

2020-05-14 22:49:32 +02:00

Added subscriber: @Calra

Himanshi Kalra commented

2020-05-14 22:49:32 +02:00

@randum Yes it crashes, I can't fully point out why, imo you are not in the right context, but here is a short description of what you might be doing "wrong".

created 2 custom editors, apart from Custom node tree, there is Test Group Tree just below the custom one.
trying to link nodes from 2 different editors, one is Tree from Custom node tree and the other one is TreeGroup from the other panel Test Group tree does it work with normal nodes ?, I am not that proficient.

And it won't crash if you are in Test Group tree and have selected Tree Group and the input socket is created in the right under Nodes section

@randum Yes it crashes, I can't fully point out why, imo you are not in the right context, but here is a short description of what you might be doing "wrong". * created 2 custom editors, apart from `Custom node tree`, there is `Test Group Tree` just below the custom one. * trying to link nodes from 2 different editors, one is `Tree` from `Custom node tree` and the other one is `TreeGroup` from the other panel `Test Group tree` does it work with normal nodes ?, I am not that proficient. And it **won't** crash if you are in `Test Group tree` and have selected `Tree Group` and the input socket is created in the right under `Nodes` section

Sergey commented

2020-05-15 06:38:45 +02:00

@Calra What I'm actually doing is reproduce group nodes in coustome tree editor. For this I have use two different node trees. One normal for tree editor and another for group node. Also I'm using special node which is dedicated for creating node groups. It has node_tree attribute for nested tree unlike of other normal nodes. Also I'm adding special sockets for nested node tree. Nested node tree can have sockets. So:

I can change pool method for group tree so it will always return False and it will crash anyway.
I'm not linking any nodes at all.

It looks like that the problem is in NodeSocketInterface. Everything work until i'm adding the socket ot nested node tree what is cause the crash.

@Calra What I'm actually doing is reproduce group nodes in coustome tree editor. For this I have use two different node trees. One normal for tree editor and another for group node. Also I'm using special node which is dedicated for creating node groups. It has `node_tree` attribute for nested tree unlike of other normal nodes. Also I'm adding special sockets for nested node tree. Nested node tree can have sockets. So: - I can change `pool` method for group tree so it will always return False and it will crash anyway. - I'm not linking any nodes at all. It looks like that the problem is in `NodeSocketInterface`. Everything work until i'm adding the socket ot nested node tree what is cause the crash.

Germano Cavalcante commented

2020-05-15 13:56:42 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Jacques Lucke commented

2020-09-14 15:34:03 +02:00

Added subscribers: @ideasman42, @JacquesLucke

Jacques Lucke commented

2020-09-14 15:34:03 +02:00

This might solve one of the issues:

diff --git a/source/blender/makesrna/intern/rna_nodetree.c b/source/blender/makesrna/intern/rna_nodetree.c
index 3237f33835e..f3cc40215f3 100644
--- a/source/blender/makesrna/intern/rna_nodetree.c
+++ b/source/blender/makesrna/intern/rna_nodetree.c
@@ -2306,6 +2306,7 @@ static StructRNA *rna_NodeSocket_register(Main *UNUSED(bmain),
 
   /* setup dummy socket & socket type to store static properties in */
   memset(&dummyst, 0, sizeof(bNodeSocketType));
+  dummyst.type = -1;
 
   memset(&dummysock, 0, sizeof(bNodeSocket));
   dummysock.typeinfo = &dummyst;
@@ -2629,6 +2630,7 @@ static StructRNA *rna_NodeSocketInterface_register(Main *UNUSED(bmain),
 
   /* setup dummy socket & socket type to store static properties in */
   memset(&dummyst, 0, sizeof(bNodeSocketType));
+  dummyst.type = -1;
 
   memset(&dummysock, 0, sizeof(bNodeSocket));
   dummysock.typeinfo = &dummyst;

But I'm not even sure if we support what you want to do at all.
@ideasman42, in the current implementation, should custom node tree types be able to use node groups the same way internal tree types use them? If no, then this report is probably not a bug, but more a feature request.

@randum, do you know of any addon that adds new a new node tree type that uses normal node groups?

This might solve one of the issues: ``` diff --git a/source/blender/makesrna/intern/rna_nodetree.c b/source/blender/makesrna/intern/rna_nodetree.c index 3237f33835e..f3cc40215f3 100644 --- a/source/blender/makesrna/intern/rna_nodetree.c +++ b/source/blender/makesrna/intern/rna_nodetree.c @@ -2306,6 +2306,7 @@ static StructRNA *rna_NodeSocket_register(Main *UNUSED(bmain), /* setup dummy socket & socket type to store static properties in */ memset(&dummyst, 0, sizeof(bNodeSocketType)); + dummyst.type = -1; memset(&dummysock, 0, sizeof(bNodeSocket)); dummysock.typeinfo = &dummyst; @@ -2629,6 +2630,7 @@ static StructRNA *rna_NodeSocketInterface_register(Main *UNUSED(bmain), /* setup dummy socket & socket type to store static properties in */ memset(&dummyst, 0, sizeof(bNodeSocketType)); + dummyst.type = -1; memset(&dummysock, 0, sizeof(bNodeSocket)); dummysock.typeinfo = &dummyst; ``` But I'm not even sure if we support what you want to do at all. @ideasman42, in the current implementation, should custom node tree types be able to use node groups the same way internal tree types use them? If no, then this report is probably not a bug, but more a feature request. @randum, do you know of any addon that adds new a new node tree type that uses normal node groups?

Sergey commented

2020-09-14 20:00:29 +02:00

Yes, node groups are used in Sorcar since june. There is interesting discussion here:

https://github.com/nortikin/sverchok/issues/3319

It looks like that all what should be done is to create MyGroupNode(NodeCustomGroup). Group input and group output nodes can be created from standard Blender classes in nested tree. Creating new sockets in MyGroupNode and in socket interface panel after connecting to input and output group nodes is happening automatically.

So probably I should not been trying to create custom input group node and custom node socket interface as I did in the example.

Yes, `node groups` are used in Sorcar since june. There is interesting discussion here: https://github.com/nortikin/sverchok/issues/3319 It looks like that all what should be done is to create `MyGroupNode(NodeCustomGroup)`. `Group input` and `group output` nodes can be created from standard Blender classes in nested tree. Creating new sockets in `MyGroupNode` and in socket interface panel after connecting to input and output group nodes is happening automatically. So probably I should not been trying to create custom `input group` node and custom `node socket interface` as I did in the example.

Jacques Lucke commented

2020-09-15 11:34:55 +02:00

In #76591#1015567, @randum wrote:
Yes, node groups are used in Sorcar since june. There is interesting discussion here:

https://github.com/nortikin/sverchok/issues/3319

It looks like that all what should be done is to create MyGroupNode(NodeCustomGroup). Group input and group output nodes can be created from standard Blender classes in nested tree. Creating new sockets in MyGroupNode and in socket interface panel after connecting to input and output group nodes is happening automatically.

So probably I should not been trying to create custom input group node and custom node socket interface as I did in the example.

When you follow their example, can you get it working? If yes, it would be nice if you could simplify the example as much as possible. It might be a good idea to add this as an example to the api docs.

> In #76591#1015567, @randum wrote: > Yes, `node groups` are used in Sorcar since june. There is interesting discussion here: > > https://github.com/nortikin/sverchok/issues/3319 > > It looks like that all what should be done is to create `MyGroupNode(NodeCustomGroup)`. `Group input` and `group output` nodes can be created from standard Blender classes in nested tree. Creating new sockets in `MyGroupNode` and in socket interface panel after connecting to input and output group nodes is happening automatically. > > So probably I should not been trying to create custom `input group` node and custom `node socket interface` as I did in the example. When you follow their example, can you get it working? If yes, it would be nice if you could simplify the example as much as possible. It might be a good idea to add this as an example to the api docs.

Sergey commented

2020-09-15 13:23:09 +02:00

Yes it looks working. I will try to make an example.

Sergey commented

2020-09-15 19:47:06 +02:00

I have made an example. It creates new tree editor with available group node. The node has UI for creating node groups (sub trees). There is some solution in the script which is not best I guess. I left comments there.

node_group.py

I have made an example. It creates new tree editor with available group node. The node has UI for creating node groups (sub trees). There is some solution in the script which is not best I guess. I left comments there. ![2020-09-15_21-39-28.png](https://archive.blender.org/developer/F8885261/2020-09-15_21-39-28.png) [node_group.py](https://archive.blender.org/developer/F8885258/node_group.py)

Jacques Lucke commented

2020-09-16 10:02:22 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Jacques Lucke closed this issue

2020-09-16 10:02:22 +02:00

Jacques Lucke self-assigned this 2020-09-16 10:02:22 +02:00

Jacques Lucke commented

2020-09-16 10:02:22 +02:00

Thanks, since this is working now, I'll close this report. I created blender/documentation#80827, so that I don't forget about this topic.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crash after initialization custom node group tree #76591