blender/blender
blender/blender
195
618
Fork 961
Code Issues 6.4k Pull Requests 1.1k Projects 22 Wiki Activity

Dope Sheet Editor, crash right clicking on a Mask channel #76669

New Issue
Closed
opened 2020-05-12 07:15:02 +02:00 by Philippe · 14 comments
Philippe commented 2020-05-12 07:15:02 +02:00
Copy Link

System Information
Operating system: Windows 10
Graphics card: Quadro M1000M/PCIe/SSE2

Blender Version
Broken:
2.83 (sub 15), branch: master, commit date: 2020-05-11 19:18, hash: 8956e9e5f6
2.90 (sub 1), branch: master, commit date: 2020-05-12 04:41, hash: 859eee7e15

Worked:
2.82 (sub 7), branch: master, commit date: 2020-03-12 05:06, hash: 375c7dc4ca

Short description of error
EXCEPTION_ACCESS_VIOLATION trying to open menu for a Mask channel in Dope Sheet Editor

Exact steps for others to reproduce the error

  1. Open Blender
  2. Open Image Editor
  3. Add a mask
  4. Open Dope Sheet Editor
  5. Display Mask
  6. Right click on channel
    #76669.blend
**System Information** Operating system: Windows 10 Graphics card: Quadro M1000M/PCIe/SSE2 **Blender Version** Broken: 2.83 (sub 15), branch: master, commit date: 2020-05-11 19:18, hash: 8956e9e5f6c0 2.90 (sub 1), branch: master, commit date: 2020-05-12 04:41, hash: 859eee7e1510 Worked: 2.82 (sub 7), branch: master, commit date: 2020-03-12 05:06, hash: 375c7dc4caf4 **Short description of error** EXCEPTION_ACCESS_VIOLATION trying to open menu for a Mask channel in Dope Sheet Editor **Exact steps for others to reproduce the error** 1. Open Blender 2. Open Image Editor 3. Add a mask 4. Open Dope Sheet Editor 5. Display Mask 6. Right click on channel [#76669.blend](https://archive.blender.org/developer/F8530038/T76669.blend)
Philippe commented 2020-05-12 07:15:02 +02:00
Author
Copy Link

Added subscriber: @Greatoak

Added subscriber: @Greatoak
Richard Antalik commented 2020-05-12 10:14:06 +02:00
Member
Copy Link

Added subscriber: @iss

Added subscriber: @iss
Richard Antalik commented 2020-05-12 10:14:06 +02:00
Member
Copy Link

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Richard Antalik commented 2020-05-12 10:14:06 +02:00
Member
Copy Link

Exception thrown: read access violation.
strip was 0xFFFFFFFFFFFFFF3F.

>	blender.exe!ed_screen_context(const bContext * C, const unsigned char * member, bContextDataResult * result) Line 520	C

 	blender.exe!ctx_data_get(bContext * C, const unsigned char * member, bContextDataResult * result) Line 343	C
 	blender.exe!CTX_data_get(const bContext * C, const unsigned char * member, PointerRNA * r_ptr, ListBase * r_lb, short * r_type) Line 500	C
 	blender.exe!pyrna_struct_getattro(BPy_StructRNA * self, _object * pyname) Line 4283	C
 	[External Code]	
 	blender.exe!bpy_class_call(bContext * C, PointerRNA * ptr, FunctionRNA * func, ParameterList * parms) Line 8505	C
 	blender.exe!menu_draw(const bContext * C, Menu * menu) Line 849	C
 	blender.exe!UI_menutype_draw(bContext * C, MenuType * mt, uiLayout * layout) Line 5549	C
 	blender.exe!UI_popup_menu_invoke(bContext * C, const unsigned char * idname, ReportList * reports) Line 573	C
 	blender.exe!wm_call_menu_exec(bContext * C, wmOperator * op) Line 1835	C
 	blender.exe!wm_operator_invoke(bContext * C, wmOperatorType * ot, wmEvent * event, PointerRNA * properties, ReportList * reports, const bool poll_only, bool use_last_properties) Line 1282	C
 	blender.exe!wm_handler_operator_call(bContext * C, ListBase * handlers, wmEventHandler * handler_base, wmEvent * event, PointerRNA * properties, const unsigned char * kmi_idname) Line 2102	C
 	blender.exe!wm_handlers_do_keymap_with_keymap_handler(bContext * C, wmEvent * event, ListBase * handlers, wmEventHandler_Keymap * handler, wmKeyMap * keymap, const bool do_debug_handler) Line 2412	C
 	blender.exe!wm_handlers_do_intern(bContext * C, wmEvent * event, ListBase * handlers) Line 2707	C
 	blender.exe!wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Line 2834	C
 	blender.exe!wm_event_do_handlers(bContext * C) Line 3321	C
 	blender.exe!WM_main(bContext * C) Line 453	C
 	blender.exe!main(int argc, const unsigned char * * UNUSED_argv_c) Line 530	C
 	[External Code]
Exception thrown: read access violation. strip was 0xFFFFFFFFFFFFFF3F. ``` > blender.exe!ed_screen_context(const bContext * C, const unsigned char * member, bContextDataResult * result) Line 520 C blender.exe!ctx_data_get(bContext * C, const unsigned char * member, bContextDataResult * result) Line 343 C blender.exe!CTX_data_get(const bContext * C, const unsigned char * member, PointerRNA * r_ptr, ListBase * r_lb, short * r_type) Line 500 C blender.exe!pyrna_struct_getattro(BPy_StructRNA * self, _object * pyname) Line 4283 C [External Code] blender.exe!bpy_class_call(bContext * C, PointerRNA * ptr, FunctionRNA * func, ParameterList * parms) Line 8505 C blender.exe!menu_draw(const bContext * C, Menu * menu) Line 849 C blender.exe!UI_menutype_draw(bContext * C, MenuType * mt, uiLayout * layout) Line 5549 C blender.exe!UI_popup_menu_invoke(bContext * C, const unsigned char * idname, ReportList * reports) Line 573 C blender.exe!wm_call_menu_exec(bContext * C, wmOperator * op) Line 1835 C blender.exe!wm_operator_invoke(bContext * C, wmOperatorType * ot, wmEvent * event, PointerRNA * properties, ReportList * reports, const bool poll_only, bool use_last_properties) Line 1282 C blender.exe!wm_handler_operator_call(bContext * C, ListBase * handlers, wmEventHandler * handler_base, wmEvent * event, PointerRNA * properties, const unsigned char * kmi_idname) Line 2102 C blender.exe!wm_handlers_do_keymap_with_keymap_handler(bContext * C, wmEvent * event, ListBase * handlers, wmEventHandler_Keymap * handler, wmKeyMap * keymap, const bool do_debug_handler) Line 2412 C blender.exe!wm_handlers_do_intern(bContext * C, wmEvent * event, ListBase * handlers) Line 2707 C blender.exe!wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Line 2834 C blender.exe!wm_event_do_handlers(bContext * C) Line 3321 C blender.exe!WM_main(bContext * C) Line 453 C blender.exe!main(int argc, const unsigned char * * UNUSED_argv_c) Line 530 C [External Code] ```
Philipp Oeser commented 2020-05-12 11:45:03 +02:00
Member
Copy Link

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Philipp Oeser self-assigned this 2020-05-12 11:45:03 +02:00
Philipp Oeser commented 2020-05-12 11:45:03 +02:00
Member
Copy Link

Caused by f8c4f5e308, will check...

Caused by f8c4f5e308, will check...
Philipp Oeser commented 2020-05-12 13:11:55 +02:00
Member
Copy Link

Added subscriber: @dr.sybren

Added subscriber: @dr.sybren
Philipp Oeser commented 2020-05-12 13:11:55 +02:00
Member
Copy Link

Issue seems to be polling extrapolation_type in DOPESHEET_MT_channel_context_menu with a copy of the Context

if bpy.ops.graph.extrapolation_type.poll(context.copy()):

Getting a copy of the context then fails on the selected_nla_strips context member [I assume this is problematic in conjunction with ANIM_animdata_get_context].
But before digging deeper: @dr.sybren: do you remember why it was necessary to poll with a copy of the context? (you added this in a52f6d7a31)
I mean it is probably better to make sure this is also fine with using a copy of the context -- but I could not spot issues just doing it like:

P1384: T76669_snippet



diff --git a/release/scripts/startup/bl_ui/space_dopesheet.py b/release/scripts/startup/bl_ui/space_dopesheet.py
index 3f8c41e4f21..33f183e16d5 100644
--- a/release/scripts/startup/bl_ui/space_dopesheet.py
+++ b/release/scripts/startup/bl_ui/space_dopesheet.py
@@ -644,7 +644,7 @@ class DOPESHEET_MT_channel_context_menu(Menu):
         layout.separator()
         layout.operator("anim.channels_editable_toggle")
 
-        if bpy.ops.graph.extrapolation_type.poll(context.copy()):
+        if bpy.ops.graph.extrapolation_type.poll():
             operator = "graph.extrapolation_type"
         else:
             operator = "action.extrapolation_type"

(note it might also be good to check the ANIM_animdata_context_getdata -> actedit_get_context -> SACTCONT_MASK case [since this only seems to be problematic for masks...])

Issue seems to be polling `extrapolation_type` in `DOPESHEET_MT_channel_context_menu` with a **copy of the Context** ``` if bpy.ops.graph.extrapolation_type.poll(context.copy()): ``` Getting a copy of the context then fails on the `selected_nla_strips` context member [I assume this is problematic in conjunction with `ANIM_animdata_get_context`]. But before digging deeper: @dr.sybren: do you remember why it was necessary to poll with a **copy of the context**? (you added this in a52f6d7a31) I mean it is probably better to make sure this is also fine with using a **copy of the context** -- but I could not spot issues just doing it like: [P1384: T76669_snippet](https://archive.blender.org/developer/P1384.txt) ``` diff --git a/release/scripts/startup/bl_ui/space_dopesheet.py b/release/scripts/startup/bl_ui/space_dopesheet.py index 3f8c41e4f21..33f183e16d5 100644 --- a/release/scripts/startup/bl_ui/space_dopesheet.py +++ b/release/scripts/startup/bl_ui/space_dopesheet.py @@ -644,7 +644,7 @@ class DOPESHEET_MT_channel_context_menu(Menu): layout.separator() layout.operator("anim.channels_editable_toggle") - if bpy.ops.graph.extrapolation_type.poll(context.copy()): + if bpy.ops.graph.extrapolation_type.poll(): operator = "graph.extrapolation_type" else: operator = "action.extrapolation_type" ``` (note it might also be good to check the `ANIM_animdata_context_getdata` -> `actedit_get_context` -> `SACTCONT_MASK` case [since this only seems to be problematic for masks...])
Philipp Oeser commented 2020-05-12 13:17:25 +02:00
Member
Copy Link

Added subscriber: @JacquesLucke

Added subscriber: @JacquesLucke
Philipp Oeser commented 2020-05-12 13:17:25 +02:00
Member
Copy Link

@JacquesLucke : here is a report for your D7702: Fix selected_nla_strips when used in other editors, checking this as well...

@JacquesLucke : here is a report for your [D7702: Fix selected_nla_strips when used in other editors](https://archive.blender.org/developer/D7702), checking this as well...
Sybren A. Stüvel commented 2020-05-12 13:27:56 +02:00
Member
Copy Link

The problem with the poll() function calls is that it doesn't expect a bpy.types.Context object, but rather a dictionary. context.copy() returns its own values, but then as such a dictionary. If the context-less call uses the correct context (I wasn't sure about that at the time, and I'm still not sure whether it would use the current or the global context) removing context.copy() is fine by me.

The problem with the `poll()` function calls is that it doesn't expect a `bpy.types.Context` object, but rather a dictionary. `context.copy()` returns its own values, but then as such a dictionary. If the context-less call uses the correct context (I wasn't sure about that at the time, and I'm still not sure whether it would use the current or the global context) removing `context.copy()` is fine by me.
blender-admin commented 2020-05-12 14:47:21 +02:00
Copy Link

This issue was referenced by e5bb02aaa4

This issue was referenced by e5bb02aaa41615d9f48376e53e5cf7569e1bc1d2
Jacques Lucke commented 2020-05-12 14:48:21 +02:00
Member
Copy Link

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Philipp Oeser commented 2020-05-12 15:35:10 +02:00
Member
Copy Link

Ok, lets call this done for now...
Still a bit confused why this wasnt an issue with the original context, but fix seems good and safe, thx everyone involved!

Ok, lets call this done for now... Still a bit confused why this wasnt an issue with the original context, but fix seems good and safe, thx everyone involved!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Asset datablocks, libraries, browser and shelf
Interest
Audio
Interest
Automated Testing
Interest
BlendFile
Interest
Blender Asset Bundle
Interest
Code Documentation
Code comments, Python/RNA API descriptions
Interest
Collada
Interest
Compatibility
Backward and forward compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
FBX
FBX I/O related topics
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline & IO
Interest
Platforms & Builds
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
USD
Interest
UV Editing
Interest
Undo
Interest
User Interface
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Wayland windowing on Unix
Interest
Workbench
Interest
glTF
glTF format I/O topics
Interest: X11
Xorg/X11 windowing
Legacy
Asset Browser Project
Archived
Legacy
Blender 2.8 Project
Archived
Legacy
Milestone 1: Basic, Local Asset Browser
Archived
Legacy
OpenGL Error
Archived
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Related to security, see policy: https://developer.blender.org/docs/handbook/bug_reports/vulnerability_reports/
Module
Animation & Rigging
Module
Asset System
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline & IO
Module
Platforms & Builds
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
Windows
Platform
macOS
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Archived
Type
Report
Archived
Type
To Do
No Label
Interest
Animation & Rigging
Module
Animation & Rigging
Severity
Normal
Status
Resolved
Type
Report
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Hoshinova James-McCarthy-4 Sebastian-Herholz casey-bianco-davis gandalf3 Blendify Aaron Carlisle quantimoney Aditya Y Jeppu Alaska Alaska angavrilov Alexander Gavrilov frogstomp Aleš Jelovčan amelief Amélie Fondevilla elubie Andrea Weikert Andy_Goralczyk Andy Goralczyk ankitm Ankit Meel Anthony-Roberts Anthony Roberts antoniov Antonio Vazquez aras_p Aras Pranckevicius Arnd Arnd Marijnissen bartvdbraak Bart van der Braak mont29 Bastien Montagne blender-bot Blender Bot bnagirniak Bogdan Nagirniak BClark Brad Clark brecht Brecht Van Lommel BrianSavery Brian Savery (AMD) ideasman42 Campbell Barton CharlesWardlaw Charles Wardlaw CharlieJolly Charlie Jolly Chris_Blackbourn Chris Blackbourn lateasusual Chris Clyne (Lateasusual) ChrisLend Christoph Lendenfeld HobbesOS Cian Jinks fclem Clément Foucault cmbasnett Colin Basnett Kdaf Colin Marmond dfelinto Dalai Felinto pioverfour Damien Picard DanielBystedt Daniel Bystedt pepe-school-land Daniel Martinez Lara zanqdo Daniel Salazar Mets Demeter Dzadik erik85 Erik Abrahamsson EAW Evan Wilson filedescriptor Falk David fsiddi Francesco Siddi GaiaClary Gaia Clary DagerD Georgiy Markelov mano-wii Germano Cavalcante zazizizou Habib Gahbiche HooglyBoogly Hans Goudey Harley Harley Acheson weasel Henrik D. Hjalti Hjalti Hjálmarsson howardt Howard Trickey nirved-1 Hristo Gueorguiev mod_moder Iliya Katushenock brita Inês Almeida JacquesLucke Jacques Lucke Jason-Fielder Jason Fielder JasonSchleifer Jason schleifer Jebbly Jeffrey Liu Jeroen-Bakker Jeroen Bakker deadpin Jesse Yurkovich neXyon Joerg Mueller eliphaz John Kiril Swenson guitargeek Johnny Matthews Brainzman Jonas Holzman JoniMercado Jonatan Mercado JorgeBernalMartinez Jorge Bernal JosephEagar Joseph Eagar JoshuaLeung Joshua Leung Bone-Studio Juan Gea jpbouza-4 Juan Pablo Bouza JulianEisel Julian Eisel JulienDuroure Julien Duroure JulienKaspar Julien Kaspar kevindietrich Kévin Dietrich lone_noel Leon Schittek LucianoMunoz Luciano Muñoz Sessarego LukasStockner Lukas Stockner LukasTonne Lukas Tönne LunaRood Luna Rood MaiLavelle Mai Lavelle EosFoxx Marion Stalke Baardaap Martijn Versteegh scorpion81 Martin Felke mendio Matias Mendiola Matt-McLin Matt McLin MetinSeven Metin Seven wave Michael B Johnson Michael-Jones Michael Jones (Apple) makowalski Michael Kowalski pragma37 Miguel Pozo nrupsis Nate Rupsis jesterking Nathan Letwory nathanvegdahl Nathan Vegdahl PrototypeNM1 Nicholas Rishel nickberckley Nika Kutsniashvili Sirgienko Nikita Sirgienko OmarEmaraDev Omar Emara pablovazquez Pablo Vazquez PaoloAcampora Paolo Acampora PascalSchon Pascal Schön pmoursnv Patrick Mours muxed-reality Peter Kim lichtwerk Philipp Oeser P2design Pierrick PICAUT PratikPB2123 Pratik Borhade Limarest Ramil Roosileht farsthary Raul Fernandez Hernandez LazyDodo Ray molenkamp iss Richard Antalik rjg Robert Guetzkow salipour Sahar A. Kashi Sayak-Biswas Sayak Biswas Sean-Kim Sean Kim sherholz Sebastian Herholz sebastian_k Sebastian Koenig ZedDB Sebastian Parborg sebbas Sebastián Barschkis Sergey Sergey Sharybin IRIEShinsuke Shinsuke Irie sidd017 Siddhartha Jejurkar SietseB Sietse Brouwer SimonThommes Simon Thommes SonnyCampbell_Unity Sonny Campbell Stefan_Werner Stefan Werner Lockal Sv. Lockal dr.sybren Sybren A. Stüvel ThomasDinges Thomas Dinges Ton Ton Roosendaal BassamKurdali Ursula kurdali Vasyl-Pidhirskyi Vasyl Pidhirskyi WannesMalfait Wannes Malfait wbmoss_dev Wayde Moss weizhen Weizhen Huang leesonw William Leeson xavierh Xavier Hallade jenkm Yevgeny Makarov ChengduLittleA YimingWu gfxcoder jon denning
No Assignees Philipp Oeser
6 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: blender/blender#76669
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?