Autosave is postponed by 10 seconds when a modal operator is running #77825

New Issue

Tasha Upchurch · 2020-06-13T02:51:29+02:00

Tasha Upchurch commented

2020-06-13 02:51:29 +02:00

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: AMD Radeon RX 5700 XT ATI Technologies Inc. 4.5.13596 Core Profile Context 20.5.1 27.20.1017.1011

Blender Version
Broken: version: 2.83.0, branch: master, commit date: 2020-06-03 14:38, hash: 211b6c29f7
Worked: (newest version of Blender that worked as expected)

Short description of error
Blender does not auto save every minute as directed..
From the user's point of view this appears to be a random interval.

save test.blend

Exact steps for others to reproduce the error

change preference of time interval of save to 1 minute.
save preferences
close blender
reload blender
delete scene
add cube
save file as save test.blend
enter sculpt mode on cube
enable dyno topo
sculpt on cube for 10 minutes
notice that there are not 10 auto saves in the specified directory.
notice that there is only one.

**System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: AMD Radeon RX 5700 XT ATI Technologies Inc. 4.5.13596 Core Profile Context 20.5.1 27.20.1017.1011 **Blender Version** Broken: version: 2.83.0, branch: master, commit date: 2020-06-03 14:38, hash: `211b6c29f7` Worked: (newest version of Blender that worked as expected) **Short description of error** Blender does not auto save every minute as directed.. From the user's point of view this appears to be a random interval. ![image.png](https://archive.blender.org/developer/F8613460/image.png) ![image.png](https://archive.blender.org/developer/F8613462/image.png) [save test.blend](https://archive.blender.org/developer/F8626047/save_test.blend) **Exact steps for others to reproduce the error** - change preference of time interval of save to 1 minute. - save preferences - close blender - reload blender - delete scene - add cube - save file as save test.blend - enter sculpt mode on cube - enable dyno topo - sculpt on cube for 10 minutes - notice that there are not 10 auto saves in the specified directory. - notice that there is only one.

Tasha Upchurch commented

2020-06-13 02:51:29 +02:00

Added subscriber: @TashaSkyUp

Bent Hillerkus commented

2020-06-13 04:34:33 +02:00

Added subscriber: @bent

Germano Cavalcante commented

2020-06-16 00:01:29 +02:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2020-06-16 00:01:29 +02:00

Changed status from 'Needs Triage' to: 'Archived'

Germano Cavalcante closed this issue

2020-06-16 00:01:29 +02:00

Germano Cavalcante self-assigned this 2020-06-16 00:01:29 +02:00

Germano Cavalcante commented

2020-06-16 00:01:29 +02:00

The blender interface needs to update. If blender is minimized, for example, it does not automatically save.
This report does not contain all the requested information, which is required for us to investigate the issue.
It's missing:

Steps to reproduce the bug.

A guideline for making a good bug report can be found at https://wiki.blender.org/wiki/Process/Bug_Reports

The blender interface needs to update. If blender is minimized, for example, it does not automatically save. This report does not contain all the requested information, which is required for us to investigate the issue. It's missing: - Steps to reproduce the bug. A guideline for making a good bug report can be found at https://wiki.blender.org/wiki/Process/Bug_Reports

Germano Cavalcante was unassigned by Tasha Upchurch

2020-06-16 19:33:32 +02:00

Tasha Upchurch self-assigned this 2020-06-16 19:33:32 +02:00

Tasha Upchurch commented

2020-06-16 19:33:32 +02:00

Why would you just assume the bug report is invalid. Rude. I'ts not invalid and now blender is going to be stuck with this bug because someone wanted to get some quick forum points or something.. this place is worse then stack exchange for people who are not part of the "system"

Tasha Upchurch commented

2020-06-16 19:46:58 +02:00

Changed status from 'Archived' to: 'Resolved'

Tasha Upchurch commented

2020-06-16 19:46:58 +02:00

Steps to reproduce:

change preference of time interval of save to 1 minute.
save preferences
close blender
reload blender
delete scene
add cube
save file as save test.blend
enter sculpt mode on cube
enable dyno topo
sculpt on cube for 10 minutes
notice that there are not 10 auto saves in the specified directory.
notice that there is only one.
take a chance and report bug
be rejected

Steps to reproduce: - change preference of time interval of save to 1 minute. - save preferences - close blender - reload blender - delete scene - add cube - save file as save test.blend - enter sculpt mode on cube - enable dyno topo - sculpt on cube for 10 minutes - notice that there are not 10 auto saves in the specified directory. - notice that there is only one. - take a chance and report bug - be rejected

Tasha Upchurch commented

2020-06-16 19:54:44 +02:00

And this system we are on has no way for me to contact you directly so I have no idea if you will notice the changes to the report in order to set it to valid or whatever. Meaning I will have to go through the entire process of reporting the bug again.. This is a bad system.

Robert Guetzkow commented

2020-06-16 19:59:22 +02:00

Added subscriber: @rjg

Robert Guetzkow commented

2020-06-16 19:59:22 +02:00

@TashaSkyUp Closing the bug report as invalid doesn't mean that we don't believe that there is an issue. It was closed because the report was missing steps to reproduce the problem. Without these steps it can be very difficult to identify the source of the issue and develop a patch. Therefore, it is in your own interest to provide all information that are requested in the submission template . Developers only have a limited time to deal with all reports, which is why incomplete ones will be closed.

@TashaSkyUp Closing the bug report as invalid doesn't mean that we don't believe that there is an issue. It was closed because the report was missing steps to reproduce the problem. Without these steps it can be very difficult to identify the source of the issue and develop a patch. Therefore, it is in your own interest to provide all information that are requested in the [submission template ](https://developer.blender.org/maniphest/task/edit/form/1/). Developers only have a limited time to deal with all reports, which is why incomplete ones will be closed.

Robert Guetzkow commented

2020-06-16 19:59:38 +02:00

Changed status from 'Resolved' to: 'Needs Triage'

Robert Guetzkow reopened this issue

2020-06-16 19:59:38 +02:00

Tasha Upchurch was unassigned by Robert Guetzkow

2020-06-16 20:00:28 +02:00

Germano Cavalcante commented

2020-06-16 20:08:41 +02:00

In #77825#955171, @TashaSkyUp wrote:
Why would you just assume the bug report is invalid. Rude. I'ts not invalid and now blender is going to be stuck with this bug because someone wanted to get some quick forum points or something.. this place is worse then stack exchange for people who are not part of the "system"

Sorry for the inconvenience, there are dozens of reports open every day and this one was closed for two reasons:

At first glance it doesn't seem to be a bug (it's normal not to save in exactly 1 minute. And it wouldn't be efficient to autosave without need)
Fits the "Should Close Task Scenarios:" of the Triaging_Playbook

I forgot to add this text in the comment:

Please submit a new report and carefully follow the instructions. Be sure to provide system information, Blender version, the last Blender version which worked, and a .blend file with exact steps to reproduce the problem.

Now looking at the image, I could see that the autosave intervals are less than 1 minute. I'll have a look to see what happens.

> In #77825#955171, @TashaSkyUp wrote: > Why would you just assume the bug report is invalid. Rude. I'ts not invalid and now blender is going to be stuck with this bug because someone wanted to get some quick forum points or something.. this place is worse then stack exchange for people who are not part of the "system" Sorry for the inconvenience, there are dozens of reports open every day and this one was closed for two reasons: - At first glance it doesn't seem to be a bug (it's normal not to save in exactly 1 minute. And it wouldn't be efficient to autosave without need) - Fits the `"Should Close Task Scenarios:"` of the [Triaging_Playbook ](https://wiki.blender.org/wiki/Process/Bug_Reports/Triaging_Playbook) I forgot to add this text in the comment: > Please submit a new report and carefully follow the instructions. Be sure to provide system information, Blender version, the last Blender version which worked, and a .blend file with exact steps to reproduce the problem. Now looking at the image, I could see that the autosave intervals are less than 1 minute. I'll have a look to see what happens.

Germano Cavalcante commented

2020-06-16 20:28:51 +02:00

In #77825#955205, @mano-wii wrote:
Now looking at the image, I could see that the autosave intervals are less than 1 minute. I'll have a look to see what happens.

I mistook hours for minutes. Autosave never runs before a minute apart.

Looking at the code I found this comment:

/* if a modal operator is running, don't autosave, but try again in 10 seconds */

It seems that this decision to wait 10 seconds if a modal operator is being executed, (as when using a brush), is a bad decision.
I'll see if I can improve this, but I still have doubts if this report should be confirmed as a bug.

https://developer.blender.org/diffusion/B/browse/master/source/blender/windowmanager/intern/wm_files.c$1606

> In #77825#955205, @mano-wii wrote: > Now looking at the image, I could see that the autosave intervals are less than 1 minute. I'll have a look to see what happens. I mistook hours for minutes. Autosave never runs before a minute apart. Looking at the code I found this comment: > /* if a modal operator is running, don't autosave, but try again in 10 seconds */ It seems that this decision to wait 10 seconds if a modal operator is being executed, (as when using a brush), is a bad decision. I'll see if I can improve this, but I still have doubts if this report should be confirmed as a bug. https://developer.blender.org/diffusion/B/browse/master/source/blender/windowmanager/intern/wm_files.c$1606

Tasha Upchurch commented

2020-06-16 20:46:04 +02:00

You know what. Your right, saving while sculpting may create a hiccup on most systems and would be an undesirable behavior. I suppose "Auto save while sculpting" could be a feature request.. we can spend hours in sculpt mode... and crash while in it and loose the work.

Germano Cavalcante changed title from ~~Blender does not auto save using the correct interval~~ to Autosave is postponed by 10 seconds when a modal operator is running

2020-06-16 21:14:29 +02:00

Germano Cavalcante commented

2020-06-16 21:14:29 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Germano Cavalcante commented

2020-06-16 21:16:54 +02:00

Added subscriber: @brecht

Germano Cavalcante commented

2020-06-16 21:16:54 +02:00

This behavior was implemented more than 10 years ago in cb8f7fd3

Autosave is postponed by 10 seconds when a modal operator is running, e.g. transform or file browsing.

@brecht, sorry back to this, I can imagine what led to that decision, but in my opinion the ideal thing would be to run the autosave the moment the modal operator concludes.
I investigated the code, maybe we can add a global flag to run the autosave in wm_handler_operator_call, but I don’t know if it’s that so simple.

I think it's quite possible for someone to work on sculpt for an hour in a row to miss all 10 second intervals between modal operators in the meantime.
We could skip the navigation modal at least.

This behavior was implemented more than 10 years ago in cb8f7fd3 > - Autosave is postponed by 10 seconds when a modal operator is running, e.g. transform or file browsing. @brecht, sorry back to this, I can imagine what led to that decision, but in my opinion the ideal thing would be to run the autosave the moment the modal operator concludes. I investigated the code, maybe we can add a global flag to run the autosave in `wm_handler_operator_call`, but I don’t know if it’s that so simple. I think it's quite possible for someone to work on sculpt for an hour in a row to miss all 10 second intervals between modal operators in the meantime. We could skip the navigation modal at least.

Brecht Van Lommel commented

2020-06-16 23:31:29 +02:00

@mano-wii, yes, it would make sense to run auto save right after the last modal operator ends. Or maybe simpler is to temporarily set the timer interval to 10ms or so.

I think it's rather unlikely that you would sculpt an hour and miss all 10s intervals, but we should do better here..

@mano-wii, yes, it would make sense to run auto save right after the last modal operator ends. Or maybe simpler is to temporarily set the timer interval to 10ms or so. I think it's rather unlikely that you would sculpt an hour and miss all 10s intervals, but we should do better here..

blender-admin commented

2020-06-16 23:37:13 +02:00

This issue was referenced by 95ee06d068

This issue was referenced by 95ee06d068a6526ef773e2cb40420c744cf39e1e

Ryan Inch commented

2020-06-17 06:35:38 +02:00

Added subscriber: @Imaginer

Ryan Inch commented

2020-06-17 06:35:38 +02:00

@mano-wii & @brecht Don't know if this is relevant here, but I remember there was a bug or discussion about never ending modal operators and autosave a while back (I think the blenderkit addon uses one).

Brecht Van Lommel commented

2020-06-30 18:12:44 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Brecht Van Lommel closed this issue

2020-06-30 18:12:44 +02:00

Brecht Van Lommel self-assigned this 2020-06-30 18:12:44 +02:00

Albert commented

2020-10-09 16:14:42 +02:00

Added subscriber: @karab44

Albert commented

2020-10-09 16:14:42 +02:00

Hi guys! Any updates on this issue? Not only Blenderkit is facing the problems with autosave in modal mode.

Best Regards!
Albert

Hi guys! Any updates on this issue? Not only Blenderkit is facing the problems with autosave in modal mode. Best Regards! Albert

Dimitar P. commented

2020-12-10 08:40:40 +01:00

Added subscriber: @Dimitar

Dimitar P. commented

2020-12-10 08:40:40 +01:00

I am experiencing this issue with Blenderkit as well. Autosave hangs indefinitely. Seems the only way to allow autosave is to disable blenderkit. At the same time, sometime blenderkit causes Blender to crash but no autosave file to go back to.

Alex Mehler commented

2022-10-11 09:24:48 +02:00

Added subscriber: @Ulf3000

Alex Mehler commented

2022-10-11 09:24:48 +02:00

there are tons of addons which trigger autosave not working, this is a real problem almsot impossible to pin down if you have many addons installed, often its hard to reproduce and just starts not working out of nowwhere ,for example it worked before loading another file but not after , sometimes it works with addon x sometimes it doesnt .

this really need to be fixed before any new features , its so important. it has to be robust and not affected by anything, modals or not.

there are tons of addons which trigger autosave not working, this is a real problem almsot impossible to pin down if you have many addons installed, often its hard to reproduce and just starts not working out of nowwhere ,for example it worked before loading another file but not after , sometimes it works with addon x sometimes it doesnt . this really need to be fixed before any new features , its so important. it has to be robust and not affected by anything, modals or not.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Autosave is postponed by 10 seconds when a modal operator is running #77825