Page MenuHome
Create Task
Maniphest T78534

Overrides: Can't override Python properties
Closed, ResolvedPublicTO DO
Actions

Description

System Information
Operating system: Linux-5.3.0-7629-generic-x86_64-with-debian-buster-sid 64 Bits
Graphics card: GeForce RTX 2080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.44

Blender Version
Broken: version: 2.90.0 Alpha, branch: HEAD, commit date: 2020-07-02 12:26, hash: rBf58f09c9a910

Short description of error
For example, the built-in Bone Selection Sets addon stores some things as python properties:

bpy.types.Object.selection_sets = CollectionProperty(
        type=SelectionSet, ...)
bpy.types.Object.active_selection_set = IntProperty(...)

When linking an armature and making a library override of it, these properties can't be edited and can't be overridden. I tried adding options={'LIBRARY_EDITABLE'} to these property definitions, but it didn't seem to make a difference. I also tried drawing them on the UI directly (as sliders) and storing them in bpy.types.Armature instead of bpy.types.Object, but to no avail.

Exact steps for others to reproduce the error

  • Enable Bone Selection Sets addon

armature_to_override.blend526 KBDownload

  • Link the collection in above file to a new file
  • Make Library Override->Armature
  • See how Selection Sets are grayed out - you can't change the active selection set, and you can't rename any of them.

CC @Bastien Montagne (mont29) Is this supposed to be supported? I couldn't find a todo task, sorry if I'm being blind or dumb.

Revisions and Commits

rB Blender
D8250rBc2304d2f029c Expose override flags to python RNA properties definition.

Related Objects

Event Timeline

Demeter Dzadik (Mets) created this task.Jul 2 2020, 3:10 PM
Demeter Dzadik (Mets) updated the task description. (Show Details)Jul 2 2020, 3:14 PM
RedMser (RedMser) added a subscriber: RedMser (RedMser).Jul 2 2020, 8:41 PM
Germano Cavalcante (mano-wii) changed the task status from Needs Triage to Needs Information from User.EditedJul 3 2020, 7:29 PM
Germano Cavalcante (mano-wii) added a subscriber: Germano Cavalcante (mano-wii).

Well, the tooltip says:

Disabled: Can't edit this property from an override data-block

I'm not familiar with this area, but from what I see, it doesn't look like a bug.
Otherwise the limitation would not be described in the blender itself.
Did I get something wrong?

I suggest using other channels for questions like that: https://wiki.blender.org/wiki/Communication/Contact#User_Feedback_and_Requests

For more information on what is considered a bug, visit: https://wiki.blender.org/wiki/Reference/Not_a_bug

Demeter Dzadik (Mets) added a comment.Jul 4 2020, 2:40 AM

I poked Bastien IRL and from what I understood/from what I remember, he said it's supposed to be working, so I think it might be a bug. But it's possible he misunderstood what I was asking about. *poke poke* @Bastien Montagne (mont29)

If this part of library overrides is still work in progress(an so this is not a bug) then ofc feel free to close this. But, this does mean that we had to go back to using proxies still, which makes us all sad! D:

Bastien Montagne (mont29) changed the subtype of this task from "Report" to "To Do".Jul 4 2020, 1:01 PM
Bastien Montagne (mont29) added a project: Pipeline, Assets & I/O.

This is more a TODO than really a bug, since it was never implemented. But thanks for the report, easier to keep track of this and not forget about it then. ;)

Bastien Montagne (mont29) moved this task from Backlog to Blender 2.90 on the Pipeline, Assets & I/O board.Jul 4 2020, 1:01 PM
Bastien Montagne (mont29) added a comment.Jul 8 2020, 4:52 PM

See D8249: Refactor override code to properly deal with runtime rna properties too. and D8250: Expose override flags to python RNA properties definition.

Bastien Montagne (mont29) edited projects, added BF Blender (2.90); removed BF Blender.Jul 9 2020, 11:58 AM
Bastien Montagne (mont29) closed this task as Resolved by committing rBc2304d2f029c: Expose override flags to python RNA properties definition..Jul 10 2020, 3:50 PM
Bastien Montagne (mont29) claimed this task.
Bastien Montagne (mont29) added a commit: rBc2304d2f029c: Expose override flags to python RNA properties definition..