The Optix denoiser is influencing Open Image Denoiser results even when it's disabled. #78692

Closed
opened 2020-07-07 01:27:44 +02:00 by Gilberto Rodrigues · 8 comments
Contributor

System Information
Operating system: Windows 10
Graphics card: GTX 1060m

Blender Version
Broken: 2.90 alpha (hash: baf124c753)

Short description of error
the Optix denoiser affects the Open Image Denoiser render results even when it's toggle is disabled. So it's only really disabled when the denoising option is set to NLM.
I rendered this scene with using low number of samples, so that the difference is more evident. Please watch the whole video.

2020-07-06 19-54-17.mp4

What strikes me is that for some reason the buggy falsely disabled Optix + OID renders 2X faster than the enabled Optix + OID despite both of the results being very similar. This bug might have an optimization to look on for. I tested with another scene and there is also that 2x render time difference, with the buggy render looking better.

Exact steps for others to reproduce the error
Open or make a blender scene with lots of noise.
change render engine to cycles.
go to the compositing tab and add Open Image Denoise with the correct passes.
put very low number of samples.
Render to see how it should look with only Open Image Denoise.
Now to the render preferences denoising panel and change the render denoiser from NLM to Optix, without enabling it.
Render again. The render will have effect of both Open Image Denoise and OptiX denoising, even though OptiX's toggle is disabled. That's the bug.
Now enable the Optix toggle for render.
Render again, the render result will be the same as the last (OID + OptiX) but the render will be a lot slower than the previous render.

**System Information** Operating system: Windows 10 Graphics card: GTX 1060m **Blender Version** Broken: 2.90 alpha (hash: baf124c753d9) **Short description of error** the Optix denoiser affects the Open Image Denoiser render results even when it's toggle is disabled. So it's only really disabled when the denoising option is set to NLM. I rendered this scene with using low number of samples, so that the difference is more evident. Please watch the whole video. [2020-07-06 19-54-17.mp4](https://archive.blender.org/developer/F8671241/2020-07-06_19-54-17.mp4) What strikes me is that for some reason the buggy falsely disabled Optix + OID renders 2X faster than the enabled Optix + OID despite both of the results being very similar. This bug might have an optimization to look on for. I tested with another scene and there is also that 2x render time difference, with the buggy render looking better. **Exact steps for others to reproduce the error** Open or make a blender scene with lots of noise. change render engine to cycles. go to the compositing tab and add Open Image Denoise with the correct passes. put very low number of samples. Render to see how it should look with only Open Image Denoise. Now to the render preferences denoising panel and change the render denoiser from NLM to Optix, without enabling it. Render again. The render will have effect of both Open Image Denoise and OptiX denoising, even though OptiX's toggle is disabled. That's the bug. Now enable the Optix toggle for render. Render again, the render result will be the same as the last (OID + OptiX) but the render will be a lot slower than the previous render.
Author
Contributor

Added subscriber: @Gilberto.R

Added subscriber: @Gilberto.R
Author
Contributor

Added subscriber: @brecht

Added subscriber: @brecht
Author
Contributor
@brecht @pmoursnv
Author
Contributor

Added subscriber: @pmoursnv

Added subscriber: @pmoursnv

What happens is that Cycles will generate different denoising passes depending on the denoiser. The NLM denoiser requires prefiltered passes, which take longer to compute.

We should find a way to communicate this more clearly.

What happens is that Cycles will generate different denoising passes depending on the denoiser. The NLM denoiser requires prefiltered passes, which take longer to compute. We should find a way to communicate this more clearly.

This issue was referenced by blender/cycles@06ccb29b81

This issue was referenced by blender/cycles@06ccb29b812b9857d64aea8cb19f81b3f77b7ed6

This issue was referenced by 95f0f31279

This issue was referenced by 95f0f312799e10e4a9f5c884f8f20ec76d0ff363

Changed status from 'Needs Triage' to: 'Resolved'

Changed status from 'Needs Triage' to: 'Resolved'
Brecht Van Lommel self-assigned this 2020-07-07 15:14:26 +02:00
Sign in to join this conversation.
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: blender/blender#78692
No description provided.