Control Mesh Only Partially Drawn After Filling a Surface From a Cage of Surface Curves #79580

New Issue

Garry R. Osgood · 2020-08-06T11:53:06+02:00

Garry R. Osgood commented

2020-08-06 11:53:06 +02:00

System Information
Operating system: Linux 5.4.38-gentoo-gwen #1 SMP Wed May 27 04:32:46 EDT 2020 x86_64 Intel(R) Core(TM) i5-3320M CPU @ 2.60GHz GenuineIntel GNU/Linux
Graphics card: Intel Corporation 3rd Gen Core processor Graphics Controller
system-info.txt

Blender Version

First Broken Version (from git bisect): bf8b62e874
- Author: Campbell Barton ideasman42@gmail.com
- Date: Mon Jun 15 15:28:51 2020 +1000
- Title: Fix curve handle color ID display
Last Good Version (from git bisect): 24d77e7db7
- Author: Tobias Heinke
- Date: Sun Jun 14 19:14:26 2020 -0400
- Title: API docs: mathutils leaked markup
Also Broken: Current 2.90 Beta, branch: master, commit date: 2020-08-05 21:36, hash: c5b6b3d82f, type: Release

Looks like the real culprit is 49f59092e7 see my comment #79580#997407?

Known to be good: 2.83.4 Long Term Release

Short description of error
After lofting a set of surface curves, the control mesh is only partially drawn. This is a papercut: proceeding to edit the mesh results in the complete drawing of control meshes.
Exact steps for others to reproduce the error

Add a set of surface curves with the aim of lofting a surface. Ensure the surface curves are joined into a single object
With the object selected, enter into edit mode (TAB) and select the entire cage. See Figure F8751637

Alternatively, open surfacecage.blend and find the object SurfCurve selected, in edit mode, and with all surface curves in the cage selected.
surfacecage.blend
Press {key F} to fill the surface in. Observe that the surface is complete, but only parts of the control mesh are drawn. See Figure 8751682
With the current 2.83.4 Long term release and the Last Good Version, the control mesh is fully drawn. See Figure 8751697

**System Information** Operating system: Linux 5.4.38-gentoo-gwen #1 SMP Wed May 27 04:32:46 EDT 2020 x86_64 Intel(R) Core(TM) i5-3320M CPU @ 2.60GHz GenuineIntel GNU/Linux Graphics card: Intel Corporation 3rd Gen Core processor Graphics Controller [system-info.txt](https://archive.blender.org/developer/F8751573/system-info.txt) **Blender Version** - First Broken Version (from git bisect): bf8b62e874 - Author: Campbell Barton <ideasman42@gmail.com> - Date: Mon Jun 15 15:28:51 2020 +1000 - Title: Fix curve handle color ID display - Last Good Version (from git bisect): 24d77e7db7 - Author: Tobias Heinke <TobiasH> - Date: Sun Jun 14 19:14:26 2020 -0400 - Title: API docs: mathutils leaked markup - Also Broken: Current 2.90 Beta, branch: master, commit date: 2020-08-05 21:36, hash: c5b6b3d82f56, type: Release Looks like the real culprit is 49f59092e7 see my comment #79580#997407? - Known to be good: 2.83.4 Long Term Release **Short description of error** After lofting a set of surface curves, the control mesh is only partially drawn. This is a papercut: proceeding to edit the mesh results in the complete drawing of control meshes. **Exact steps for others to reproduce the error** - Add a set of surface curves with the aim of lofting a surface. Ensure the surface curves are joined into a single object - With the object selected, enter into edit mode (TAB) and select the entire cage. See Figure **[F8751637](https://archive.blender.org/developer/F8751637/Screenshot_at_2020-08-05_17-14-09.png)** ![Screenshot at 2020-08-05 17-14-09.png](https://archive.blender.org/developer/F8751637/Screenshot_at_2020-08-05_17-14-09.png) 3. Alternatively, open **surfacecage.blend** and find the object **SurfCurve** selected, in edit mode, and with all surface curves in the cage selected. [surfacecage.blend](https://archive.blender.org/developer/F8751668/surfacecage.blend) 4. Press {key F} to fill the surface in. Observe that the surface is complete, but only parts of the control mesh are drawn. See Figure **8751682** ![Screenshot at 2020-08-05 17-14-27.png](https://archive.blender.org/developer/F8751682/Screenshot_at_2020-08-05_17-14-27.png) 5. With the current 2.83.4 Long term release and the Last Good Version, the control mesh is fully drawn. See Figure **8751697** ![Screenshot at 2020-08-05 17-19-14.png](https://archive.blender.org/developer/F8751697/Screenshot_at_2020-08-05_17-19-14.png)

Garry R. Osgood commented

2020-08-06 11:53:06 +02:00

Added subscriber: @grosgood

Germano Cavalcante commented

2020-08-07 04:00:48 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Germano Cavalcante commented

2020-08-07 04:00:48 +02:00

Added subscribers: @ideasman42, @mano-wii

Garry R. Osgood commented

2020-08-12 13:58:22 +02:00

This is a papercut: proceeding to edit the mesh results in the complete drawing of control meshes.

A nurbs surface object may contain any number of disjoint surfaces. In that setting, there is a need to distinguish the active surface from inactive: the somewhat thicker-lined, pink and orange "theme" usually seen exclusively when editing single-cage surfaces, the run-of-the-mill case, is the "active" theme. It is the inactive theme that is only being partially drawn. In light of these two themes, I think I mis-spoke: this is somewhat more than a papercut, but quite less than fatal.

surfacecage_multispline.blend

surfacecage_multispline.blend contains two disjoint surfaces. An approach to this bug may be to align the rendering of the "defective" theme with that which works quite well. I find this a more useful test file than the one I originally submitted because it is easy to select one, then the other cage and examine how the good theme operates with respect to the bad. That is the approach to this I'll take this weekend, as I tentatively wrap my head around this one.

> This is a **papercut:** proceeding to edit the mesh results in the complete drawing of control meshes. A nurbs surface object may contain any number of disjoint surfaces. In that setting, there is a need to distinguish the active surface from inactive: the somewhat thicker-lined, pink and orange "theme" usually seen exclusively when editing single-cage surfaces, the run-of-the-mill case, is the "active" theme. It is the inactive theme that is only being partially drawn. In light of these two themes, I think I mis-spoke: this is somewhat more than a papercut, but quite less than fatal. [surfacecage_multispline.blend](https://archive.blender.org/developer/F8773068/surfacecage_multispline.blend) **surfacecage_multispline.blend** contains two disjoint surfaces. An approach to this bug may be to align the rendering of the "defective" theme with that which works quite well. I find this a more useful test file than the one I originally submitted because it is easy to select one, then the other cage and examine how the good theme operates with respect to the bad. That is the approach to this I'll take this weekend, as I tentatively wrap my head around this one.

Philipp Oeser commented

2020-08-17 18:35:50 +02:00

Added subscribers: @fclem, @antoniov, @lichtwerk

Philipp Oeser commented

2020-08-17 18:35:50 +02:00

Looks like the real culprit is {49f59092e7}?

I dont see how returning early here can work?
https://developer.blender.org/diffusion/B/browse/master/source/blender/draw/engines/overlay/shaders/edit_curve_handle_geom.glsl$62
(I dont get why we need to return early in case of a v-segment here)

We will never reach this then
https://developer.blender.org/diffusion/B/browse/master/source/blender/draw/engines/overlay/shaders/edit_curve_handle_geom.glsl$88

Probably there were two bugs in 49f59092e7, one that was hiding this one [that was fixed by 49f59092e7], so that this now shows.

CC @antoniov
CC @fclem

Marking as High prio since it is a regression

Looks like the real culprit is {49f59092e7}? I dont see how returning early here can work? https://developer.blender.org/diffusion/B/browse/master/source/blender/draw/engines/overlay/shaders/edit_curve_handle_geom.glsl$62 (I dont get why we need to return early in case of a v-segment here) We will never reach this then https://developer.blender.org/diffusion/B/browse/master/source/blender/draw/engines/overlay/shaders/edit_curve_handle_geom.glsl$88 Probably there were two bugs in 49f59092e7, one that was hiding this one [that was fixed by 49f59092e7], so that this now shows. CC @antoniov CC @fclem Marking as High prio since it is a regression

Antonio Vazquez commented

2020-08-17 20:11:50 +02:00

Proposed fix in D8600

Proposed fix in [D8600](https://archive.blender.org/developer/D8600)

Garry R. Osgood commented

2020-08-17 22:52:22 +02:00

D8600 plays here. Using surfacecage_multispline.blend

[D8600](https://archive.blender.org/developer/D8600) plays here. Using **surfacecage_multispline.blend** ![Screenshot at 2020-08-17 16-48-56.png](https://archive.blender.org/developer/F8789211/Screenshot_at_2020-08-17_16-48-56.png)

blender-admin commented

2020-08-18 09:51:36 +02:00

This issue was referenced by 567e333ea4

This issue was referenced by 567e333ea47c3a0712e6e34e34029df51822d408

Antonio Vazquez commented

2020-08-18 09:52:32 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Antonio Vazquez closed this issue

2020-08-18 09:52:32 +02:00

Antonio Vazquez self-assigned this 2020-08-18 09:52:32 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Control Mesh Only Partially Drawn After Filling a Surface From a Cage of Surface Curves #79580