Bevel clamp overlap incorrect with percentage #79898

New Issue

michael campbell · 2020-08-18T22:55:51+02:00

michael campbell commented

2020-08-18 22:55:51 +02:00

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 451.48

Blender Version
Broken: version: 2.91.0 Alpha, branch: master, commit date: 2020-08-05 22:29, hash: 675700d948
Worked: Never (2.8+)

Short description of error
edit mode bevel operation clamp overlap is basing overlap on offset rather than percentage, and therefore clamping even when there is no overlap.

Exact steps for others to reproduce the error
#79898.blend

Open file
Select all edges
Set bevel to percent
Turn on clamp overlap

Increase the width to 100%.

Even though it’s set to percent, the clamp will still stop the edges that shouldn’t be clamped from fully bevelling.

**System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 451.48 **Blender Version** Broken: version: 2.91.0 Alpha, branch: master, commit date: 2020-08-05 22:29, hash: `675700d948` Worked: Never (2.8+) **Short description of error** edit mode bevel operation clamp overlap is basing overlap on offset rather than percentage, and therefore clamping even when there is no overlap. **Exact steps for others to reproduce the error** [#79898.blend](https://archive.blender.org/developer/F8809621/T79898.blend) - Open file - Select all edges - Set bevel to percent - Turn on clamp overlap # Increase the width to 100%. Even though it’s set to percent, the clamp will still stop the edges that shouldn’t be clamped from fully bevelling.

michael campbell commented

2020-08-18 22:55:51 +02:00

Added subscriber: @3di

Richard Antalik commented

2020-08-21 04:16:18 +02:00

Added subscriber: @iss

Richard Antalik commented

2020-08-21 04:16:18 +02:00

Is this reported problem?

Is this reported problem? ![Untitled.png](https://archive.blender.org/developer/F8798710/Untitled.png)

Richard Antalik commented

2020-08-25 04:32:54 +02:00

Changed status from 'Needs Triage' to: 'Needs User Info'

michael campbell commented

2020-08-25 05:07:51 +02:00

No, your bevelling vertices.

Create an object where one edge would cause a clamp to occur before other edges were fully bevelled

Select all edges
Bevel
Set bevel to percent
Turn on clamp overlap
Now increase the width.

Even though it’s set to percent, the clamp will still stop the edges that shouldn’t be clamped from fully bevelling.

No, your bevelling vertices. Create an object where one edge would cause a clamp to occur before other edges were fully bevelled Select all edges Bevel Set bevel to percent Turn on clamp overlap Now increase the width. Even though it’s set to percent, the clamp will still stop the edges that shouldn’t be clamped from fully bevelling.

Richard Antalik changed title from ~~edit mode bevel operation clamp overlap is basing overlap on offset rather than percentage.~~ to Bevel clamp overlap incorrect with percentage

2020-08-25 06:41:42 +02:00

Richard Antalik commented

2020-08-25 06:41:42 +02:00

Changed status from 'Needs User Info' to: 'Confirmed'

Howard Trickey commented

2020-09-23 02:12:13 +02:00

Added subscriber: @howardt

Howard Trickey self-assigned this 2020-09-23 02:12:13 +02:00

Howard Trickey commented

2020-09-23 02:12:13 +02:00

There is indeed a bug here. The clamp code works when the offset edges move parallel to the original edges, but that is not usually the case when Percentage mode is used. (The same bug will affect the new Absolute mode.) I will have to work out the different math for this case.

Howard Trickey commented

2020-09-27 02:26:39 +02:00

In working on adding clamping for Percent (which is hard!), I have discovered that the whole method of doing Percent is wrong. It is making constant width offset lines.

Howard Trickey commented

2020-10-18 22:33:53 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Howard Trickey closed this issue

2020-10-18 22:33:53 +02:00

Howard Trickey commented

2020-10-18 22:33:53 +02:00

Well this was quite the rabbit-hole. The whole method of doing percent (and absolute) mode was wrong. It worked if the required offset lines were parallel to the original edge, and maybe in a few other cases accidentally, but really I needed to write whole new code to handle these modes.

After doing that, the clamping for percent was trivial to fix: you need to clamp to 50% if two beveled edges shared the same leg.
The clamping for absolute mode is significantly harder. It is improved, but I'm going to leave its still-somewhat-brokenness as a known issue.
I really hope to be able to do away with clamping all together with a major upgrade to Bevel that I hope to work on next.

Well this was quite the rabbit-hole. The whole method of doing percent (and absolute) mode was wrong. It worked if the required offset lines were parallel to the original edge, and maybe in a few other cases accidentally, but really I needed to write whole new code to handle these modes. After doing that, the clamping for percent was trivial to fix: you need to clamp to 50% if two beveled edges shared the same leg. The clamping for absolute mode is significantly harder. It is improved, but I'm going to leave its still-somewhat-brokenness as a known issue. I really hope to be able to do away with clamping all together with a major upgrade to Bevel that I hope to work on next.

michael campbell commented

2020-10-18 23:07:22 +02:00

Cool, perhaps bevel width could be done based on the visual representation of vertex weight falloff on the face. 0.5 would always be halfway towards the nearest vertex for example. Would probably need edge weight too though for that to work on long edges.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Bevel clamp overlap incorrect with percentage #79898

Increase the width to 100%.