Sequencer/preview mode is missing on the toggle view operator #80461

New Issue

Vincent Girès · 2020-09-04T10:24:11+02:00

Vincent Girès commented

2020-09-04 10:24:11 +02:00

System Information
Operating system: Linux-3.10.0-1127.18.2.el7.x86_64-x86_64-with-centos-7.2.1511-Core 64 Bits
Graphics card: GeForce GTX 1070 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.36

Blender Version
Broken: version: 2.90.0, branch: master, commit date: 2020-08-31 11:26, hash: 0330d1af29
Worked: 2.85.5 and below
Was changed in e43a948a2c

Short description of error
Sequencer/preview mode is missing on the toggle view operator

Exact steps for others to reproduce the error
On a sequence editor context, use ctrl + tab or "View > Toggle Sequencer/Preview" operator. On previous blender version, it was toggling between the three modes (preview, sequencer and sequencer/preview). On blender 2.90.0, the "sequencer/preview"mode is missing using the operator.

**System Information** Operating system: Linux-3.10.0-1127.18.2.el7.x86_64-x86_64-with-centos-7.2.1511-Core 64 Bits Graphics card: GeForce GTX 1070 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.36 **Blender Version** Broken: version: 2.90.0, branch: master, commit date: 2020-08-31 11:26, hash: `0330d1af29` Worked: 2.85.5 and below Was changed in e43a948a2c **Short description of error** Sequencer/preview mode is missing on the toggle view operator **Exact steps for others to reproduce the error** On a sequence editor context, use ctrl + tab or "View > Toggle Sequencer/Preview" operator. On previous blender version, it was toggling between the three modes (preview, sequencer and sequencer/preview). On blender 2.90.0, the "sequencer/preview"mode is missing using the operator.

Vincent Girès commented

2020-09-04 10:24:11 +02:00

Added subscriber: @VincentGires

Philipp Oeser commented

2020-09-04 11:36:06 +02:00

Added subscribers: @iss, @ideasman42, @lichtwerk

Philipp Oeser commented

2020-09-04 11:36:06 +02:00

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'

Philipp Oeser commented

2020-09-04 11:36:06 +02:00

This was changed in e43a948a2c

from the commit message:

Switch between PREVIEW/SEQUENCER as the mixed state isn't as useful.

Think we could add the 3rd one back (as in: use context_cycle_enum?), Not sure what the rationale was? [maybe because of the dedicated workspace we have?]
Technically this is not really a bug (as it was done intentionally), but the question is: why?

CC @ideasman42
CC @iss

This was changed in e43a948a2c from the commit message: > Switch between PREVIEW/SEQUENCER as the mixed state isn't as useful. Think we could add the 3rd one back (as in: use `context_cycle_enum`?), Not sure what the rationale was? [maybe because of the dedicated workspace we have?] Technically this is not really a bug (as it was done intentionally), but the question is: **why**? CC @ideasman42 CC @iss

Vincent Girès commented

2020-09-04 12:03:36 +02:00

I didn't see that change, sorry for the non bug report.
I find the mixed mode quite useful to not get too small panels and very convenient to switch between it with a single shortcut and a single area window.

If it's only a shortcut change, no worries, I can make my own operator but if the goal is to delete the mixed view if the future version, I would really miss it I find much more convenient that having two different areas.

We use extensively the VSE in our studio as a reviewing tool that need quite a lot of custom panels. So having it in two separate areas shows too much tabs.

Here is a dual area display.

The same layout with the mixed view is much more readable.

I didn't see that change, sorry for the non bug report. I find the mixed mode quite useful to not get too small panels and very convenient to switch between it with a single shortcut and a single area window. If it's only a shortcut change, no worries, I can make my own operator but if the goal is to delete the mixed view if the future version, I would really miss it I find much more convenient that having two different areas. We use extensively the VSE in our studio as a reviewing tool that need quite a lot of custom panels. So having it in two separate areas shows too much tabs. Here is a dual area display. ![Screenshot_2020-09-04_11-46-59.png](https://archive.blender.org/developer/F8839685/Screenshot_2020-09-04_11-46-59.png) The same layout with the mixed view is much more readable. ![Screenshot_2020-09-04_11-47-59.png](https://archive.blender.org/developer/F8839695/Screenshot_2020-09-04_11-47-59.png)

tintwotin commented

2020-09-04 12:23:47 +02:00

Added subscriber: @tintwotin

tintwotin commented

2020-09-04 12:23:47 +02:00

Yet another commit from @ideasman42 which unreviewed, untagged and un-discussed removes existing functionality from the VSE. You devs really, really need to have a discussion about this being cool or not?

Campbell Barton commented

2020-09-04 13:48:57 +02:00

This is simply a shortcut & menu item, there is no intention to remove mixed-display.

In #80461#1009111, @lichtwerk wrote:
Not sure what the rationale was?

In general cycling between 3 states is fairly awkward since you need to be aware of the state order, or you cycle until you get to the state you want. Also, if you're using the split-screen it's unlikely you will need to cycle at all, since you have both available.

Toggle shortcuts are for frequently accessed functionality, for example - Ctrl-Tab also toggles between Dope-Sheet and F-Curve editor, we could add the NLA space and cycle between all 3, it could be argued this is even a feature, but in practice it's better to quickly and predictably cycle between two frequently accessed editors.

@iss what do you think?

This is simply a shortcut & menu item, there is no intention to remove mixed-display. > In #80461#1009111, @lichtwerk wrote: > Not sure what the rationale was? In general cycling between 3 states is fairly awkward since you need to be aware of the state order, or you cycle until you get to the state you want. Also, if you're using the split-screen it's unlikely you will need to cycle at all, since you have both available. Toggle shortcuts are for frequently accessed functionality, for example - Ctrl-Tab also toggles between Dope-Sheet and F-Curve editor, we could add the NLA space and cycle between all 3, it could be argued this is even a feature, but in practice it's better to quickly and predictably cycle between two frequently accessed editors. ---- @iss what do you think?

Richard Antalik commented

2020-09-04 14:16:16 +02:00

@VincentGires you can change sequencer view in enum menu next to other menu items. Is it somehow inconvinient that you can't toggle to this mode with ctrl + tab shortcut?

I guess it would be nice and perhaps better to be able to assign custom keyboard shortcut to individual view modes?

@VincentGires you can change sequencer view in enum menu next to other menu items. Is it somehow inconvinient that you can't toggle to this mode with ctrl + tab shortcut? I guess it would be nice and perhaps better to be able to assign custom keyboard shortcut to individual view modes?

Vincent Girès commented

2020-09-04 14:28:42 +02:00

No no this is not a problem since I can use a custom operator for that. I just didn't know it was changed on purpose, I didn't see the commit.

Campbell Barton commented

2020-09-04 15:17:17 +02:00

Changed status from 'Needs Developer To Reproduce' to: 'Archived'

Campbell Barton closed this issue

2020-09-04 15:17:17 +02:00

Campbell Barton self-assigned this 2020-09-04 15:17:17 +02:00

Campbell Barton commented

2020-09-04 15:17:17 +02:00

Double checked and you can change the operator to wm.context_cycle_enum with wrap to True, it works as before, if you preferred that.

Closing.

Double checked and you can change the operator to `wm.context_cycle_enum` with `wrap` to True, it works as before, if you preferred that. Closing.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Sequencer/preview mode is missing on the toggle view operator #80461