Viewport Optix Denoiser is available when Cycles Render Device is set to None/CUDA, leading to a crash #80477

New Issue

marcuspollio · 2020-09-04T19:31:56+02:00

marcuspollio commented

2020-09-04 19:31:56 +02:00

Hi there !

System Information
Operating system: Linux-5.4.0-7642-generic-x86_64-with-debian-bullseye-sid 64 Bits
Graphics card: GeForce GTX 1050 Ti with Max-Q Design/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.100

Blender Version
Broken: version: 2.91.0 Alpha, branch: master, commit date: 2020-09-03 20:57, hash: a96283ba51
Worked: (newest version of Blender that worked as expected)

Short description of error
The option to choose the Viewport Denoiser in the Render Properties shows Optix in the dropdown menu, even though the Cycles Render Device in the System Preferences in set to "None" or "CUDA". Choosing the Optix Viewport Denoiser and going to Rendered mode crashes Blender

Exact steps for others to reproduce the error

Start Blender with defaults (Cycles Render Device to None or CUDA).
In the Render Properties editor, change the Engine to Cycles.
In the Denoising Sampling panel, activate the Viewport Denoiser. Automatic will be chosen.
Change the Viewport Shading to Rendered to be welcomed by a crash

Note that the crash occurs also when the Device in the Render Properties panel is set to GPU Compute.
Note that a Cycles Render Device to Optix and the Device to GPU Compute does not crash for me when choosing the Optix Denoiser in the Rendered Viewport Shading (as it should be hopefully).

system-info.txt

optix_denoise_crash.txt

Hi there ! **System Information** Operating system: Linux-5.4.0-7642-generic-x86_64-with-debian-bullseye-sid 64 Bits Graphics card: GeForce GTX 1050 Ti with Max-Q Design/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.100 **Blender Version** Broken: version: 2.91.0 Alpha, branch: master, commit date: 2020-09-03 20:57, hash: `a96283ba51` Worked: (newest version of Blender that worked as expected) **Short description of error** The option to choose the Viewport Denoiser in the Render Properties shows Optix in the dropdown menu, even though the Cycles Render Device in the System Preferences in set to "None" or "CUDA". Choosing the Optix Viewport Denoiser and going to Rendered mode crashes Blender **Exact steps for others to reproduce the error** - Start Blender with defaults (Cycles Render Device to None or CUDA). - In the Render Properties editor, change the Engine to Cycles. - In the Denoising Sampling panel, activate the Viewport Denoiser. Automatic will be chosen. - Change the Viewport Shading to Rendered to be welcomed by a crash Note that the crash occurs also when the Device in the Render Properties panel is set to GPU Compute. Note that a Cycles Render Device to Optix and the Device to GPU Compute does not crash for me when choosing the Optix Denoiser in the Rendered Viewport Shading (as it should be hopefully). [system-info.txt](https://archive.blender.org/developer/F8841326/system-info.txt) [optix_denoise_crash.txt](https://archive.blender.org/developer/F8841341/optix_denoise_crash.txt) ![denoise.jpg](https://archive.blender.org/developer/F8841342/denoise.jpg)

marcuspollio commented

2020-09-04 19:31:56 +02:00

Added subscriber: @marcuspollio

blender-admin commented

2020-09-04 19:31:56 +02:00

#81464 was marked as duplicate of this issue

blender-admin commented

2020-09-04 19:31:56 +02:00

#81418 was marked as duplicate of this issue

blender-admin commented

2020-09-04 19:31:56 +02:00

#81325 was marked as duplicate of this issue

blender-admin commented

2020-09-04 19:31:56 +02:00

#80543 was marked as duplicate of this issue

YAFU commented

2020-09-04 21:42:59 +02:00

Added subscriber: @YAFU

YAFU commented

2020-09-04 21:42:59 +02:00

Optix Denoiser being available when Cycles Render Device is set to None/CUDA is correct behavior. However, I can confirm the crash following the above steps in a96283ba51 with CUDA/CPU and Optix denoiser. Linux, GTX 960 (450.66 driver)

Optix Denoiser being available when Cycles Render Device is set to None/CUDA is correct behavior. However, I can confirm the crash following the above steps in a96283ba511d with CUDA/CPU and Optix denoiser. Linux, GTX 960 (450.66 driver)

Robert Guetzkow commented

2020-09-05 12:01:04 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Robert Guetzkow commented

2020-09-05 12:03:46 +02:00

Added subscriber: @rjg

Robert Guetzkow commented

2020-09-05 12:03:46 +02:00

I can confirm this issue. I'm not entirely sure which project and tag is correct for this ticket, since there's an overlap between viewport, optix and cycles.

Philipp Oeser commented

2020-09-05 12:17:14 +02:00

Added subscribers: @pmoursnv, @lichtwerk

Philipp Oeser commented

2020-09-05 12:17:14 +02:00

Can confirm that cf0ba59e31 is crashing for me as well (whereas 429afe0c62 was still fine)

**System Information**
Operating system: Linux-5.7.10-201.fc32.x86_64-x86_64-with-fedora-32-Thirty_Two 64 Bits
Graphics card: GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.100
version: 2.91.0 Alpha, branch: master, commit date: 2020-09-04 21:32, hash: `rBcf0ba59e311b`

Cannot bisect this atm, due to https://devtalk.blender.org/t/cuda-not-compiling , using builds from builder.blender.org.

CC @pmoursnv

Can confirm that cf0ba59e31 is crashing for me as well (whereas 429afe0c62 was still fine) ``` **System Information** Operating system: Linux-5.7.10-201.fc32.x86_64-x86_64-with-fedora-32-Thirty_Two 64 Bits Graphics card: GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.100 version: 2.91.0 Alpha, branch: master, commit date: 2020-09-04 21:32, hash: `rBcf0ba59e311b` ``` Cannot bisect this atm, due to https://devtalk.blender.org/t/cuda-not-compiling , using builds from builder.blender.org. CC @pmoursnv

YAFU commented

2020-09-05 14:41:52 +02:00

Just a clarification. Crash not only happens in viewport, it also happens in final render with Optix denoiser. Under some circumstances the crash even occurs with Optix selected in Device settings. Anyway I guess this will be easily reproducible by the developers.

Philipp Oeser commented

2020-09-07 10:23:24 +02:00

Added subscriber: @diegoblender

Dalai Felinto commented

2020-09-08 14:05:33 +02:00

Added subscriber: @dfelinto

Patrick Mours was assigned by Dalai Felinto

2020-09-08 14:05:33 +02:00

Dalai Felinto commented

2020-09-08 14:05:33 +02:00

Hi Patrick, assigning this to you since it is a high priority issue. If you won't have the time to look at that please unassign and we see how to handle it.

Patrick Mours removed their assignment 2020-09-08 15:36:13 +02:00

Stefan Werner was assigned by Patrick Mours

2020-09-08 15:36:13 +02:00

Patrick Mours commented

2020-09-08 15:36:13 +02:00

Added subscriber: @Stefan_Werner

Patrick Mours commented

2020-09-08 15:36:13 +02:00

This is caused by 009971ba7a. Enabling OptiX denoising with CPU rendering creates an implicit multi-device in Cycles, which breaks Embree BVH building because the Embree device (BVHEmbree::rtc_device) is not initialized.
@Stefan_Werner I suppose the simplest solution would be to override Device::bvh_device() in MultiDevice as well and have it return the one from the first CPU device (as there should only be one anyway)? We also may want to streamline the Embree/OptiX BVH building at some point and make it more similar, but that's out of scope for this particular issue.

This is caused by 009971ba7a. Enabling OptiX denoising with CPU rendering creates an implicit multi-device in Cycles, which breaks Embree BVH building because the Embree device (`BVHEmbree::rtc_device`) is not initialized. @Stefan_Werner I suppose the simplest solution would be to override `Device::bvh_device()` in `MultiDevice` as well and have it return the one from the first CPU device (as there should only be one anyway)? We also may want to streamline the Embree/OptiX BVH building at some point and make it more similar, but that's out of scope for this particular issue.

Jeroen Bakker commented

2020-09-09 14:10:14 +02:00

Added subscriber: @Jeroen-Bakker