Tree-IK and IK-Tree #80534

New Issue

Hoang Duy Tran · 2020-09-06T20:20:36+02:00

Hoang Duy Tran commented

2020-09-06 20:20:36 +02:00

System Information
Operating system: Darwin-19.6.0-x86_64-i386-64bit 64 Bits

Blender Version
Broken: version: 2.90.0 Beta, branch: master, commit date: 2020-08-25 16:00, hash: 21cb6f09ff

Short description of error
In the following screen about IK:

The tooltip of field Weight Position says:

For Tree-IK: Weight of position control for this target

and for the field below, Rotation, the tooltip says:

Orientation Weight", "For Tree-IK: Weight of orientation control for this target

This tracked down to the source file:

blender/source/blender/makesrna/intern/rna_constraint.c

and the file:

blender/source/blender/ikplugin/intern/iksolver_plugin.c

These fields related to

data->weight

and

data->orientweight

In this source file 'iksolver_plugin.c' it mentioned

** "ik tree"**Now in English, to me,IK Tree, means the tree of inverse kinematics,

where as

Tree-IK, means the inverse kinematics of the tree,

Now two things have a completely different meaning.

IMHO the text in the

blender/source/blender/makesrna/intern/rna_constraint.c

Should change to

IK Tree

and not

Tree-IK

and this change of word's order should be reflected in the manual documentation 'rst' files as well.

**System Information** Operating system: Darwin-19.6.0-x86_64-i386-64bit 64 Bits **Blender Version** Broken: version: 2.90.0 Beta, branch: master, commit date: 2020-08-25 16:00, hash: `21cb6f09ff` **Short description of error** In the following screen about IK: ![Screenshot 2020-09-06 at 19.00.39.png](https://archive.blender.org/developer/F8847963/Screenshot_2020-09-06_at_19.00.39.png) The tooltip of field **Weight Position** says: For **Tree-IK**: Weight of position control for this target and for the field below, **Rotation**, the tooltip says: Orientation Weight", "For **Tree-IK**: Weight of orientation control for this target This tracked down to the source file: ``` blender/source/blender/makesrna/intern/rna_constraint.c ``` and the file: ``` blender/source/blender/ikplugin/intern/iksolver_plugin.c ``` These fields related to ``` data->weight ``` and ``` data->orientweight ``` In this source file *'iksolver_plugin.c'* it mentioned ** "ik tree"**Now in English, to me,**IK Tree**, means the **tree of inverse kinematics**, where as **Tree-IK**, means the **inverse kinematics of the tree**, Now two things have a **completely** different meaning. IMHO the text in the ``` blender/source/blender/makesrna/intern/rna_constraint.c ``` Should change to **IK Tree** and not **Tree-IK** and this change of word's order should be reflected in the manual documentation 'rst' files as well.

Hoang Duy Tran commented

2020-09-06 20:20:36 +02:00

Added subscriber: @hoanguk

Richard Antalik commented

2020-09-14 16:55:29 +02:00

Added subscriber: @iss

Richard Antalik commented

2020-09-14 16:55:29 +02:00

Changed status from 'Needs Triage' to: 'Archived'

Richard Antalik closed this issue

2020-09-14 16:55:29 +02:00

Richard Antalik self-assigned this 2020-09-14 16:55:29 +02:00

Richard Antalik commented

2020-09-14 16:55:29 +02:00

I am not really sure if A or B is correct here. Is "For Tree-IK" even needed to explain functionality?

In any case I would suggest to submit patch if you think it is incorrect.

We shouldn't handle issues like these on this tracker really, it is pretty much a typo in my opinion. Normally If I see request like this, when I agree with report and it takes me 5 minutes to implement I go ahead and make patch. I am not so sure in this case, but I would say that removing "For Tree-IK" would be pretty safe.

I will close this as I don't think this is a bug.

I am not really sure if A or B is correct here. Is "For Tree-IK" even needed to explain functionality? In any case I would suggest to submit patch if you think it is incorrect. We shouldn't handle issues like these on this tracker really, it is pretty much a typo in my opinion. Normally If I see request like this, when I agree with report and it takes me 5 minutes to implement I go ahead and make patch. I am not so sure in this case, but I would say that removing "For Tree-IK" would be pretty safe. I will close this as I don't think this is a bug.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Tree-IK and IK-Tree #80534