Text Editor: Missing undo for text operators when in edit mode #80611

New Issue

Kai Jægersen · 2020-09-09T00:16:33+02:00

Kai Jægersen commented

2020-09-09 00:16:33 +02:00

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 441.87

Blender Version
Broken: version: 2.91.0 Alpha, branch: master, commit date: 2020-09-07 08:12, hash: b351607996
Worked: Some time before binary diffing was implemented maybe?

Short description of error

Note: This is about text editor operators, nothing to do with Text objects in the viewport.

Custom text operators that modify the text (text.body, text.write(), etc.) are missing undo steps IFF an object is in edit mode.
When an object is in object mode, however, the undo works as expected.

Text operators implemented in C work fine. Assuming the solution is letting custom operators push or tag undo like internal ones.

Exact steps for others to reproduce the error

Load the example blend. The cube will be in edit mode.
Run script. A new button "Modify Body" is placed in the header of Text Editor.
Click the button a few times.
Try to undo (doesn't work)
Toggle to Object mode and do steps 3 and 4 again (undo works)

example.blend

**System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 441.87 **Blender Version** Broken: version: 2.91.0 Alpha, branch: master, commit date: 2020-09-07 08:12, hash: `b351607996` Worked: Some time before binary diffing was implemented maybe? **Short description of error** *Note: This is about text editor operators, nothing to do with Text objects in the viewport.* Custom text operators that modify the text (text.body, text.write(), etc.) are missing undo steps IFF an object is in edit mode. When an object is in object mode, however, the undo works as expected. Text operators implemented in C work fine. Assuming the solution is letting custom operators push or tag undo like internal ones. **Exact steps for others to reproduce the error** 1. Load the example blend. The cube will be in edit mode. 2. Run script. A new button "Modify Body" is placed in the header of *Text Editor*. 3. Click the button a few times. 4. Try to undo (doesn't work) 5. Toggle to Object mode and do steps 3 and 4 again (undo works) [example.blend](https://archive.blender.org/developer/F8855670/example.blend)

Kai Jægersen commented

2020-09-09 00:16:33 +02:00

Added subscriber: @KaiJaegersen

Germano Cavalcante commented

2020-09-11 19:51:57 +02:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2020-09-11 19:51:57 +02:00

The undo system is confusing.
There are many reports on global undo that seem to be related.
The text editor has its own undo context, but apparently it doesn't work on python operators.
Maybe this system needs to be rewritten (there are already tasks designed to do this #68068, #71735)

I'm not sure if this is something that can be fixed in a short time.

The undo system is confusing. There are many reports on global undo that seem to be related. The text editor has its own undo context, but apparently it doesn't work on python operators. Maybe this system needs to be rewritten (there are already tasks designed to do this #68068, #71735) I'm not sure if this is something that can be fixed in a short time.

Kai Jægersen commented

2020-09-12 01:25:22 +02:00

Thanks, I've been looking for those tasks. I wasn't sure if there was a specific report for this.

A workaround to getting undo to work in edit mode for custom operators is to register a Macro which defines two operators:

An internal operator eg. TEXT_OT_insert
My custom python operator

The result is that the macro is able to piggyback the undo pushed by TEXT_OT_insert.
While this works it requires a macro operator, and the code just becomes confusing for others to read.

Thanks, I've been looking for those tasks. I wasn't sure if there was a specific report for this. A workaround to getting undo to work in edit mode for custom operators is to register a `Macro` which defines two operators: 1. An internal operator eg. `TEXT_OT_insert` 2. My custom python operator The result is that the macro is able to piggyback the undo pushed by `TEXT_OT_insert`. While this works it requires a macro operator, and the code just becomes confusing for others to read.

Philipp Oeser commented

2020-09-14 18:59:11 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Campbell Barton commented

2020-09-17 02:28:51 +02:00

Added subscriber: @ideasman42

Campbell Barton commented

2020-09-17 02:28:51 +02:00

We need to expose undo for text operators written in Python, currently in C this is done explicitly, it would be nice to avoid begin/end calls to the undo system although I don't see good way around this (that doesn't further complicate undo).

Added design task which links to this task.

We need to expose undo for text operators written in Python, currently in C this is done explicitly, it would be nice to avoid begin/end calls to the undo system although I don't see good way around this (that doesn't further complicate undo). Added design task which links to this task.

Campbell Barton commented

2020-09-17 02:29:16 +02:00

Closed as duplicate of #80864

Campbell Barton closed this issue

2020-09-17 02:29:16 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Text Editor: Missing undo for text operators when in edit mode #80611