Crashes when undoing VSE #81250

Closed
opened 2020-09-28 14:01:48 +02:00 by David · 21 comments

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce RTX 2080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 452.06

Blender Version
Broken: version: 2.90.1, branch: master, commit date: 2020-09-23 06:43, hash: 3e85bb34d0
Worked: (newest version of Blender that worked as expected)

Short description of error
[Blender crashes when undo 2 to 5 times in a row. It can be with grease pencil or in pose mode ]

Exact steps for others to reproduce the error
[Load blender, Open file, Undo 2 to 5 times ]
[Based on the default startup or an attached .blend file (as simple as possible)]
Meryl - Copy.zip
2020-09-28 12-41-11.mkv

Meryl.blend

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: GeForce RTX 2080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 452.06 **Blender Version** Broken: version: 2.90.1, branch: master, commit date: 2020-09-23 06:43, hash: `3e85bb34d0` Worked: (newest version of Blender that worked as expected) **Short description of error** [Blender crashes when undo 2 to 5 times in a row. It can be with grease pencil or in pose mode ] **Exact steps for others to reproduce the error** [Load blender, Open file, Undo 2 to 5 times ] [Based on the default startup or an attached .blend file (as simple as possible)] [Meryl - Copy.zip](https://archive.blender.org/developer/F8931664/Meryl_-_Copy.zip) [2020-09-28 12-41-11.mkv](https://archive.blender.org/developer/F8931618/2020-09-28_12-41-11.mkv) [Meryl.blend](https://archive.blender.org/developer/F8931628/Meryl.blend)
Author

Added subscriber: @daviddomingues

Added subscriber: @daviddomingues
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Member

Changed status from 'Needs Triage' to: 'Needs User Info'

Changed status from 'Needs Triage' to: 'Needs User Info'
Member

Cannot reproduce from undoing.
I do get a crash though going to the constraints tab (that might be because of #81057 -- which is fixed already).

Can you check if you still have problems with a fresh build from https://builder.blender.org/download/?

Cannot reproduce from undoing. I do get a crash though going to the constraints tab (that might be because of #81057 -- which is fixed already). Can you check if you still have problems with a fresh build from https://builder.blender.org/download/?
Author

I have reproduced it in the latest build blender-2.91.0-8c81b3fb8b9c-windows64

I tried with load factory settings and after loaded the file and it still crashed.

Is something to do with the file I just don't know how to troubleshot something like this.

I have reproduced it in the latest build blender-2.91.0-8c81b3fb8b9c-windows64 I tried with load factory settings and after loaded the file and it still crashed. Is something to do with the file I just don't know how to troubleshot something like this.
Author

I was streaming at the time https://www.twitch.tv/videos/754481760 at around 28:00 time frame. It crashed back to back a couple of times.

I was streaming at the time https://www.twitch.tv/videos/754481760 at around 28:00 time frame. It crashed back to back a couple of times.

Added subscriber: @dfelinto

Added subscriber: @dfelinto

@daviddomingues hi, could you please include steps on how to reproduce with your file?

For instance, just opening the file you can't even undo, so you must have done something before undoing. And although the video may show that, videos are welcome to illustrate some issues further, but not as the main source of truth (it is too time consuming to go through video reports).

@daviddomingues hi, could you please include steps on how to reproduce with your file? For instance, just opening the file you can't even undo, so you must have done something before undoing. And although the video may show that, videos are welcome to illustrate some issues further, but not as the main source of truth (it is too time consuming to go through video reports).

Added subscriber: @MarcinTwarowski

Added subscriber: @MarcinTwarowski

In the video @daviddomingues was using annotate tool. So I opened Meryl.blend and started to annotate and undo madly. It took couple of minutes but it eventually crashed. Log file is basically a very long list of warnings and then EXCEPTION_ACCESS_VIOLATION.
blender_debug_output.txt

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 456.38

Blender Version
Broken: version: 2.91.0 Alpha, branch: master, commit date: 2020-09-26 20:04, hash: 8c81b3fb8b

In the video @daviddomingues was using annotate tool. So I opened Meryl.blend and started to annotate and undo madly. It took couple of minutes but it eventually crashed. Log file is basically a very long list of warnings and then EXCEPTION_ACCESS_VIOLATION. [blender_debug_output.txt](https://archive.blender.org/developer/F8932157/blender_debug_output.txt) > **System Information** > Operating system: Windows-10-10.0.19041-SP0 64 Bits > Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 456.38 > > **Blender Version** > Broken: version: 2.91.0 Alpha, branch: master, commit date: 2020-09-26 20:04, hash: `8c81b3fb8b`
Author

In #81250#1024797, @dfelinto wrote:
@daviddomingues hi, could you please include steps on how to reproduce with your file?

For instance, just opening the file you can't even undo, so you must have done something before undoing. And although the video may show that, videos are welcome to illustrate some issues further, but not as the main source of truth (it is too time consuming to go through video reports).

I understand that video are time consuming for the team to review. I just didn't know now to explain the bug. If there's no one else reporting something similar I would say that this is very specific to my file.

> In #81250#1024797, @dfelinto wrote: > @daviddomingues hi, could you please include steps on how to reproduce with your file? > > For instance, just opening the file you can't even undo, so you must have done something before undoing. And although the video may show that, videos are welcome to illustrate some issues further, but not as the main source of truth (it is too time consuming to go through video reports). I understand that video are time consuming for the team to review. I just didn't know now to explain the bug. If there's no one else reporting something similar I would say that this is very specific to my file.

If you enable "Undo Legacy" in the Experimental features , does it still crash?

If you enable "Undo Legacy" in the [Experimental features ](https://docs.blender.org/manual/en/latest/render/cycles/features.html), does it still crash?
Author

With the legacy undo it doesn't crash.

With the legacy undo it doesn't crash.
Member

Changed status from 'Needs User Info' to: 'Needs Triage'

Changed status from 'Needs User Info' to: 'Needs Triage'

Added subscriber: @iss

Added subscriber: @iss

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'

Not sure if this is the only problem here, but I can reproduce crash in sequencer prefetching of all things.

Thread (crashed)
Exception thrown: read access violation. screen was 0xFFFFFFFFFFFFFF09.

>	blender.exe!seq_prefetch_is_scrubbing(Main * bmain) Line 101	C

 	blender.exe!seq_prefetch_need_suspend(PrefetchJob * pfjob) Line 416	C
 	blender.exe!seq_prefetch_do_suspend(PrefetchJob * pfjob) Line 424	C
 	blender.exe!seq_prefetch_frames(void * job) Line 468	C
 	blender.exe!tslot_thread_start(void * tslot_p) Line 232	C++
 	[External Code]	

Main:

>	blender.exe!OCIOImpl::configGetProcessor(OCIO_ConstConfigRcPtr__ * * config, OCIO_ConstTransformRcPtr__ * * transform) Line 638	C++

 	blender.exe!OCIO_configGetProcessor(OCIO_ConstConfigRcPtr__ * * config, OCIO_ConstTransformRcPtr__ * * transform) Line 201	C++
 	blender.exe!create_display_buffer_processor(const unsigned char * look, const unsigned char * view_transform, const unsigned char * display, float exposure, float gamma, const unsigned char * from_colorspace, const bool linear_output) Line 918	C
 	blender.exe!update_glsl_display_processor(const ColorManagedViewSettings * view_settings, const ColorManagedDisplaySettings * display_settings, const unsigned char * from_colorspace) Line 4121	C
 	blender.exe!IMB_colormanagement_setup_glsl_draw_from_space(const ColorManagedViewSettings * view_settings, const ColorManagedDisplaySettings * display_settings, ColorSpace * from_colorspace, float dither, bool predivide, bool do_overlay_merge) Line 4180	C
 	blender.exe!IMB_colormanagement_setup_glsl_draw_from_space_ctx(const bContext * C, ColorSpace * from_colorspace, float dither, bool predivide) Line 4223	C
 	blender.exe!sequencer_OCIO_transform_ibuf(const bContext * C, ImBuf * ibuf, bool * r_glsl_used, eGPUTextureFormat * r_format, eGPUDataFormat * r_data) Line 1516	C
 	blender.exe!sequencer_draw_display_buffer(const bContext * C, Scene * scene, ARegion * region, SpaceSeq * sseq, ImBuf * ibuf, ImBuf * scope, bool draw_overlay, bool draw_backdrop) Line 1633	C
 	blender.exe!sequencer_draw_preview(const bContext * C, Scene * scene, ARegion * region, SpaceSeq * sseq, int cfra, int offset, bool draw_overlay, bool draw_backdrop) Line 1826	C
 	blender.exe!sequencer_preview_region_draw(const bContext * C, ARegion * region) Line 719	C
 	blender.exe!ED_region_do_draw(bContext * C, ARegion * region) Line 552	C
 	blender.exe!wm_draw_window_offscreen(bContext * C, wmWindow * win, bool stereo) Line 732	C
 	blender.exe!wm_draw_window(bContext * C, wmWindow * win) Line 871	C
 	blender.exe!wm_draw_update(bContext * C) Line 1072	C
 	blender.exe!WM_main(bContext * C) Line 489	C
 	blender.exe!main(int argc, const unsigned char * * UNUSED_argv_c) Line 523	C
 	[External Code]	

This looks to me like race condition, it's not immediately evident how to resolve though. Will have a look at this. I am not sure how legacy undo would affect reproducibility here.

@daviddomingues Can you disabe prefetching in video sequencer and check if this crashes?
@MarcinTwarowski can you upload file C:\Users\TwaMa\AppData\Local\Temp\Meryl.crash.txt? to make sure this is only issue here?

To make sure this crashes it is important to draw and undo quickly, before prefetching is finished.

Not sure if this is the only problem here, but I can reproduce crash in sequencer prefetching of all things. Thread (crashed) `Exception thrown: read access violation. screen was 0xFFFFFFFFFFFFFF09.` ``` > blender.exe!seq_prefetch_is_scrubbing(Main * bmain) Line 101 C blender.exe!seq_prefetch_need_suspend(PrefetchJob * pfjob) Line 416 C blender.exe!seq_prefetch_do_suspend(PrefetchJob * pfjob) Line 424 C blender.exe!seq_prefetch_frames(void * job) Line 468 C blender.exe!tslot_thread_start(void * tslot_p) Line 232 C++ [External Code] ``` Main: ``` > blender.exe!OCIOImpl::configGetProcessor(OCIO_ConstConfigRcPtr__ * * config, OCIO_ConstTransformRcPtr__ * * transform) Line 638 C++ blender.exe!OCIO_configGetProcessor(OCIO_ConstConfigRcPtr__ * * config, OCIO_ConstTransformRcPtr__ * * transform) Line 201 C++ blender.exe!create_display_buffer_processor(const unsigned char * look, const unsigned char * view_transform, const unsigned char * display, float exposure, float gamma, const unsigned char * from_colorspace, const bool linear_output) Line 918 C blender.exe!update_glsl_display_processor(const ColorManagedViewSettings * view_settings, const ColorManagedDisplaySettings * display_settings, const unsigned char * from_colorspace) Line 4121 C blender.exe!IMB_colormanagement_setup_glsl_draw_from_space(const ColorManagedViewSettings * view_settings, const ColorManagedDisplaySettings * display_settings, ColorSpace * from_colorspace, float dither, bool predivide, bool do_overlay_merge) Line 4180 C blender.exe!IMB_colormanagement_setup_glsl_draw_from_space_ctx(const bContext * C, ColorSpace * from_colorspace, float dither, bool predivide) Line 4223 C blender.exe!sequencer_OCIO_transform_ibuf(const bContext * C, ImBuf * ibuf, bool * r_glsl_used, eGPUTextureFormat * r_format, eGPUDataFormat * r_data) Line 1516 C blender.exe!sequencer_draw_display_buffer(const bContext * C, Scene * scene, ARegion * region, SpaceSeq * sseq, ImBuf * ibuf, ImBuf * scope, bool draw_overlay, bool draw_backdrop) Line 1633 C blender.exe!sequencer_draw_preview(const bContext * C, Scene * scene, ARegion * region, SpaceSeq * sseq, int cfra, int offset, bool draw_overlay, bool draw_backdrop) Line 1826 C blender.exe!sequencer_preview_region_draw(const bContext * C, ARegion * region) Line 719 C blender.exe!ED_region_do_draw(bContext * C, ARegion * region) Line 552 C blender.exe!wm_draw_window_offscreen(bContext * C, wmWindow * win, bool stereo) Line 732 C blender.exe!wm_draw_window(bContext * C, wmWindow * win) Line 871 C blender.exe!wm_draw_update(bContext * C) Line 1072 C blender.exe!WM_main(bContext * C) Line 489 C blender.exe!main(int argc, const unsigned char * * UNUSED_argv_c) Line 523 C [External Code] ``` This looks to me like race condition, it's not immediately evident how to resolve though. Will have a look at this. I am not sure how legacy undo would affect reproducibility here. @daviddomingues Can you disabe prefetching in video sequencer and check if this crashes? @MarcinTwarowski can you upload file C:\Users\TwaMa\AppData\Local\Temp\Meryl.crash.txt? to make sure this is only issue here? To make sure this crashes it is important to draw and undo quickly, before prefetching is finished.

In #81250#1029681, @iss wrote:
@MarcinTwarowski can you upload file C:\Users\TwaMa\AppData\Local\Temp\Meryl.crash.txt? to make sure this is only issue here?

Here you go: Meryl.crash.txt

> In #81250#1029681, @iss wrote: > @MarcinTwarowski can you upload file C:\Users\TwaMa\AppData\Local\Temp\Meryl.crash.txt? to make sure this is only issue here? Here you go: [Meryl.crash.txt](https://archive.blender.org/developer/F8964278/Meryl.crash.txt)

@MarcinTwarowski Thanks, so yours was the same cause of crash.

@MarcinTwarowski Thanks, so yours was the same cause of crash.
Richard Antalik was assigned by Dalai Felinto 2020-10-16 11:23:40 +02:00
Dalai Felinto changed title from Blender Crashes when undoing to Crashes when undoing VSE 2020-10-16 11:40:14 +02:00

This issue was referenced by 8d1978a8e0

This issue was referenced by 8d1978a8e0131ab59e94e7e37e063db305166711

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
7 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#81250
No description provided.