Crash on Drag Collection color over to Collections #81589

New Issue

Paul Muns · 2020-10-09T23:52:00+02:00

Paul Muns commented

2020-10-09 23:52:00 +02:00

System Information
Operating system: Darwin-19.6.0-x86_64-i386-64bit 64 Bits
Graphics card: AMD Radeon Pro Vega 48 OpenGL Engine ATI Technologies Inc. 4.1 ATI-3.10.18

Blender Version
Broken: version: 2.91.0 Alpha, branch: master, commit date: 2020-10-08 22:15, hash: 2d5e38d4ec
Worked: (newest version of Blender that worked as expected)

Short description of error
[Please fill out a short description of the error here]

Exact steps for others to reproduce the error
[Please describe the exact steps needed to reproduce the issue]
[Based on the default startup or an attached .blend file (as simple as possible)]

Inside Preferences / Themes / click on Collection Colors. Click and drag (I used Purple) over to a Collection under Scene Collection. Upon arriving at the boundary of the 3D Viewport, Blender will crash.
Obviously this is not the intended way to color each Collection with an individual color ... the intended method is not apparent since clicking on any of the colors seems to do nothing.

**System Information** Operating system: Darwin-19.6.0-x86_64-i386-64bit 64 Bits Graphics card: AMD Radeon Pro Vega 48 OpenGL Engine ATI Technologies Inc. 4.1 ATI-3.10.18 **Blender Version** Broken: version: 2.91.0 Alpha, branch: master, commit date: 2020-10-08 22:15, hash: `2d5e38d4ec` Worked: (newest version of Blender that worked as expected) **Short description of error** [Please fill out a short description of the error here] **Exact steps for others to reproduce the error** [Please describe the exact steps needed to reproduce the issue] [Based on the default startup or an attached .blend file (as simple as possible)] Inside Preferences / Themes / click on Collection Colors. Click and drag (I used Purple) over to a Collection under Scene Collection. Upon arriving at the boundary of the 3D Viewport, Blender will crash. Obviously this is not the intended way to color each Collection with an individual color ... the intended method is not apparent since clicking on any of the colors seems to do nothing.![Screen Shot 2020-10-09 at 2.30.50 PM.png](https://archive.blender.org/developer/F8972504/Screen_Shot_2020-10-09_at_2.30.50_PM.png)

Paul Muns commented

2020-10-09 23:52:00 +02:00

Added subscriber: @PaulM44

Robert Guetzkow commented

2020-10-10 00:27:50 +02:00

Added subscriber: @rjg

Robert Guetzkow commented

2020-10-10 00:27:50 +02:00

I can confirm this crash with the current master. This can be reproduced by attempting to drag any color over to the outliner, not just from the theme preferences.

@PaulM44 In case this wasn't clear, the theme settings only allow you to configure the preset colors. Assigning a color to a collection is done by right-clicking on a collection in the outliner and then picking one of the color tags.

datastack_drop_init(bContext * C, const wmEvent * event, StackDropData * drop_data) Line 715	C
datastack_drop_poll(bContext * C, wmDrag * drag, const wmEvent * event, const unsigned char * * r_tooltip) Line 859	C
dropbox_active(bContext * C, ListBase * handlers, wmDrag * drag, const wmEvent * event) Line 208	C
wm_dropbox_active(bContext * C, wmDrag * drag, const wmEvent * event) Line 238	C
wm_drop_operator_options(bContext * C, wmDrag * drag, const wmEvent * event) Line 264	C
wm_drags_check_ops(bContext * C, const wmEvent * event) Line 284	C
wm_event_do_handlers(bContext * C) Line 3365	C
WM_main(bContext * C) Line 486	C
main(int argc, const unsigned char * * UNUSED_argv_c) Line 523	C

I can confirm this crash with the current master. This can be reproduced by attempting to drag any color over to the outliner, not just from the theme preferences. @PaulM44 In case this wasn't clear, the theme settings only allow you to configure the preset colors. Assigning a color to a collection is done by right-clicking on a collection in the outliner and then picking one of the color tags. ``` datastack_drop_init(bContext * C, const wmEvent * event, StackDropData * drop_data) Line 715 C datastack_drop_poll(bContext * C, wmDrag * drag, const wmEvent * event, const unsigned char * * r_tooltip) Line 859 C dropbox_active(bContext * C, ListBase * handlers, wmDrag * drag, const wmEvent * event) Line 208 C wm_dropbox_active(bContext * C, wmDrag * drag, const wmEvent * event) Line 238 C wm_drop_operator_options(bContext * C, wmDrag * drag, const wmEvent * event) Line 264 C wm_drags_check_ops(bContext * C, const wmEvent * event) Line 284 C wm_event_do_handlers(bContext * C) Line 3365 C WM_main(bContext * C) Line 486 C main(int argc, const unsigned char * * UNUSED_argv_c) Line 523 C ```

Robert Guetzkow commented

2020-10-10 00:28:20 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Paul Muns commented

2020-10-10 02:53:39 +02:00

Sorry Robert, now that I see how beautiful the menu is after RT-clicking the Collection, I feel kinda dumb. However, so many graphics programs allow this kind of drag'n'drop that it is like an atavistic action to try it. I hope it is easy to fix.

Robert Guetzkow commented

2020-10-11 12:09:43 +02:00

It appears that datastack_drop_poll doesn't check that drag->type matches the expected type and always interprets the pointer in drag->poin as a pointer to StackDropData. This is obviously not correct in case the drag and drop is for e.g. color. Interpreting the memory it points to as pointer and attempting to dereference it in datastack_drop_init by using drop_data->drag_tselem->type results in the segmentation fault.

Adding the following check to datastack_drop_poll should avoid this issue:

if (drag->type != WM_DRAG_ID) {
   return false;
}

I will post a diff shortly.

It appears that `datastack_drop_poll` doesn't check that `drag->type` matches the expected type and always interprets the pointer in `drag->poin` as a pointer to `StackDropData`. This is obviously not correct in case the drag and drop is for e.g. color. Interpreting the memory it points to as pointer and attempting to dereference it in `datastack_drop_init` by using `drop_data->drag_tselem->type` results in the segmentation fault. Adding the following check to `datastack_drop_poll` should avoid this issue: ``` if (drag->type != WM_DRAG_ID) { return false; } ``` I will post a diff shortly.

blender-admin commented

2020-10-12 23:55:40 +02:00

This issue was referenced by 8427e02abc

This issue was referenced by 8427e02abc5e7963cee14e15bc9a1c78c95d28e6

Robert Guetzkow commented

2020-10-13 01:19:47 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Robert Guetzkow closed this issue

2020-10-13 01:19:47 +02:00

Robert Guetzkow self-assigned this 2020-10-13 01:19:47 +02:00

Paul Muns commented

2020-10-13 02:35:59 +02:00

Changed status from 'Resolved' to: 'Archived'

Paul Muns commented

2020-10-13 02:35:59 +02:00

Sorry but I just downloaded the latest version and tried it a couple of times with the same result. I fear that every item in Preferences might be susceptible to this problem. Then again, how many are stupid enough to try this? Maybe time better spent elsewhere for now?

![Screen Shot 2020-10-12 at 5.22.10 PM.png](https://archive.blender.org/developer/F8984336/Screen_Shot_2020-10-12_at_5.22.10_PM.png) Sorry but I just downloaded the latest version and tried it a couple of times with the same result. I fear that every item in Preferences might be susceptible to this problem. Then again, how many are stupid enough to try this? Maybe time better spent elsewhere for now?

Robert Guetzkow commented

2020-10-13 10:48:11 +02:00

Changed status from 'Archived' to: 'Resolved'

Robert Guetzkow commented

2020-10-13 10:48:11 +02:00

@PaulM44 I've committed the change to master on October 13 at 01:17 AM CEST, so the patch wasn't included in the last daily build. Check again tomorrow and it should be fixed. If you do find other cases that cause a crash with drag and drop, please create a new bug report.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crash on Drag Collection color over to Collections #81589