Node location not handled correctly #81684

New Issue

Sergey · 2020-10-13T18:14:11+02:00

Sergey commented

2020-10-13 18:14:11 +02:00

Blender Version
version: 2.90.0, branch: master, commit date: 2020-08-31 11:26, hash: 0330d1af29

Short description of error
Position of nodes in frames is not calculated correctly when node group is created

Exact steps for others to reproduce the error
#81684.blend

Open file
Press Ctrl+G - nodes fly far away

Press Tab - node group is created far away from where selection was originally

**Blender Version** version: 2.90.0, branch: master, commit date: 2020-08-31 11:26, hash: `0330d1af29` **Short description of error** Position of nodes in frames is not calculated correctly when node group is created **Exact steps for others to reproduce the error** [#81684.blend](https://archive.blender.org/developer/F8991117/T81684.blend) - Open file - Press Ctrl+G - nodes fly far away # Press Tab - node group is created far away from where selection was originally

Sergey commented

2020-10-13 18:14:11 +02:00

Added subscriber: @randum

Sergey commented

2020-10-14 06:47:27 +02:00

It looks like it not only Python API problem. I would expect more accurate placing nodes.

It looks like it not only Python API problem. I would expect more accurate placing nodes. ![group ungroup.gif](https://archive.blender.org/developer/F8988858/group_ungroup.gif)

Richard Antalik commented

2020-10-14 21:09:40 +02:00

Added subscriber: @iss

Richard Antalik commented

2020-10-14 21:09:40 +02:00

In #81684#1033666, @randum wrote:
It looks like it not only Python API problem. I would expect more accurate placing nodes.

From this example it looks like UI code is little bit confused as well.

The location property here is in "parent" space. So frame does have location, and node does have location as well. Node is "owned" or "parrented" by frame, but frame doesnt get proper absolute location and it has to be calculated from it's child. So to get overall location you have to add both locations, or substract, depending on what you want to target. And resulting math may be counter intuitive.

This is not bug though and probably won't be resolved anytime soon. But nodes jumping around in UI I would say could be, though it is also just minor inconvinience I would say.

> In #81684#1033666, @randum wrote: > It looks like it not only Python API problem. I would expect more accurate placing nodes. > ![group ungroup.gif](https://archive.blender.org/developer/F8988858/group_ungroup.gif) From this example it looks like UI code is little bit confused as well. The location property here is in "parent" space. So frame does have location, and node does have location as well. Node is "owned" or "parrented" by frame, but frame doesnt get proper absolute location and it has to be calculated from it's child. So to get overall location you have to add both locations, or substract, depending on what you want to target. And resulting math may be counter intuitive. This is not bug though and probably won't be resolved anytime soon. But nodes jumping around in UI I would say could be, though it is also just minor inconvinience I would say.

Richard Antalik changed title from ~~Frame node location~~ to Node location not handled correctly

2020-10-14 21:15:44 +02:00

Richard Antalik commented

2020-10-14 21:15:44 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Sergey commented

2020-10-15 06:15:12 +02:00

frame doesnt get proper absolute location and it has to be calculated from it's child.

If child of frame was deleted how to calculate frame location relatively to tree origin?

> frame doesnt get proper absolute location and it has to be calculated from it's child. If child of frame was deleted how to calculate frame location relatively to tree origin?

Richard Antalik commented

2020-10-15 17:52:53 +02:00

In #81684#1034545, @randum wrote:

frame doesnt get proper absolute location and it has to be calculated from it's child.

If child of frame was deleted how to calculate frame location relatively to tree origin?

I see that this looks impossible. nodes have internal offset property that is not exposed through API.

We still don't consider this to be a bug - see https://wiki.blender.org/wiki/Reference/Not_a_bug

> In #81684#1034545, @randum wrote: >> frame doesnt get proper absolute location and it has to be calculated from it's child. > > If child of frame was deleted how to calculate frame location relatively to tree origin? I see that this looks impossible. nodes have internal offset property that is not exposed through API. We still don't consider this to be a bug - see https://wiki.blender.org/wiki/Reference/Not_a_bug

Sergey commented

2020-10-16 06:42:01 +02:00

We still don't consider this to be a bug

No complaints but I wish Blender could get API improvements in this domain.

> We still don't consider this to be a bug No complaints but I wish Blender could get API improvements in this domain.

blender-admin commented

2020-10-20 10:51:19 +02:00

This issue was referenced by f3ecb4c91e

This issue was referenced by f3ecb4c91e159caff2e6d335adb1ccf06423c90f

Jacques Lucke commented

2020-10-20 10:54:10 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Jacques Lucke closed this issue

2020-10-20 10:54:10 +02:00

Jacques Lucke self-assigned this 2020-10-20 10:54:10 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Node location not handled correctly #81684

Press Tab - node group is created far away from where selection was originally