Image data not properly duplicated in node_shader_utils.py #81834

New Issue

TZ · 2020-10-19T10:58:51+02:00

TZ commented

2020-10-19 10:58:51 +02:00

System Information
Operating system: Windows 10
Graphics card: NVIDIA Quadpro P4000

Blender Version
Broken: 2.90.1

Short description of error
There seems to be a bug in [node_shader_utils.py ]], possibly introduced in [ https:*developer.blender.org/rBd89b65cc91a63544168b5330ba1a288f5c826e15 | this commit . Around line 700, in the image property setter, the third if statement compares is_data again, instead of the colorspace name:

    @_set_check
    def image_set(self, image):
        if self.colorspace_is_data is not ...:
            if image.colorspace_settings.is_data != self.colorspace_is_data and image.users >= 1:
                image = image.copy()
            image.colorspace_settings.is_data = self.colorspace_is_data
        if self.colorspace_name is not ...:
            if image.colorspace_settings.is_data != self.colorspace_is_data and image.users >= 1: // Should this not compare names?
                image = image.copy()
            image.colorspace_settings.name = self.colorspace_name
        self.node_image.image = image

Exact steps for others to reproduce the error
Run the script below:

import bpy
from bpy_extras.node_shader_utils import PrincipledBSDFWrapper
from bpy_extras.image_utils import load_image

# load an image
blender_image = load_image('c:\\tmp\\image.png', check_existing=True)
blender_material = bpy.data.materials.new(name='Material_1')
blender_principled = PrincipledBSDFWrapper(blender_material, is_readonly=False)
blender_principled.specular_texture.image = blender_image
blender_material2 = bpy.data.materials.new(name='Material_2')
blender_principled2 = PrincipledBSDFWrapper(blender_material, is_readonly=False)
blender_principled2.specular_texture.image = blender_image

**System Information** Operating system: Windows 10 Graphics card: NVIDIA Quadpro P4000 **Blender Version** Broken: 2.90.1 **Short description of error** There seems to be a bug in [node_shader_utils.py ]], possibly introduced in [[ https:*developer.blender.org/rBd89b65cc91a63544168b5330ba1a288f5c826e15 | this commit ](https:*developer.blender.org/diffusion/B/browse/master/release/scripts/modules/bpy_extras/node_shader_utils.py). Around line 700, in the image property setter, the third if statement compares is_data again, instead of the colorspace name: ``` @_set_check def image_set(self, image): if self.colorspace_is_data is not ...: if image.colorspace_settings.is_data != self.colorspace_is_data and image.users >= 1: image = image.copy() image.colorspace_settings.is_data = self.colorspace_is_data if self.colorspace_name is not ...: if image.colorspace_settings.is_data != self.colorspace_is_data and image.users >= 1: // Should this not compare names? image = image.copy() image.colorspace_settings.name = self.colorspace_name self.node_image.image = image ``` **Exact steps for others to reproduce the error** Run the script below: ``` import bpy from bpy_extras.node_shader_utils import PrincipledBSDFWrapper from bpy_extras.image_utils import load_image # load an image blender_image = load_image('c:\\tmp\\image.png', check_existing=True) blender_material = bpy.data.materials.new(name='Material_1') blender_principled = PrincipledBSDFWrapper(blender_material, is_readonly=False) blender_principled.specular_texture.image = blender_image blender_material2 = bpy.data.materials.new(name='Material_2') blender_principled2 = PrincipledBSDFWrapper(blender_material, is_readonly=False) blender_principled2.specular_texture.image = blender_image ```

TZ commented

2020-10-19 10:58:51 +02:00

Added subscriber: @ttass

Philipp Oeser commented

2020-10-19 14:42:52 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2020-10-19 14:42:52 +02:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Philipp Oeser commented

2020-10-19 14:42:52 +02:00

I think you are right, just to make sure:
Could you throw together a simple example that exposes this bug?

I think you are right, just to make sure: Could you throw together a simple example that exposes this bug?

TZ commented

2020-10-19 17:05:14 +02:00

Assuming there is a file image.png located in C:/tmp, this will result in two images being created:

from bpy_extras.node_shader_utils import PrincipledBSDFWrapper
from bpy_extras.image_utils import load_image
import bpy
# load an image
blender_image = load_image('c:\\tmp\\image.png', check_existing=True)
blender_material = bpy.data.materials.new(name='Material_1')
blender_principled = PrincipledBSDFWrapper(blender_material, is_readonly=False)
blender_principled.specular_texture.image = blender_image
blender_material2 = bpy.data.materials.new(name='Material_2')
blender_principled2 = PrincipledBSDFWrapper(blender_material, is_readonly=False)
blender_principled2.specular_texture.image = blender_image

Assuming there is a file image.png located in C:/tmp, this will result in two images being created: ``` from bpy_extras.node_shader_utils import PrincipledBSDFWrapper from bpy_extras.image_utils import load_image import bpy # load an image blender_image = load_image('c:\\tmp\\image.png', check_existing=True) blender_material = bpy.data.materials.new(name='Material_1') blender_principled = PrincipledBSDFWrapper(blender_material, is_readonly=False) blender_principled.specular_texture.image = blender_image blender_material2 = bpy.data.materials.new(name='Material_2') blender_principled2 = PrincipledBSDFWrapper(blender_material, is_readonly=False) blender_principled2.specular_texture.image = blender_image ```

Robert Guetzkow commented

2020-11-13 13:55:38 +01:00

Changed status from 'Needs User Info' to: 'Confirmed'