Viewport animation render crashes when collapsing the viewport. #82000

New Issue

user1 · 2020-10-23T11:53:46+02:00

user1 commented

2020-10-23 11:53:46 +02:00

Blender Version
Broken: version: 2.91.0 Beta, branch: master, commit date: 2020-10-21 22:57, hash: b0f34eee30 (and 2.83, 2.80, ...)
Worked: never

Short description of error
Viewport animation render crashes when collapsing the viewport.

Exact steps for others to reproduce the error
0001-0485.mp4
Viewport render crash.blend

**Blender Version** Broken: version: 2.91.0 Beta, branch: master, commit date: 2020-10-21 22:57, hash: `b0f34eee30` (and 2.83, 2.80, ...) Worked: never **Short description of error** Viewport animation render crashes when collapsing the viewport. **Exact steps for others to reproduce the error** [0001-0485.mp4](https://archive.blender.org/developer/F9047282/0001-0485.mp4) [Viewport render crash.blend](https://archive.blender.org/developer/F9047283/Viewport_render_crash.blend)

user1 commented

2020-10-23 11:53:46 +02:00

Added subscriber: @user1

Robert Guetzkow commented

2020-10-23 12:49:49 +02:00

Added subscriber: @rjg

Robert Guetzkow commented

2020-10-23 12:49:49 +02:00

I can confirm this issue. ED_view3d_draw_offscreen_imbuf seems to get passed invalid pointers to region and v3d.

ED_view3d_draw_offscreen_imbuf(Depsgraph * depsgraph, Scene * scene, eDrawType drawtype, View3D * v3d, ARegion * region, int sizex, int sizey, eImBufFlags imbuf_flag, int alpha_mode, const unsigned char * viewname, GPUOffScreen * ofs, unsigned char * err_out) Line 1889	C
screen_opengl_render_doit(const bContext * C, OGLRender * oglrender, RenderResult * rr) Line 373	C
screen_opengl_render_apply(const bContext * C, OGLRender * oglrender) Line 514	C
screen_opengl_render_anim_step(bContext * C, wmOperator * op) Line 1187	C
screen_opengl_render_modal(bContext * C, wmOperator * op, const wmEvent * event) Line 1239	C
wm_handler_operator_call(bContext * C, ListBase * handlers, wmEventHandler * handler_base, wmEvent * event, PointerRNA * properties, const unsigned char * kmi_idname) Line 2022	C
wm_handlers_do_intern(bContext * C, wmEvent * event, ListBase * handlers) Line 2803	C
wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Line 2851	C
wm_event_do_handlers(bContext * C) Line 3273	C
WM_main(bContext * C) Line 479	C
main(int argc, const unsigned char * * UNUSED_argv_c) Line 523	C

I can confirm this issue. `ED_view3d_draw_offscreen_imbuf` seems to get passed invalid pointers to `region` and `v3d`. ``` ED_view3d_draw_offscreen_imbuf(Depsgraph * depsgraph, Scene * scene, eDrawType drawtype, View3D * v3d, ARegion * region, int sizex, int sizey, eImBufFlags imbuf_flag, int alpha_mode, const unsigned char * viewname, GPUOffScreen * ofs, unsigned char * err_out) Line 1889 C screen_opengl_render_doit(const bContext * C, OGLRender * oglrender, RenderResult * rr) Line 373 C screen_opengl_render_apply(const bContext * C, OGLRender * oglrender) Line 514 C screen_opengl_render_anim_step(bContext * C, wmOperator * op) Line 1187 C screen_opengl_render_modal(bContext * C, wmOperator * op, const wmEvent * event) Line 1239 C wm_handler_operator_call(bContext * C, ListBase * handlers, wmEventHandler * handler_base, wmEvent * event, PointerRNA * properties, const unsigned char * kmi_idname) Line 2022 C wm_handlers_do_intern(bContext * C, wmEvent * event, ListBase * handlers) Line 2803 C wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Line 2851 C wm_event_do_handlers(bContext * C) Line 3273 C WM_main(bContext * C) Line 479 C main(int argc, const unsigned char * * UNUSED_argv_c) Line 523 C ```

Robert Guetzkow commented

2020-10-23 12:50:08 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Robert Guetzkow commented

2020-10-23 13:18:24 +02:00

This also affects Blender 2.83.x and all previous versions as far back as 2.80.

Dalai Felinto commented

2020-10-23 18:51:59 +02:00

Added subscriber: @dfelinto

Dalai Felinto commented

2020-10-23 18:51:59 +02:00

Sorry but this is not a high priority bug. We had this for a long time it seems. It would be nice to fix of course, but as far as I see, this is not a priority for 2.91.

(also think this is probably a good first issue, but let that not stop anyone from fixing it)

Sorry but this is not a high priority bug. We had this for a long time it seems. It would be nice to fix of course, but as far as I see, this is not a priority for 2.91. (also think this is probably a good first issue, but let that not stop anyone from fixing it)

Robert Guetzkow commented

2020-10-23 19:05:04 +02:00

@dfelinto Sure, no problem. I triaged it as high since it results in a crash and I wasn't sure if it's in the "really obscure" category from the triaging playbook to warrant a lower priority.

Ketan Jain commented

2020-10-23 20:17:21 +02:00

Added subscriber: @ketanjainn

Ketan Jain commented

2020-10-23 20:17:21 +02:00

Can someone help get started with this? I am a complete beginner developer.

Robert Guetzkow commented

2020-10-23 20:46:57 +02:00

@ketanjainn We have an introduction for new developers on [Blender's wiki ]]. The first step would be to familiarize yourself with how https:*wiki.blender.org/wiki/Developer_Intro/Overview , setup your https:*wiki.blender.org/wiki/Developer_Intro/Environment and https:*wiki.blender.org/wiki/Building_Blender . Once that is done you can start diving into Blender's source code. It may help to learn about concepts used in https:*wiki.blender.org/wiki/Source . Don't worry, you don't have to understand everything right away. If you have further questions, that are unrelated to this ticket, I would suggest you join the https:*blender.chat/channel/blender-coders channel and ask them there if they are short. Longer posts or questions related to the developement that can't be quickly answered in chat are best suited for [ https://devtalk.blender.org/c/blender | DevTalk .

@ketanjainn We have an introduction for new developers on [Blender's wiki ]]. The first step would be to familiarize yourself with how [[ https:*wiki.blender.org/wiki/Developer_Intro/Overview | Blender's development is organized ]], setup your [[ https:*wiki.blender.org/wiki/Developer_Intro/Environment | development environment ]] and [[ https:*wiki.blender.org/wiki/Building_Blender | build Blender ]]. Once that is done you can start diving into Blender's source code. It may help to learn about concepts used in [[ https:*wiki.blender.org/wiki/Source | Blender's architecture ]]. Don't worry, you don't have to understand everything right away. If you have further questions, that are unrelated to this ticket, I would suggest you join the [[ https:*blender.chat/channel/blender-coders | #blender-coders ]] channel and ask them there if they are short. Longer posts or questions related to the developement that can't be quickly answered in chat are best suited for [[ https://devtalk.blender.org/c/blender | DevTalk ](https:*wiki.blender.org/wiki/Developer_Intro).

Ketan Jain commented

2020-10-24 12:05:32 +02:00

@rjg I have already done, the above-mentioned steps. The next thing I am facing problem is how to start solving this particular issue. Since according to the documentation it was recommended to work on A "Good-First-Issue" as above

Robert Guetzkow commented

2020-10-24 13:45:50 +02:00

@ketanjainn I'll have to take another look at the code myself in order to give you pointers in the right direction. I would suggest we continue this conversation either on [#blender-coders ]] or in a [ https:*blender.chat/direct/rjg/ | direct chat .

@ketanjainn I'll have to take another look at the code myself in order to give you pointers in the right direction. I would suggest we continue this conversation either on [#blender-coders ]] or in a [[ https:*blender.chat/direct/rjg/ | direct chat ](https:*blender.chat/channel/blender-coders).

Janusch Patas commented

2020-10-24 13:50:04 +02:00

Added subscriber: @patjan

Janusch Patas self-assigned this 2020-10-24 13:50:04 +02:00

Janusch Patas commented

2020-10-24 13:50:04 +02:00

You can find my suggested fix here: https://developer.blender.org/D9334