Handle Deletion of Asset Data-Blocks nicely #82162

New Issue

Julian Eisel · 2020-10-27T18:02:45+01:00

Julian Eisel commented

2020-10-27 18:02:45 +01:00

When deleting a data-block that is an asset:

Show a warning?
How to deal with user-counts? Currently creating an asset sets a fake user to make sure the asset is kept even if not used locally. If the data-block is explicitly deleted, that user should be removed since ID deletion expects there to be 0 users at this point .

When deleting a data-block that is an asset: * Show a warning? * How to deal with user-counts? Currently creating an asset sets a fake user to make sure the asset is kept even if not used locally. If the data-block is explicitly deleted, that user should be removed since ID deletion [expects there to be 0 users at this point ](https://developer.blender.org/diffusion/B/browse/master/source/blender/blenkernel/intern/lib_id_delete.c$357).

Julian Eisel commented

2020-10-27 18:02:45 +01:00

Added subscriber: @JulianEisel

Demeter Dzadik commented

2021-08-20 15:58:09 +02:00

Added subscriber: @Mets

Demeter Dzadik commented

2021-08-20 15:58:09 +02:00

I think this would be a non-issue if users actually knew what's going on when they think they delete something.
Currently, un-linking and deleting are confusing:

Pressing X in the 3D viewport pretends to be deleting data, when it's just unlinking. I would change this prompt from OK?/Delete to Unlink from "View Layer"?/Unlink. Could even add a "Delete From File" option here.
Meanwhile, pressing X in the Outliner will nuke the datablock out of existence, without even asking for confirmation. It could have the same exact pop-up, at least when the Outliner is in View Layer mode.

This way the user would know that unlinking is different from deleting, and I think the difference itself would be intuitive. So when they choose Delete From File, they won't be surprised (or will be pleasantly surprised) when they see that asset is also gone.

I think this would be a non-issue if users actually knew what's going on when they think they delete something. Currently, un-linking and deleting are confusing: - Pressing X in the 3D viewport pretends to be deleting data, when it's just unlinking. I would change this prompt from `OK?/Delete` to `Unlink from "View Layer"?/Unlink`. Could even add a "Delete From File" option here. - Meanwhile, pressing X in the Outliner will nuke the datablock out of existence, without even asking for confirmation. It could have the same exact pop-up, at least when the Outliner is in View Layer mode. This way the user would know that unlinking is different from deleting, and I think the difference itself would be intuitive. So when they choose `Delete From File`, they won't be surprised (or will be pleasantly surprised) when they see that asset is also gone.

Sybren A. Stüvel commented

2021-10-11 14:35:10 +02:00

Changed status from 'Needs Triage' to: 'Archived'

Sybren A. Stüvel closed this issue

2021-10-11 14:35:10 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Handle Deletion of Asset Data-Blocks nicely #82162