Transform Modal Map - double entry Automatic Constraint #82423

New Issue

Reiner Prokein · 2020-11-05T09:49:57+01:00

Reiner Prokein commented

2020-11-05 09:49:57 +01:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 456.43

Blender Version
Broken: version: 2.92.0 Alpha, branch: master, commit date: 2020-11-01 08:11, hash: a1f46ac9dc
Worked: (newest version of Blender that worked as expected)

Short description of error
The automatic constraint in the transform modal map is doubled

Exact steps for others to reproduce the error
[Please describe the exact steps needed to reproduce the issue]
[Based on the default startup or an attached .blend file (as simple as possible)]

Open Blender, move the default cube, watch the footer. Two entries for Automatic Constraint.

There are also two entries in the modal keymap and in the property value popup.

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 456.43 **Blender Version** Broken: version: 2.92.0 Alpha, branch: master, commit date: 2020-11-01 08:11, hash: `a1f46ac9dc` Worked: (newest version of Blender that worked as expected) **Short description of error** The automatic constraint in the transform modal map is doubled **Exact steps for others to reproduce the error** [Please describe the exact steps needed to reproduce the issue] [Based on the default startup or an attached .blend file (as simple as possible)] Open Blender, move the default cube, watch the footer. Two entries for Automatic Constraint. There are also two entries in the modal keymap and in the property value popup. ![automatic1.jpg](https://archive.blender.org/developer/F9206243/automatic1.jpg) ![automatic2.jpg](https://archive.blender.org/developer/F9206245/automatic2.jpg)

Reiner Prokein commented

2020-11-05 09:49:57 +01:00

Added subscriber: @tiles

Robert Guetzkow commented

2020-11-05 10:04:52 +01:00

Added subscriber: @rjg

Robert Guetzkow commented

2020-11-05 10:04:52 +01:00

This appears to be caused by the following two enum property items in transform_modal_keymap (transform.c) that have the same display name:

      {TFM_MODAL_AUTOCONSTRAINT, "AUTOCONSTRAIN", 0, "Automatic Constraint", ""},
      {TFM_MODAL_AUTOCONSTRAINTPLANE, "AUTOCONSTRAINPLANE", 0, "Automatic Constraint", ""},

I think the second one should be renamed to "Automatic Constraint Plane".

This appears to be caused by the following two enum property items in `transform_modal_keymap` (`transform.c`) that have the same display name: ``` {TFM_MODAL_AUTOCONSTRAINT, "AUTOCONSTRAIN", 0, "Automatic Constraint", ""}, {TFM_MODAL_AUTOCONSTRAINTPLANE, "AUTOCONSTRAINPLANE", 0, "Automatic Constraint", ""}, ``` I think the second one should be renamed to "Automatic Constraint Plane".

Robert Guetzkow commented

2020-11-05 10:12:44 +01:00

Added subscriber: @mano-wii

Robert Guetzkow commented

2020-11-05 10:12:44 +01:00

This entry was create by ba014586a0.
@mano-wii Based on the commit message I'm not sure if the same name was intentional?

This entry was create by ba014586a0. @mano-wii Based on the commit message I'm not sure if the same name was intentional?

Reiner Prokein commented

2020-11-05 18:28:22 +01:00

Ah, i see. So the one is meant to move along an axis, the other to move along a plane. The second one doesn't really work well though, tried it with another hotkey. And this needs of course also another hotkey then. Both have at the moment mmb assigned.

Robert Guetzkow commented

2020-11-05 19:38:51 +01:00

@tiles ~~They already have different shortcuts by default, one is {key MMB} and one is {key Shift MMB}. Apparently the {key Shift} isn't displayed in the status bar though.~~ While it was using shift in the referenced commit, the shortcut was changed in another one.

@tiles ~~They already have different shortcuts by default, one is {key MMB} and one is {key Shift MMB}. Apparently the {key Shift} isn't displayed in the status bar though.~~ While it was using shift in the referenced commit, the shortcut was changed in another one.

Reiner Prokein commented

2020-11-05 20:41:26 +01:00

It's also not displayed in the keymap :)

Reiner Prokein commented

2020-11-05 20:44:13 +01:00

Just tested. I can't get this arrow up +mmb hotkey combination to work. It constraints still along the single axis.

Robert Guetzkow commented

2020-11-05 20:49:30 +01:00

This comment was removed by @rjg

*This comment was removed by @rjg*

Reiner Prokein commented

2020-11-05 20:59:07 +01:00

And shift conflicts with precision movement then. Seems that we found a can of worms here ^^

Robert Guetzkow commented

2020-11-05 21:04:46 +01:00

@tiles I'm sorry, I was wrong. It was using Shift in the referenced commit, but has been removed in f5080c82dd. I think this was by accident though, as the commit message states that it intended to only remove the "repeat".

@tiles I'm sorry, I was wrong. It was using Shift in the referenced commit, but has been removed in f5080c82dd. I think this was by accident though, as the commit message states that it intended to only remove the "repeat".

Germano Cavalcante commented

2020-11-05 21:25:35 +01:00

In #82423#1048942, @tiles wrote:
And shift conflicts with precision movement then. Seems that we found a can of worms here ^^

This is a well-known old conflict.
I don't know whose idea it was, but it has already been established that way.

> In #82423#1048942, @tiles wrote: > And shift conflicts with precision movement then. Seems that we found a can of worms here ^^ This is a well-known old conflict. I don't know whose idea it was, but it has already been established that way.

blender-admin commented

2020-11-05 21:26:54 +01:00

This issue was referenced by 7fed420877

This issue was referenced by 7fed420877bd22a0f0745353ba6a992d6c05a6f4

Robert Guetzkow commented

2020-11-05 21:31:48 +01:00

Changed status from 'Needs Triage' to: 'Resolved'

Robert Guetzkow closed this issue

2020-11-05 21:31:48 +01:00

Robert Guetzkow self-assigned this 2020-11-05 21:31:48 +01:00

Robert Guetzkow commented

2020-11-05 22:37:22 +01:00