AMD GPU Denoising via "Radeon Image Filters" library. #82559

Closed
opened 2020-11-10 02:07:58 +01:00 by Brian Savery (AMD) · 19 comments

Overview
This task is to enable GPU denoising on AMD GPUs. We have a denoising library (https://github.com/GPUOpen-LibrariesAndSDKs/RadeonImageFilter) publically available which operates similarly to OIDN, Optix, etc. We would like to use this to enable faster GPU denoising for users on AMD hardware. It should be noted, this library actually works on other GPUs and CPU (the latter via OIDN) but on Nvidia GPUs, the Optix denoiser will most likely be more optimal.

GPL compliance
We offer the library free under a permissive Apache2 license at the link above. However, it is not open source. A shortly upcoming version of the AMD driver on windows will include this RIF library. Thus we propose to use it similarly as Optix, as a closed source "system device" library exception to the GPL.

Code design
We added a new denoiser type, AMD Radeon Image Filter, with similar options to Optix Denoising to enable usage.

Patch coming soon.

**Overview** This task is to enable GPU denoising on AMD GPUs. We have a denoising library (https://github.com/GPUOpen-LibrariesAndSDKs/RadeonImageFilter) publically available which operates similarly to OIDN, Optix, etc. We would like to use this to enable faster GPU denoising for users on AMD hardware. It should be noted, this library actually works on other GPUs and CPU (the latter via OIDN) but on Nvidia GPUs, the Optix denoiser will most likely be more optimal. **GPL compliance** We offer the library free under a permissive Apache2 license at the link above. However, it is not open source. A shortly upcoming version of the AMD driver on windows will include this RIF library. Thus we propose to use it similarly as Optix, as a closed source "system device" library exception to the GPL. **Code design** We added a new denoiser type, AMD Radeon Image Filter, with similar options to Optix Denoising to enable usage. Patch coming soon.
Brian Savery (AMD) self-assigned this 2020-11-10 02:07:58 +01:00
Author
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Author
Member

Added subscriber: @BrianSavery

Added subscriber: @BrianSavery
Author
Member

Looking for feedback on licensing approach. But as we see it, this is directly in line with the current usage of Optix Denoising library.

Looking for feedback on licensing approach. But as we see it, this is directly in line with the current usage of Optix Denoising library.

Added subscriber: @SteffenD

Added subscriber: @SteffenD

Added subscriber: @GeorgiaPacific

Added subscriber: @GeorgiaPacific

Added subscriber: @blenderrocket

Added subscriber: @blenderrocket
Member

Added subscriber: @Jeroen-Bakker

Added subscriber: @Jeroen-Bakker

Added subscriber: @Jaydead

Added subscriber: @Jaydead
Member

Added subscriber: @Stefan_Werner

Added subscriber: @Stefan_Werner

Added subscriber: @PietroEliaAppeddu

Added subscriber: @PietroEliaAppeddu

Added subscriber: @dabuxian

Added subscriber: @dabuxian

Added subscriber: @Grady

Added subscriber: @Grady

Would this work with existing AMD GPUs, such as the 5000 series?

Would this work with existing AMD GPUs, such as the 5000 series?

Added subscriber: @higgsas

Added subscriber: @higgsas

Added subscriber: @AndreaMonzini

Added subscriber: @AndreaMonzini

Hello,

  • why the library is not open source if it is released under Apache License 2.0 ?
  • will the library be supported on GNU/Linux too?
    Thank you.
Hello, - why the library is not open source if it is released under Apache License 2.0 ? - will the library be supported on GNU/Linux too? Thank you.

Added subscriber: @ephraimpauli

Added subscriber: @ephraimpauli

Added subscriber: @2905710881

Added subscriber: @2905710881
Brecht Van Lommel added this to the Render & Cycles project 2023-02-07 19:08:35 +01:00

I think we can close this now that there is OpenImageDenoise with HIP support.

I think we can close this now that there is OpenImageDenoise with HIP support.
Blender Bot added
Status
Archived
and removed
Status
Confirmed
labels 2024-01-04 11:58:22 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
15 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#82559
No description provided.