Custom normals doesn't properly sets on corner cases using "Set From Faces" #82722
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#82722
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
System Information
Operating system: Windows-10-10.0.17763-SP0 64 Bits
Graphics card: GeForce GTX 1050 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 445.87
Blender Version
Broken: version: 2.92.0 Alpha, branch: master, commit date: 2020-11-14 08:44, hash:
a3ce05d00e
Worked: (newest version of Blender that worked as expected)
Short description of error
When there is two faces with sharp edges "Set From Faces" operator doesn't seem to perform as intended - it produces one normal instead of two separate.
Exact steps for others to reproduce the error
Use attached .blend for testing
set_from_faces.blend
Added subscriber: @DotBow
Added subscriber: @lichtwerk
Changed status from 'Needs Triage' to: 'Confirmed'
This is indeed unexpected, not sure this is really a bug though.
Code checks all participating edges of participating faces and if it finds one that is smooth it will do the averaging.
Think we can improve here though and check if the participating edge has only one face (in that case, it should not count as smooth)
Will keep on my desk as TODO.
Thanks for looking into it!
I found out this one when trying to work with custom normals and writing some helpers in python.
There is a hacky way to fix it via python by splitting and then merging hard edges, but this is not ideal and has bad performance.
The strange part is that it works correctly on three faces corner (look at gif) but not on two faces.
It is very important feature for project I'm working on right now in a studio using midpoly pipeline.
For the three faces corner, every edge touching the vert is sharp, but as soon as one edge isnt (2 face example), it will average
Oh, I see. Then it means I need at least to make three different operations to straighten the normals for this case:
Changed status from 'Confirmed' to: 'Needs Developer To Reproduce'
Got a patch that works in these examples, but fails in others.
Maybe it is acceptable [even if unexpected in certain scenarios] that only if all edges touching a loop need to be marked sharp?
Cannot decide here, will step down and let the module owners decide...