Ensure "Current File" repository stays in sync with main data-base #83242

Closed
opened 2020-11-30 16:28:40 +01:00 by Julian Eisel · 5 comments
Member

Deleting data-blocks, "unmaking" assets, loading a .blend without UI, etc shouldn't cause the Asset Browser to reference invalid data.
It currently references the preview and asset-data of asset data-blocks. This is fragile.
We already store the ID.session_uuid and could use that to sanity check the references before access.

Besides this memory issue, we could just make sure the file list is refreshed for relevant notifiers while Current File is shown. If the list still ends up being outdated then, there at least won't be a crash/undefined behavior.

Also see #82162.

Deleting data-blocks, "unmaking" assets, loading a .blend without UI, etc shouldn't cause the Asset Browser to reference invalid data. It currently references the preview and asset-data of asset data-blocks. This is fragile. We already store the `ID.session_uuid` and could use that to sanity check the references before access. Besides this memory issue, we could just make sure the file list is refreshed for relevant notifiers while *Current File* is shown. If the list still ends up being outdated then, there at least won't be a crash/undefined behavior. Also see #82162.
Author
Member

Added subscriber: @JulianEisel

Added subscriber: @JulianEisel
Author
Member

Must be done before the merge. Setting to high priority.

Must be done before the merge. Setting to high priority.
Author
Member

Addressed with d6e19e73b8.

Addressed with d6e19e73b8.
Author
Member

Changed status from 'Needs Triage' to: 'Resolved'

Changed status from 'Needs Triage' to: 'Resolved'
Julian Eisel self-assigned this 2021-04-09 00:04:33 +02:00
Author
Member

Closing all tasks in the "Done" column of the #asset_browser_milestone_1.

Closing all tasks in the "Done" column of the #asset_browser_milestone_1.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#83242
No description provided.