Change Brush size does not show Falloff gradient anymore #83603

New Issue

Kent Davis · 2020-12-09T22:18:00+01:00

Kent Davis commented

2020-12-09 22:18:00 +01:00

System Information
Operating system: Darwin-20.2.0-x86_64-i386-64bit 64 Bits
Graphics card: AMD Radeon Pro 575 OpenGL Engine ATI Technologies Inc. 4.1 ATI-4.2.11

Blender Version
Broken: version: 2.92.0 Alpha, branch: master, commit date: 2020-12-07 22:51, hash: ab9952e55f
Broken: 2.81
Worked: 2.80

Caused by be985bdde2

Short description of error
Change Brush size does not show Falloff gradient anymore

Exact steps for others to reproduce the error

Enter Texture Paint mode (or sculpt mode, vertexpaint mode, ...)
use {key F} to change brush size: no falloff shown
use {key Shift F} to change brush strength: falloff shown

This was not the case in 2.79 or 2.80

Turns out whenever radial control is used for something other than PROP_NONE, PROP_PIXEL, PROP_DISTANCE, it draws with the (falloff) gradient, in our case [brush size], it draws without. Think this is useful information which does not really distract?

**System Information** Operating system: Darwin-20.2.0-x86_64-i386-64bit 64 Bits Graphics card: AMD Radeon Pro 575 OpenGL Engine ATI Technologies Inc. 4.1 ATI-4.2.11 **Blender Version** Broken: version: 2.92.0 Alpha, branch: master, commit date: 2020-12-07 22:51, hash: `ab9952e55f` Broken: 2.81 Worked: 2.80 Caused by be985bdde2 **Short description of error** Change Brush size does not show Falloff gradient anymore **Exact steps for others to reproduce the error** - Enter Texture Paint mode (or sculpt mode, vertexpaint mode, ...) - use {key F} to change brush size: no falloff shown - use {key Shift F} to change brush strength: falloff shown This was not the case in 2.79 or 2.80 Turns out whenever radial control is used for something other than PROP_NONE, PROP_PIXEL, PROP_DISTANCE, it draws with the (falloff) gradient, in our case [brush size], it draws without. Think this is useful information which does not really distract?

Kent Davis commented

2020-12-09 22:18:00 +01:00

Added subscriber: @Kent-Davis

Kent Davis commented

2020-12-19 01:34:44 +01:00

Hello?

Germano Cavalcante commented

2020-12-22 15:26:09 +01:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2020-12-22 15:26:09 +01:00

I also can't see the black Falloff circle here.
It must be by design.
I'm not sure if it's really a bug.

I also can't see the black Falloff circle here. It must be by design. I'm not sure if it's really a bug.

Philipp Oeser commented

2020-12-22 16:12:31 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2020-12-22 16:12:31 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser self-assigned this 2020-12-22 16:12:31 +01:00

Philipp Oeser commented

2020-12-22 16:12:31 +01:00

It does display when a texture mask texture https://docs.blender.org/manual/en/dev/sculpt_paint/brush/texture.html#texture-mask is specified.
You can set one to pure white to get the desired effect, but maybe this could be done by default yes.

In Fact, 2.79 and 2.80 still did that, so I would confirm this.
Will also check on this.

It does display when a texture mask texture https://docs.blender.org/manual/en/dev/sculpt_paint/brush/texture.html#texture-mask is specified. You can set one to pure white to get the desired effect, but maybe this could be done by default yes. In Fact, 2.79 and 2.80 still did that, so I would confirm this. Will also check on this.

Kent Davis commented

2020-12-22 16:37:44 +01:00

Push the 'F' key doesn't appear falloff black circle show display.
Push the 'Shift+F' yes show number and falloff black circle show display.
Push the 'Command+F' yes show number and fall black circle show display.

That is not TEXTURE PAINT.

Push the 'F' key doesn't appear falloff black circle show display. Push the 'Shift+F' yes show number and falloff black circle show display. Push the 'Command+F' yes show number and fall black circle show display. That is not TEXTURE PAINT.

Philipp Oeser removed their assignment 2020-12-22 17:41:26 +01:00

Philipp Oeser commented

2020-12-22 17:41:26 +01:00

Added subscribers: @PabloDobarro, @JulienKaspar, @Jeroen-Bakker, @ideasman42, @pablovazquez

Philipp Oeser commented

2020-12-22 17:41:26 +01:00

Seems like this was a somewhat intentional change in be985bdde2

Also see this comment in D5889

In D5889 #135588, @PabloDobarro wrote:

Hide gradient when resizing

So whenever radial control is used for something other than PROP_NONE, PROP_PIXEL, PROP_DISTANCE, it draws with the (falloff) gradient, in our case [brush size], it draws without.
Not sure I can follow that logic (think this is useful information which does not really distract), but will let module members decide...

Use this to always show it:
P1853: #83603 snippet



diff --git a/source/blender/windowmanager/intern/wm_operators.c b/source/blender/windowmanager/intern/wm_operators.c
index a5b5f082c41..07a0690a3f2 100644
--- a/source/blender/windowmanager/intern/wm_operators.c
+++ b/source/blender/windowmanager/intern/wm_operators.c
@@ -2187,7 +2187,7 @@ static void radial_control_set_tex(RadialControl *rc)
       if ((ibuf = BKE_brush_gen_radial_control_imbuf(
                rc->image_id_ptr.data,
                rc->use_secondary_tex,
-               !ELEM(rc->subtype, PROP_NONE, PROP_PIXEL, PROP_DISTANCE)))) {
+               true))) {
 
         rc->texture = GPU_texture_create_2d(
             "radial_control", ibuf->x, ibuf->y, 1, GPU_R8, ibuf->rect_float);

CC @PabloDobarro
CC @JulienKaspar
CC @pablovazquez
CC @Jeroen-Bakker
CC @ideasman42

Seems like this was a somewhat intentional change in be985bdde2 Also see this comment in [D5889](https://archive.blender.org/developer/D5889) > In [D5889](https://archive.blender.org/developer/D5889)#135588, @PabloDobarro wrote: > - Hide gradient when resizing So whenever radial control is used for something other than `PROP_NONE`, `PROP_PIXEL`, `PROP_DISTANCE`, it draws with the (falloff) gradient, in our case [brush size], it draws without. Not sure I can follow that logic (think this is useful information which does not really distract), but will let module members decide... Use this to always show it: [P1853: #83603 snippet](https://archive.blender.org/developer/P1853.txt) ``` diff --git a/source/blender/windowmanager/intern/wm_operators.c b/source/blender/windowmanager/intern/wm_operators.c index a5b5f082c41..07a0690a3f2 100644 --- a/source/blender/windowmanager/intern/wm_operators.c +++ b/source/blender/windowmanager/intern/wm_operators.c @@ -2187,7 +2187,7 @@ static void radial_control_set_tex(RadialControl *rc) if ((ibuf = BKE_brush_gen_radial_control_imbuf( rc->image_id_ptr.data, rc->use_secondary_tex, - !ELEM(rc->subtype, PROP_NONE, PROP_PIXEL, PROP_DISTANCE)))) { + true))) { rc->texture = GPU_texture_create_2d( "radial_control", ibuf->x, ibuf->y, 1, GPU_R8, ibuf->rect_float); ``` CC @PabloDobarro CC @JulienKaspar CC @pablovazquez CC @Jeroen-Bakker CC @ideasman42

Philipp Oeser changed title from ~~Falloff (black middle circle) [F] key not appear show display~~ to Change Brush size does not show Falloff gradient anymore

2020-12-22 17:46:27 +01:00

Kent Davis commented

2020-12-22 17:50:13 +01:00

Yes correct.

Pablo Dobarro commented

2021-01-22 00:41:15 +01:00

Changed status from 'Confirmed' to: 'Archived'

Pablo Dobarro closed this issue

2021-01-22 00:41:15 +01:00

Pablo Dobarro commented

2021-01-22 00:41:15 +01:00

Using gradients to define a curve in the UI is rarely useful (you can't differentiate gray scale values with enough precision to determine the shape of the curve). This is why the curve preview with the line was added when changing the strength.
I consider this an UI design discussion, but in my opinion, the gradient falloff should be always hidden (maybe only show it multiplied on top of an alpha texture when it is being used).

Using gradients to define a curve in the UI is rarely useful (you can't differentiate gray scale values with enough precision to determine the shape of the curve). This is why the curve preview with the line was added when changing the strength. I consider this an UI design discussion, but in my opinion, the gradient falloff should be always hidden (maybe only show it multiplied on top of an alpha texture when it is being used).

Kent Davis commented

2021-01-22 00:58:37 +01:00

@PabloDobarro Do you have your own Macintosh?

Kent Davis commented

2021-01-23 19:06:34 +01:00

@lichtwerk Thank you for your support to change rename correct. I am not good english to explain but why @PabloDobarro put invalid without communication to me.
I ask him do they already inspect for Macintosh.

@lichtwerk Thank you for your support to change rename correct. I am not good english to explain but why @PabloDobarro put invalid without communication to me. I ask him do they already inspect for Macintosh.

Germano Cavalcante commented

2021-01-25 15:52:52 +01:00

@Kent-Davis, apparently the "Brush size gradient falloff" no longer showing was a design choice and not a bug.
The same is seen in other systems (not only Macintosh).

Since it is not really a bug (but something that was decided), the report has been closed.

@Kent-Davis, apparently the "Brush size gradient falloff" no longer showing was a design choice and not a bug. The same is seen in other systems (not only Macintosh). Since it is not really a bug (but something that was decided), the report has been closed.

Kent Davis commented

2021-01-25 15:56:22 +01:00

@mano-wii Thank you for explain me.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Change Brush size does not show Falloff gradient anymore #83603